Skip to content

Conversation

@DamianOsipiuk
Copy link
Contributor

  • useQueries accept queryClient as second parameter just like other hooks
  • solid useIsFetching and useIsMutating accept queryClient as second parameter

@DamianOsipiuk DamianOsipiuk requested review from TkDodo and ardeora March 7, 2023 20:23
@vercel
Copy link

vercel bot commented Mar 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
query ⬜️ Ignored (Inspect) Mar 9, 2023 at 10:18PM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 7, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2a77607:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

Copy link
Contributor

@ardeora ardeora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks great! Thanks for making these changes and making the API consistent

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0028a14) 90.73% compared to head (2a77607) 90.73%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #5092   +/-   ##
=======================================
  Coverage   90.73%   90.73%           
=======================================
  Files         110      110           
  Lines        3993     3993           
  Branches     1000      998    -2     
=======================================
  Hits         3623     3623           
  Misses        337      337           
  Partials       33       33           
Impacted Files Coverage Δ
packages/solid-query/src/createBaseQuery.ts 68.35% <ø> (ø)
packages/solid-query/src/createInfiniteQuery.ts 100.00% <ø> (ø)
packages/solid-query/src/createMutation.ts 100.00% <ø> (ø)
packages/solid-query/src/createQuery.ts 100.00% <ø> (ø)
packages/react-query/src/useQueries.ts 94.54% <100.00%> (ø)
packages/solid-query/src/createQueries.ts 100.00% <100.00%> (ø)
packages/solid-query/src/useIsFetching.ts 100.00% <100.00%> (ø)
packages/solid-query/src/useIsMutating.ts 100.00% <100.00%> (ø)
packages/svelte-query/src/createQueries.ts 100.00% <100.00%> (ø)
packages/vue-query/src/useQueries.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DamianOsipiuk DamianOsipiuk merged commit 237e1e7 into alpha Mar 10, 2023
@DamianOsipiuk DamianOsipiuk deleted the query-client-as-second-parameter branch March 10, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants