From 333ee1b98e52c90f913ebce21b46fa2bd6d6fb26 Mon Sep 17 00:00:00 2001 From: Lachlan Collins <1667261+lachlancollins@users.noreply.github.com> Date: Fri, 5 Jan 2024 13:14:55 +1100 Subject: [PATCH 1/2] ci: Avoid uploading coverage files in Nx cache --- .github/workflows/ci.yml | 2 ++ .github/workflows/pr.yml | 2 ++ 2 files changed, 4 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2774b1793a..d97204d5c7 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -53,3 +53,5 @@ jobs: TAG: ${{ inputs.tag }} - name: Upload coverage to Codecov uses: codecov/codecov-action@v3 + with: + directory: packages diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 2aeaf9b227..d7c68d215d 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -54,6 +54,8 @@ jobs: run: npx nx-cloud stop-all-agents - name: Upload coverage to Codecov uses: codecov/codecov-action@v3 + with: + directory: packages agents: name: Nx Cloud - Agents runs-on: ubuntu-latest From 6cda375bf2705eaa2f6ba813645a182ba9ab8db8 Mon Sep 17 00:00:00 2001 From: Lachlan Collins <1667261+lachlancollins@users.noreply.github.com> Date: Fri, 5 Jan 2024 13:21:13 +1100 Subject: [PATCH 2/2] Clean up config --- .github/workflows/ci.yml | 5 +++-- .github/workflows/pr.yml | 20 +++++++------------- 2 files changed, 10 insertions(+), 15 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d97204d5c7..de3baf5bf8 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,7 +23,8 @@ jobs: if: github.repository == 'TanStack/query' runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - name: Checkout + uses: actions/checkout@v4 with: fetch-depth: '0' - name: Setup pnpm @@ -36,7 +37,7 @@ jobs: node-version-file: .nvmrc cache: pnpm - name: Install dependencies - run: pnpm --filter "./packages/**" --filter query --prefer-offline install + run: pnpm install --frozen-lockfile --prefer-offline - name: Run Tests run: pnpm run test:ci - name: Publish diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index d7c68d215d..8ee509c25c 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -23,7 +23,8 @@ jobs: name: Nx Cloud - Main Job runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - name: Checkout + uses: actions/checkout@v4 with: fetch-depth: 0 - name: Setup pnpm @@ -35,16 +36,12 @@ jobs: with: node-version-file: .nvmrc cache: pnpm - cache-dependency-path: pnpm-lock.yaml - name: Install dependencies - run: pnpm --filter "./packages/**" --filter query --prefer-offline install - - name: Get appropriate base and head commits for `nx affected` commands + run: pnpm install --frozen-lockfile --prefer-offline + - name: Get base and head commits for `nx affected` uses: nrwl/nx-set-shas@v3 with: main-branch-name: 'main' - - run: | - echo "BASE: ${{ env.NX_BASE }}" - echo "HEAD: ${{ env.NX_HEAD }}" - name: Start CI Orchestrator run: npx nx-cloud start-ci-run - name: Run Tests @@ -76,9 +73,8 @@ jobs: with: node-version-file: .nvmrc cache: pnpm - cache-dependency-path: pnpm-lock.yaml - name: Install dependencies - run: pnpm --filter "./packages/**" --filter query --prefer-offline install + run: pnpm install --frozen-lockfile --prefer-offline - name: Start Nx Agent ${{ matrix.agent }} run: npx nx-cloud start-agent format: @@ -97,9 +93,8 @@ jobs: with: node-version-file: .nvmrc cache: pnpm - cache-dependency-path: pnpm-lock.yaml - name: Install dependencies - run: pnpm --filter "./packages/**" --filter query --prefer-offline install + run: pnpm install --frozen-lockfile --prefer-offline - name: Run prettier run: pnpm run test:format knip: @@ -118,8 +113,7 @@ jobs: with: node-version-file: .nvmrc cache: pnpm - cache-dependency-path: pnpm-lock.yaml - name: Install dependencies - run: pnpm --filter "./packages/**" --filter query --prefer-offline install + run: pnpm install --frozen-lockfile --prefer-offline - name: Run Knip run: pnpm knip