Skip to content

Conversation

@lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Nov 27, 2025

🎯 Changes

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Chores
    • Updated development dependencies for TypeScript ESLint tooling across packages.
    • Updated @changesets/cli dependency to the latest version.
    • Updated changesets configuration schema and added experimental options.

✏️ Tip: You can customize this high-level summary in your review settings.

@changeset-bot
Copy link

changeset-bot bot commented Nov 27, 2025

⚠️ No Changeset found

Latest commit: 7f92d36

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 27, 2025

Walkthrough

Updates the changesets configuration schema to version 3.1.2 with new ignore array and experimental options, bumps the changesets CLI dependency from 2.29.5 to 2.29.8, and upgrades TypeScript ESLint dependencies (parser and utils) from 8.44.1 to 8.48.0 across multiple packages.

Changes

Cohort / File(s) Summary
Changesets Configuration
.changeset/config.json, package.json
Updated changesets schema reference to 3.1.2, added ignore array and experimental options block with onlyUpdatePeerDependentsWhenOutOfRange flag; bumped @changesets/cli from ^2.29.5 to ^2.29.8
TypeScript ESLint Dependencies
packages/eslint-plugin-query/package.json, packages/svelte-query-devtools/package.json, packages/svelte-query-persist-client/package.json, packages/svelte-query/package.json
Upgraded @typescript-eslint/parser and @typescript-eslint/utils from ^8.44.1 to ^8.48.0 across all referenced packages

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • All changes are dependency version updates and configuration modifications
  • No logic changes, control flow modifications, or API alterations
  • Updates follow established patterns across the monorepo

Possibly related PRs

Suggested reviewers

  • TkDodo

Poem

🐰 Dependencies hop and bound,
Versions climb the semantic ground,
Changesets dance in config new,
Eight-point-forty-eight shines through!
TypeScript parsing smooth and bright, 🎉

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: enabling an experimental changesets option for peer dependencies configuration.
Description check ✅ Passed The description follows the template structure with all required sections completed: Changes section explains the purpose, Checklist items are marked, and Release Impact is properly indicated as CI/dev-only.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update-changesets

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aba3260 and 7f92d36.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (6)
  • .changeset/config.json (2 hunks)
  • package.json (1 hunks)
  • packages/eslint-plugin-query/package.json (1 hunks)
  • packages/svelte-query-devtools/package.json (1 hunks)
  • packages/svelte-query-persist-client/package.json (1 hunks)
  • packages/svelte-query/package.json (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-08-19T03:18:18.303Z
Learnt from: oscartbeaumont
Repo: TanStack/query PR: 9564
File: packages/solid-query-devtools/src/production.tsx:2-3
Timestamp: 2025-08-19T03:18:18.303Z
Learning: In the solid-query-devtools package, the codebase uses a pattern of type-only default imports combined with typeof for component type annotations (e.g., `import type SolidQueryDevtoolsComp from './devtools'` followed by `typeof SolidQueryDevtoolsComp`). This pattern is consistently used across index.tsx and production.tsx files, and the maintainers prefer consistency over changing this approach.

Applied to files:

  • packages/svelte-query-devtools/package.json
  • packages/svelte-query-persist-client/package.json
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
Repo: TanStack/query PR: 9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.

Applied to files:

  • packages/svelte-query-devtools/package.json
  • packages/svelte-query/package.json
  • packages/svelte-query-persist-client/package.json
  • packages/eslint-plugin-query/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Preview
  • GitHub Check: Test
🔇 Additional comments (6)
.changeset/config.json (1)

1-17: Configuration updates align with PR objectives.

The changesets schema has been properly updated to 3.1.2 with the new ignore and linked fields, and the experimental onlyUpdatePeerDependentsWhenOutOfRange option is correctly placed under ___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH. This experimental flag enables bumping peer dependents only when peerDependencies leave the specified range.

Verify that the schema URL https://unpkg.com/@changesets/config@3.1.2/schema.json is accessible and matches the expected schema for this version.

package.json (1)

44-44: @changesets/cli version bump is consistent with PR objectives.

The patch-level version bump from 2.29.5 to 2.29.8 enables support for the experimental peer dependency options configured in .changeset/config.json. This is a minor version change within the 2.x series.

Confirm that version 2.29.8 of @changesets/cli is available on npm and is the correct version that supports the onlyUpdatePeerDependentsWhenOutOfRange experimental option.

packages/eslint-plugin-query/package.json (1)

62-62: TypeScript ESLint packages updated consistently.

All @typescript-eslint packages have been bumped from 8.44.1 to 8.48.0 in a coordinated manner. This patch-level version alignment is appropriate for maintaining compatibility within the TypeScript ESLint toolchain.

Also applies to: 65-66

packages/svelte-query-devtools/package.json (1)

56-56: TypeScript ESLint parser updated consistently with other packages.

The version bump to 8.48.0 maintains consistency across the monorepo's TypeScript ESLint tooling.

packages/svelte-query-persist-client/package.json (1)

60-60: TypeScript ESLint parser updated consistently with other packages.

The version bump to 8.48.0 maintains consistency across the monorepo's TypeScript ESLint tooling.

packages/svelte-query/package.json (1)

59-59: TypeScript ESLint parser updated consistently with other packages.

The version bump to 8.48.0 maintains consistency across the monorepo's TypeScript ESLint tooling.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Nov 27, 2025

View your CI Pipeline Execution ↗ for commit 7f92d36

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 3s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-27 22:03:06 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 27, 2025

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9928

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9928

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9928

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9928

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9928

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9928

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9928

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9928

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9928

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9928

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9928

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9928

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9928

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9928

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9928

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9928

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9928

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9928

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9928

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9928

commit: 7f92d36

@github-actions
Copy link
Contributor

Sizes for commit 7f92d36:

Branch Bundle Size
Main
This PR

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.89%. Comparing base (aba3260) to head (7f92d36).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9928   +/-   ##
=======================================
  Coverage   45.89%   45.89%           
=======================================
  Files         200      200           
  Lines        8437     8437           
  Branches     1940     1940           
=======================================
  Hits         3872     3872           
  Misses       4116     4116           
  Partials      449      449           
Components Coverage Δ
@tanstack/angular-query-experimental 93.85% <ø> (ø)
@tanstack/eslint-plugin-query 83.59% <ø> (ø)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental 24.39% <ø> (ø)
@tanstack/query-codemods 0.00% <ø> (ø)
@tanstack/query-core 97.39% <ø> (ø)
@tanstack/query-devtools 3.48% <ø> (ø)
@tanstack/query-persist-client-core 80.00% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/query-test-utils 77.77% <ø> (ø)
@tanstack/react-query 96.01% <ø> (ø)
@tanstack/react-query-devtools 9.25% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 77.81% <ø> (ø)
@tanstack/solid-query-devtools 64.17% <ø> (ø)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query 71.91% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lachlancollins lachlancollins merged commit 73eb629 into main Nov 27, 2025
11 of 12 checks passed
@lachlancollins lachlancollins deleted the update-changesets branch November 27, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants