Skip to content

Conversation

@SeanCassiere
Copy link
Member

As per our documentation, the Route and LazyRoute classes should have all the same typed-hook as the RouteApi class. However, with the addition of the useNavigate hook to the RouteApi class, we forgot to implement the hook onto the Route and LazyRoute classes as well.

Closes #1384

@nx-cloud
Copy link

nx-cloud bot commented Mar 28, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5735f51. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@SeanCassiere SeanCassiere changed the title feat: implement the typed useNavigate hook onto the Route and LazyRoute class feat(react-router): implement the typed useNavigate hook onto the Route and LazyRoute class Mar 28, 2024
@schiller-manuel schiller-manuel merged commit 5eba66b into main Mar 28, 2024
@schiller-manuel schiller-manuel deleted the feat/add-use-navigate-to-route-and-lazyroute-classes branch March 28, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: make the typed useNavigate hook be accessible via the returns of createFileRoute and createLazyFileRoute

3 participants