From 8c27f6a1ac281a2c4cedf67d739ceede20cba9d3 Mon Sep 17 00:00:00 2001 From: Tom Ballinger Date: Tue, 31 Dec 2024 15:34:13 -0800 Subject: [PATCH 1/4] Avoid import assert syntax that doesn't work in Node.js 22 --- packages/create-start/src/modules/core/index.ts | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/packages/create-start/src/modules/core/index.ts b/packages/create-start/src/modules/core/index.ts index 97ea5a4321..459216c567 100644 --- a/packages/create-start/src/modules/core/index.ts +++ b/packages/create-start/src/modules/core/index.ts @@ -1,10 +1,10 @@ -import { dirname } from 'node:path' +import { dirname, resolve } from 'node:path' import { fileURLToPath } from 'node:url' +import { readFileSync } from 'node:fs'; import { z } from 'zod' import { packageJsonModule } from '../packageJson' import { createModule, runWithSpinner } from '../../module' import { ideModule } from '../ide' -import packageJson from '../../../package.json' assert { type: 'json' } import { packageManagerModule } from '../packageManager' import { initHelpers } from '../../utils/helpers' import { gitModule } from '../git' @@ -13,6 +13,13 @@ import { createDebugger } from '../../utils/debug' const __filename = fileURLToPath(import.meta.url) const __dirname = dirname(__filename) +const createStartPackageJson = JSON.parse( + readFileSync( + resolve(dirname(fileURLToPath(import.meta.url)), '../../../package.json'), + 'utf8' + ) +); + const debug = createDebugger('core-module') export const coreModule = createModule( @@ -243,7 +250,7 @@ export const coreModule = createModule( type DepNames< T extends - (typeof packageJson)['peerDependencies'] = (typeof packageJson)['peerDependencies'], + (typeof createStartPackageJson)['peerDependencies'] = (typeof createStartPackageJson)['peerDependencies'], > = keyof T const deps = async ( @@ -258,9 +265,9 @@ const deps = async ( const result = await Promise.all( depsArray.map((d) => { const version = - packageJson['peerDependencies'][d] === 'workspace:^' + createStartPackageJson['peerDependencies'][d] === 'workspace:^' ? 'latest' // Use latest in development - : packageJson['peerDependencies'][d] + : createStartPackageJson['peerDependencies'][d] return { name: d, version: version, From 11f3d9836747b950db0c3890fa278483ea70beac Mon Sep 17 00:00:00 2001 From: Tom Ballinger Date: Tue, 31 Dec 2024 15:47:43 -0800 Subject: [PATCH 2/4] add missing commander dep --- packages/create-start/package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/create-start/package.json b/packages/create-start/package.json index 07896c4a2b..6103e1e935 100644 --- a/packages/create-start/package.json +++ b/packages/create-start/package.json @@ -44,6 +44,7 @@ "dependencies": { "gradient-string": "^3.0.0", "@commander-js/extra-typings": "^12.1.0", + "commander": "^12.1.0", "@inquirer/prompts": "^5.5.0", "cross-spawn": "^7.0.5", "fast-glob": "^3.3.2", From 9e35295bdd719f94896ec4d8c3b61dd2092cc62d Mon Sep 17 00:00:00 2001 From: Tom Ballinger Date: Tue, 31 Dec 2024 16:00:13 -0800 Subject: [PATCH 3/4] update pnpm-lock --- pnpm-lock.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 05e2a3c0cb..9539189e7d 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -3311,6 +3311,9 @@ importers: '@types/react-dom': specifier: ^18.3.1 version: 18.3.1 + commander: + specifier: ^12.1.0 + version: 12.1.0 cross-spawn: specifier: ^7.0.5 version: 7.0.6 From e0266428182207cd1242c42242a6bd5bfe472fd2 Mon Sep 17 00:00:00 2001 From: "autofix-ci[bot]" <114827586+autofix-ci[bot]@users.noreply.github.com> Date: Wed, 1 Jan 2025 00:01:25 +0000 Subject: [PATCH 4/4] ci: apply automated fixes --- packages/create-start/src/modules/core/index.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/create-start/src/modules/core/index.ts b/packages/create-start/src/modules/core/index.ts index 459216c567..528d3d1cef 100644 --- a/packages/create-start/src/modules/core/index.ts +++ b/packages/create-start/src/modules/core/index.ts @@ -1,6 +1,6 @@ import { dirname, resolve } from 'node:path' import { fileURLToPath } from 'node:url' -import { readFileSync } from 'node:fs'; +import { readFileSync } from 'node:fs' import { z } from 'zod' import { packageJsonModule } from '../packageJson' import { createModule, runWithSpinner } from '../../module' @@ -16,9 +16,9 @@ const __dirname = dirname(__filename) const createStartPackageJson = JSON.parse( readFileSync( resolve(dirname(fileURLToPath(import.meta.url)), '../../../package.json'), - 'utf8' - ) -); + 'utf8', + ), +) const debug = createDebugger('core-module')