Skip to content

Implement meta tag deduplication logic #5676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Implement meta tag deduplication logic #5676

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99f1d14
Implement meta tag deduplication logic
juliusmarminge Oct 28, 2025
893579a
ci: apply automated fixes
autofix-ci[bot] Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/react-router/src/HeadContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ import { useRouter } from './useRouter'
import { useRouterState } from './useRouterState'
import type { RouterManagedTag } from '@tanstack/router-core'

const METAS_TO_ALLOW_MULTIPLE = new Set(['theme-color'])

function shouldDeduplicateMetaTag(attribute: string) {
return METAS_TO_ALLOW_MULTIPLE.has(attribute) === false
}

/**
* Build the list of head/link/meta/script tags to render for active matches.
* Used internally by `HeadContent`.
Expand Down Expand Up @@ -37,7 +43,10 @@ export const useTags = () => {
} else {
const attribute = m.name ?? m.property
if (attribute) {
if (metaByAttribute[attribute]) {
if (
metaByAttribute[attribute] &&
shouldDeduplicateMetaTag(attribute)
) {
continue
} else {
metaByAttribute[attribute] = true
Expand Down
Loading