From 19c77da7860fb7eb5918c35cb17584d0da466935 Mon Sep 17 00:00:00 2001
From: Kevin Van Cott <kevinvandy656@gmail.com>
Date: Wed, 28 Feb 2024 11:10:25 -0600
Subject: [PATCH 1/2] fix: column getIsVisible works for parent group columns

---
 packages/table-core/src/features/Visibility.ts | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/packages/table-core/src/features/Visibility.ts b/packages/table-core/src/features/Visibility.ts
index 55c020990f..38f20952b8 100644
--- a/packages/table-core/src/features/Visibility.ts
+++ b/packages/table-core/src/features/Visibility.ts
@@ -178,7 +178,12 @@ export const Visibility: TableFeature = {
       }
     }
     column.getIsVisible = () => {
-      return table.getState().columnVisibility?.[column.id] ?? true
+      const childColumns = column.columns
+      return (
+        (childColumns.length
+          ? childColumns.some(c => c.getIsVisible())
+          : table.getState().columnVisibility?.[column.id]) ?? true
+      )
     }
 
     column.getCanHide = () => {

From 8ace67940091147288497f3cb88385c73604c350 Mon Sep 17 00:00:00 2001
From: Kevin Van Cott <kevinvandy656@gmail.com>
Date: Wed, 28 Feb 2024 11:30:32 -0600
Subject: [PATCH 2/2] update snapshot

---
 .../__snapshots__/Visibility.test.tsx.snap    | 32 -------------------
 1 file changed, 32 deletions(-)

diff --git a/packages/react-table/__tests__/features/__snapshots__/Visibility.test.tsx.snap b/packages/react-table/__tests__/features/__snapshots__/Visibility.test.tsx.snap
index d0dd91ae75..04b21dd0c0 100644
--- a/packages/react-table/__tests__/features/__snapshots__/Visibility.test.tsx.snap
+++ b/packages/react-table/__tests__/features/__snapshots__/Visibility.test.tsx.snap
@@ -4,13 +4,9 @@ exports[`useReactTable > can toggle column visibility > 0 - after toggling all o
 {
   "footers": [
     [],
-    [],
-    [],
   ],
   "headers": [
     [],
-    [],
-    [],
   ],
   "rows": [
     [],
@@ -304,20 +300,6 @@ exports[`useReactTable > can toggle column visibility > 3 - after toggling More
         "1",
       ],
     ],
-    [
-      [
-        "",
-        "1",
-      ],
-      [
-        "",
-        "1",
-      ],
-      [
-        "",
-        "1",
-      ],
-    ],
     [
       [
         "Name",
@@ -340,20 +322,6 @@ exports[`useReactTable > can toggle column visibility > 3 - after toggling More
         "1",
       ],
     ],
-    [
-      [
-        "",
-        "1",
-      ],
-      [
-        "",
-        "1",
-      ],
-      [
-        "",
-        "1",
-      ],
-    ],
     [
       [
         "firstName",