From f44dea397acf0ef577a03d7b8e3b0c2f7016f318 Mon Sep 17 00:00:00 2001 From: Damian Pieczynski Date: Wed, 12 Mar 2025 16:58:01 +0100 Subject: [PATCH 1/3] fix(virtual-core): set `useScrollendEvent` default to false for better reliability --- docs/api/virtualizer.md | 2 +- packages/virtual-core/src/index.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/api/virtualizer.md b/docs/api/virtualizer.md index 09f91f4c..2a92c7e5 100644 --- a/docs/api/virtualizer.md +++ b/docs/api/virtualizer.md @@ -248,7 +248,7 @@ The implementation of this option is driven by the need for a reliable mechanism useScrollendEvent: boolean ``` -This option allows you to switch to use debounced fallback to reset the isScrolling instance property after `isScrollingResetDelay` milliseconds. The default value is `true`. +Determines whether to use the native scrollend event to detect when scrolling has stopped. If set to false, a debounced fallback is used to reset the isScrolling instance property after isScrollingResetDelay milliseconds. The default value is `false`. The implementation of this option is driven by the need for a reliable mechanism to handle scrolling behavior across different browsers. Until all browsers uniformly support the scrollEnd event. diff --git a/packages/virtual-core/src/index.ts b/packages/virtual-core/src/index.ts index d35427db..438c9592 100644 --- a/packages/virtual-core/src/index.ts +++ b/packages/virtual-core/src/index.ts @@ -438,7 +438,7 @@ export class Virtualizer< isScrollingResetDelay: 150, enabled: true, isRtl: false, - useScrollendEvent: true, + useScrollendEvent: false, useAnimationFrameWithResizeObserver: false, ...opts, } From 43bf4e3773916bbb1274722efff8a64726c89b09 Mon Sep 17 00:00:00 2001 From: Damian Pieczynski Date: Thu, 13 Mar 2025 15:39:48 +0100 Subject: [PATCH 2/3] Add changeset --- .changeset/mighty-melons-admire.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/mighty-melons-admire.md diff --git a/.changeset/mighty-melons-admire.md b/.changeset/mighty-melons-admire.md new file mode 100644 index 00000000..361c622d --- /dev/null +++ b/.changeset/mighty-melons-admire.md @@ -0,0 +1,5 @@ +--- +"@tanstack/virtual-core": patch +--- + +fix(virtual-core): set `useScrollendEvent` default to false for bette… From 889c2fd644fb7db37761731a583c93d72a396be6 Mon Sep 17 00:00:00 2001 From: "autofix-ci[bot]" <114827586+autofix-ci[bot]@users.noreply.github.com> Date: Thu, 13 Mar 2025 14:40:27 +0000 Subject: [PATCH 3/3] ci: apply automated fixes --- .changeset/mighty-melons-admire.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/mighty-melons-admire.md b/.changeset/mighty-melons-admire.md index 361c622d..8572e80f 100644 --- a/.changeset/mighty-melons-admire.md +++ b/.changeset/mighty-melons-admire.md @@ -1,5 +1,5 @@ --- -"@tanstack/virtual-core": patch +'@tanstack/virtual-core': patch --- fix(virtual-core): set `useScrollendEvent` default to false for bette…