Skip to content

refactoring: consolidate componentspec yaml parse load utils #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maxy-shpfy merged 2 commits into from
Dec 4, 2025
Merged

refactoring: consolidate componentspec yaml parse load utils #1466

maxy-shpfy merged 2 commits into from
Dec 4, 2025

Conversation

@maxy-shpfy
Copy link
Collaborator

@maxy-shpfy maxy-shpfy commented Dec 3, 2025 •
edited
Loading

Description

Moved YAML-related utility functions from componentStore.ts to yaml.ts to better organize code by functionality. Specifically, relocated componentSpecToYaml and componentSpecToText functions to the appropriate YAML utilities file and updated all imports across the codebase.

Type of Change

  • Cleanup/Refactor

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Test Instructions

  1. No functional changes to the app
  2. No regression should be found across the app

@maxy-shpfy maxy-shpfy mentioned this pull request Dec 3, 2025
Merged
4 tasks
@maxy-shpfy Graphite App
Copy link
Collaborator Author

maxy-shpfy commented Dec 3, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@maxy-shpfy maxy-shpfy mentioned this pull request Dec 3, 2025
Merged
4 tasks
@maxy-shpfy maxy-shpfy marked this pull request as ready for review December 3, 2025 19:01
@maxy-shpfy maxy-shpfy force-pushed the 12-03-refactoring_consolidate_componentspec_yaml_parse_load_utils branch from 457e5f1 to b018e4c Compare December 3, 2025 19:54
@maxy-shpfy maxy-shpfy force-pushed the 12-02-refactoring_introduce_componentspecfromyaml branch from 182f57a to 0675eb2 Compare December 3, 2025 19:54
@maxy-shpfy maxy-shpfy force-pushed the 12-03-refactoring_consolidate_componentspec_yaml_parse_load_utils branch from b018e4c to fa68a75 Compare December 3, 2025 20:04
@maxy-shpfy maxy-shpfy force-pushed the 12-02-refactoring_introduce_componentspecfromyaml branch from 0675eb2 to 27592d1 Compare December 3, 2025 20:04
@maxy-shpfy maxy-shpfy changed the base branch from 12-02-refactoring_introduce_componentspecfromyaml to graphite-base/1466 December 4, 2025 17:28
@maxy-shpfy maxy-shpfy force-pushed the 12-03-refactoring_consolidate_componentspec_yaml_parse_load_utils branch from fa68a75 to d54374e Compare December 4, 2025 18:16
@maxy-shpfy maxy-shpfy changed the base branch from graphite-base/1466 to master December 4, 2025 18:16
@maxy-shpfy Graphite App
Copy link
Collaborator Author

maxy-shpfy commented Dec 4, 2025 •
edited
Loading

Merge activity

  • Dec 4, 7:19 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Dec 4, 7:19 PM UTC: @maxy-shpfy merged this pull request with Graphite.

@maxy-shpfy maxy-shpfy merged commit dea3247 into master Dec 4, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mbeaulne Mbeaulne Mbeaulne approved these changes

@camielvs camielvs camielvs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maxy-shpfy @Mbeaulne @camielvs