Add k8s pod/cluster attributes to PENDING status span#254
Open
morgan-wowk wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 22, 2026
morgan-wowk
force-pushed
the
execution-tracing-error-data
branch
from
6581758 to
c73509f
Compare
morgan-wowk
force-pushed
the
execution-tracing-launcher-data
branch
from
3aa355d to
3e85d85
Compare
k8s.pod.name, k8s.namespace.name, k8s.cluster.url sourced from ContainerExecution.launcher_data. Handles kubernetes, kubernetes_job, and non-k8s launchers (SkyPilot) gracefully via early-return guards.
morgan-wowk
force-pushed
the
execution-tracing-error-data
branch
from
c73509f to
057544f
Compare
morgan-wowk
force-pushed
the
execution-tracing-launcher-data
branch
from
3e85d85 to
239a70c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Kubernetes pod/cluster attributes to PENDING execution spans
k8s.pod.name,k8s.namespace.name,k8s.cluster.urlsourced fromContainerExecution.launcher_data. Handleskubernetes,kubernetes_job,and non-k8s launchers (SkyPilot) gracefully via early-return guards.
The new
_launcher_pod_attrshelper only emits attributes when the spanstatus is
PENDINGandlauncher_datais present, so spans for otherstatuses or non-Kubernetes launchers are unaffected.
Screenshots