1.9 capability #1

Closed
dickeyxxx opened this Issue Aug 10, 2012 · 10 comments

2 participants

@dickeyxxx

This gem doesn't install for me in 1.9:

dickeyxxx@dickey-mbp ~/proj/tapjoyserver/tapjoyads 1.9.3-p194 (master ✔)
✗✗✗ bundle
Fetching gem metadata from http://rubygems.org/......
Fetching gem metadata from http://rubygems.org/..
Fetching git://github.com/Tapjoy/fakememcached.git
remote: Counting objects: 85, done.
remote: Compressing objects: 100% (57/57), done.
remote: Total 85 (delta 32), reused 73 (delta 20)
Receiving objects: 100% (85/85), 16.46 KiB, done.
Resolving deltas: 100% (32/32), done.
There was a LoadError while evaluating fakememcached.gemspec: 
cannot load such file -- lib/fakememcached/version from
  /Users/jdickey/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/bundler/gems/fakememcached-f1af18081af8/fakememcached.gemspec:2:in `<main>'

Does it try to require a relative path? That's been removed in Ruby 1.9.%

@dickeyxxx

@obrie can you fix this? It's actually pretty bad for me since I'm on mountain lion. I can only run 1.9 locally, and this makes it so I cannot deploy master.

@obrie
Tapjoy, Inc. member

Sure thing (completely missed this issue getting reported)

@dickeyxxx

no worries, I should've tagged you on it

@dickeyxxx

I suppose I also could've looked into the issue myself...

@dickeyxxx

any qualms about hooking this into travis?

@obrie obrie closed this in b722daa Aug 15, 2012
@obrie
Tapjoy, Inc. member

None at all, although worth noting that this library has no tests :(

@obrie
Tapjoy, Inc. member

(also: hopefully fixed now)

@obrie
Tapjoy, Inc. member

Oh I guess I should update the gemfile as well, huh!

@dickeyxxx

ah good point regarding lack of tests, probably not useful.

Should we put it up on rubygems.org though?

@obrie
Tapjoy, Inc. member

I think at this point we can probably declare that we'll be the official maintainers of this gem (just noting that this is forked from the Viximo repo). Given that, I'm definitely not opposed to pushing this to rubygems. @chiodo any thoughts here? repo is already public -- this'll just make it easier to install and push out versioned updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment