New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash parsing invalid comment block #10

Closed
greg84 opened this Issue Jul 6, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@greg84

greg84 commented Jul 6, 2016

We have an invalid comment block as below (it was generated by our authoring system - the bug that caused it is being fixed!):

<!-->

It throws an ArgumentOutOfRangeException exception on this line (Length cannot be less than zero. Parameter name: length), because the comment block is invalid and it can't find the closing --> sequence.

It would be nice if this markup error was ignored, perhaps by adding a check to ensure that commentEndPosition > -1 before trying to find the comment text?

@Taritsyn

This comment has been minimized.

Owner

Taritsyn commented Jul 6, 2016

Hello, Greg!

Thanks for information! I will fix this error in next release.

Taritsyn added a commit that referenced this issue Jul 9, 2016

1. Optimized memory usage;
2. Fixed a error #10 «Crash parsing invalid comment block».
@Taritsyn

This comment has been minimized.

Owner

Taritsyn commented Jul 9, 2016

Hello, Greg!

In WebMarkupMin 2.0.1 and 1.1.5 fixed this error.

@Taritsyn Taritsyn closed this Jul 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment