New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is SavedGzipInBytes a decimal? #18

Closed
rosemaryehlers opened this Issue Oct 24, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@rosemaryehlers

rosemaryehlers commented Oct 24, 2016

SavedGzipInBytes = OriginalGzipSize - MinifiedGzipSize;

But both OriginalGzipSize and MinifiedGzipSize are longs - having SavedGzipInBytes be a decimal seems unnecessary and confusing.

https://github.com/Taritsyn/WebMarkupMin/blob/master/src/WebMarkupMin.Core/MinificationStatistics.cs

@Taritsyn

This comment has been minimized.

Owner

Taritsyn commented Oct 25, 2016

Hello, Rosemary!

Thanks for information.

@Taritsyn

This comment has been minimized.

Owner

Taritsyn commented Nov 11, 2016

Hello, Rosemary!

In WebMarkupMin 2.2.2 fixed this error.

@Taritsyn Taritsyn closed this Nov 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment