New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<div>${{something}}</div> incorrectly minified #9

Closed
cweb187 opened this Issue Jun 9, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@cweb187

cweb187 commented Jun 9, 2016

I've run into an issue with v1.1.0 using this with mustache.js style templates.

<html><head></head><body> <!-- some white space to remove --> <div>${{Price}}</div></body></html>

is turned into:

<html><head></head><body><div>{{{Price}}}/div></div></body></html>

I'm wondering if this is some other template style causing this, although I did not see this issue in 0.9.9. I'm using these settings:

new HtmlMinificationSettings { RemoveOptionalEndTags = false, MinifyEmbeddedCssCode = false, MinifyInlineCssCode = false, AttributeQuotesRemovalMode = WebMarkupMin.Core.HtmlAttributeQuotesRemovalMode.KeepQuotes };

@Taritsyn

This comment has been minimized.

Owner

Taritsyn commented Jun 9, 2016

While rollback to version 1.0.0 (WebMarkupMin.Core and WebMarkupMin.Mvc can update to version 1.0.1).

In next week I will fix a errors.

@Taritsyn

This comment has been minimized.

Owner

Taritsyn commented Jun 14, 2016

Hello!

In WebMarkupMin 1.1.2 and 2.0.0 RC 9 fixed this error.

... v1.1.0 using this with mustache.js style templates.

WebMarkupMin does not support the Mustache templates. Only supports DOM-based templates: KnockoutJS, Kendo UI MVVM, AngularJS 1.X, Angular 2, Aurelia and Polymer. In this case, code containing {{ }} is processed as Angular or Polymer template.

@Taritsyn Taritsyn closed this Jun 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment