Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "x" to word field for advanced as well as regular search #1728

Closed
alanfgh opened this issue Dec 26, 2018 · 3 comments · Fixed by #2349
Closed

Add "x" to word field for advanced as well as regular search #1728

alanfgh opened this issue Dec 26, 2018 · 3 comments · Fixed by #2349
Assignees
Labels
enhancement Issue that describes a problem that requires a change in the current functionalities of Tatoeba. good first issue Easy issue for new contributors to get started.
Projects
Milestone

Comments

@alanfgh
Copy link
Contributor

alanfgh commented Dec 26, 2018

On the Wall, user cojiluc writes the following:

ln the search box, there is a small sign x which can be used to delete the content at once. It could be helpful if one has the same thing in the advanced search boxes, specially when using touch devices.

I agree. Note, however, that the advanced search word field is narrower than the regular search field, so the x will be smaller and harder to press.

@trang trang added the enhancement Issue that describes a problem that requires a change in the current functionalities of Tatoeba. label Jan 23, 2019
@trang trang added the good first issue Easy issue for new contributors to get started. label Feb 15, 2020
@gioele-santi
Copy link
Contributor

gioele-santi commented May 21, 2020

I'd like to work on this. I will check the code this weekend

@trang trang linked a pull request Jun 30, 2020 that will close this issue
@trang trang added this to the 2020-06-29 milestone Jun 30, 2020
@trang trang closed this as completed Jun 30, 2020
@trang trang added this to Done in Kodoeba #1 via automation Jun 30, 2020
@RyckRichards
Copy link
Member

RyckRichards commented Jun 30, 2020

Thanks a lot, @gioele-santi !

@alanfgh
Copy link
Contributor Author

alanfgh commented Jul 11, 2020

Yes, thanks for fixing this, @gioele-santi. Replacing the contents of the field is easier now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue that describes a problem that requires a change in the current functionalities of Tatoeba. good first issue Easy issue for new contributors to get started.
Projects
Kodoeba #1
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants