Insert a comma when sent or messages in inbox > 1,000

[RyckRichards]

It occurs to me that on https://tatoeba.org/eng/private_messages/folder/Sent (and on the Inbox folder too) a comma is not inserted when it's > 1,000.

https://prnt.sc/rg12j8

The same happened with the advanced search too not long ago.

[jiru]

As always, thanks for reporting the problem, Ricardo. 🌜

To anyone who wants to solve this issue: check Andrea’s recent pull request #1979.

[alanfgh]

Not only is It quite common for a thousands separator to be omitted for numbers less than 10,000, various manuals of style prefer it. From Wikipedia:

https://en.wikipedia.org/wiki/Decimal_separator#Exceptions_to_digit_grouping

Likewise, some manuals of style state that thousands separators should not be used in normal text for numbers from 1,000 to 9,999 inclusive where no decimal fractional part is shown (in other words, for four-digit whole numbers), whereas others use thousands separators, and others use both. For example, APA style stipulates a thousands separator for "most figures of 1,000 or more" except for page numbers, binary digits, temperatures, etc.

I myself prefer omission of a thousands separator in four-digit numbers.

[RyckRichards]

Should this

212,40: $newMessages = TableRegistry::get('PrivateMessages')->numberOfUnreadMessages

become

212,40: $newMessages = TableRegistry::get('PrivateMessages')->this->Number->format($numberOfUnreadMessages) ? @AndiPersti

[AndiPersti]

$this->Number->format() is a function which takes a number like so $formattedNumber = $this->Number->format(12345);. But in this case we don't write the number literally but it is stored in $newMessages so you need to put that variable inside the function instead of 123 and assign the result back to $newMessages.