Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When tag is deleted, remove it from the autocompletion table #301

Open
alanfgh opened this issue Jun 7, 2014 · 6 comments

Comments

Projects
None yet
5 participants
@alanfgh
Copy link
Contributor

commented Jun 7, 2014

According to sysko, there's an API call for when a tag is added, but none for when a tag is deleted. This probably requires a fix on both the tatoeba2 and the suggestd side.

@allan-simon

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2014

Suggestd, not tatodetect

On Saturday, June 07, 2014 10:35 PM, alanfgh wrote:

According to sysko, there's an API call for when a tag is added, but
none for when a tag is deleted. This probably requires a fix on both
the tatoeba2 and the Tatodetect side.


Reply to this email directly or view it on GitHub
#301.

@alanfgh

This comment has been minimized.

Copy link
Contributor Author

commented Jun 9, 2014

Sorry, I originally wrote "tatodetect", then corrected it to "suggestd", but GitHub didn't send you a notification saying I'd changed it. :)

@RyckRichards

This comment has been minimized.

Copy link
Member

commented Sep 12, 2015

Mentioned by Guybrush88 on Tatoeba Day 7 and on Tatoeba Day 8.

@trang

This comment has been minimized.

Copy link
Member

commented Sep 27, 2015

Note: restarting suggestd will update the autocompletion table.
sudo /etc/init.d/suggestd restart

@RyckRichards RyckRichards self-assigned this Mar 20, 2016

@RyckRichards

This comment has been minimized.

Copy link
Member

commented Feb 24, 2017

Still can experience this.

Step 1- choose a tag and remove it from all sentences
tag Slavs

http://dev.tatoeba.org/eng/tags/show_sentences_with_tag/40

http://prntscr.com/ecyypg

tag removed

http://prntscr.com/ecyyyx

this message was displayed after I removed "Slavs" from all sentences:

'Notice (8): Undefined index: Tag [APP/Model/Tag.php, line 273]"

step 2- going to tag a sentence as "Slavs". The autocompletition shouldn't suggest it.

http://prntscr.com/ecz00b

@jiru

This comment has been minimized.

Copy link
Member

commented Jun 19, 2018

Setting effort:medium because this needs a rework of how tags are removed from the table tags when the sentence count reaches zero. Currently, this is done by a trigger in docs/database/triggers/maintain_tags_number_of_sentences.sql, which prevents us from running anything else than SQL code upon tag removal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.