Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove ng-cloak from <body> #1825
We currently put
This PR is an attempt to make pages load faster by:
On most of the pages that have been converted to AngularJS (like /register), everything after the title is hidden during load. On the main page (/), the welcome message is displayed during loading. On pages that are not converted to AngularJS yet (like /sentences/show/), the content is displayed as soon as the page is downloaded.
Another indirect benefit is that CakePHP errors are not hidden by ng-cloak any more.
Besides the error with saving draft private messages, it looks good to me. I'm moving this to the next milestone to test a bit more.
One note on the user experience: instead of having the feeling that the website is slow, it actually gives me the feeling that the website is broken for a short moment, because I've been used to seeing everything appear at once. I suspect as a result that some users will also feel as if something is wrong at first, but will probably get used to it after some time.