Skip to content

[WiP] Test if you are changeling - #8359

Merged
KIBORG04 merged 11 commits into
TauCetiStation:masterfrom
volas:changeling_test
Feb 26, 2022
Merged

KIBORG04 merged 11 commits into
TauCetiStation:masterfrom
volas:changeling_test

Conversation

@volas

@volas volas commented Dec 7, 2021 •

Copy link
Copy Markdown
Member

Описание изменений

Resolve #8352

Подробно идея описывалась в ишью выше, с тех пор только немного упростилась реализация. Это просто двухкамерный тест-контейнер, в который заливается кровь (или любой другой реагент, если вы диверсант) шприцем. Переключение активной камеры куда заливать по вербу. Изьять реагенты обратно не возможно.

Для успешного положительного теста он должен содержать кровь разных генокрадов в двух камерах. Станции будет изначально предоставляться несколько тестов, где один из контейнеров уже гарантированно заполнен кровью генокрада. И несколько пустых, и будет возможность разработать и распечатать новые в РнД.

Кровь генокрада после изъятия или смерти оного остаётся активной и пригодной для теста не более 20 минут, гарантированно лишь минуту. Контейнеры в тестере сохраняют пригодность крови. Учитывая, что нет никакого способа достоверно узнать, что за кровь у вас на руках, и не выдохлась ли она уже (кроме самого теста, после которого кровь считай потеряна) - лучше всегда торопиться. И это так же будет причиной, почему корпорации и СБ вообще могут быть нужны живые генокрады.

Сам тест после загрузки материалов и запуска отрабатывает в течении 2-5 минут и пиликает о результате.

Можно промаркировать их ручкой.

На время ТМ-а добавил коробку в хранилище СБ и один не заправленный РД.

Авторство

Спрайт - Getup1 aka @Sakuya-Izayoi
Текст для инструкции при поддержке Лудука и Rogostic

Чеинжлог

🆑

  • rscadd[link]: Добавлен тест на генокрада
  • bugfix: В некоторых случаях кровь генокрада могла сохранять старый DNA, не смотря на трансформацию владельца

@TauKitty

TauKitty commented Dec 7, 2021

Copy link
Copy Markdown
Contributor
Changelog status: ✔️

@TauKitty TauKitty added Feature Новая фича Fix labels Dec 7, 2021
Comment thread code/game/gamemodes/modes_gameplays/changeling/test.dm Outdated
Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>
Comment thread code/game/gamemodes/modes_gameplays/changeling/test.dm Outdated
Comment thread code/game/gamemodes/modes_gameplays/changeling/test.dm Outdated
Comment thread code/game/gamemodes/modes_gameplays/changeling/test.dm Outdated
Comment thread code/game/gamemodes/modes_gameplays/changeling/test.dm
Comment thread code/game/gamemodes/modes_gameplays/changeling/test.dm Outdated
Comment thread code/game/gamemodes/modes_gameplays/changeling/test.dm
@ssbugman

ssbugman commented Dec 7, 2021 •

Copy link
Copy Markdown
Contributor

Любая идея с потенциально бесконечным созданием тестов на генок - плохая. Предлагали же брать не кровь которой можно взять сколько угодно и когда угодно, а материал с жертв генокрадов которого ограниченное количество чтобы тесты нельзя было колоть каждому кто попался на краже перчаток или выключил сенсоры.
И на самом старте надо не десяток тестов давать а всего 1.
Какой смысл так душить генок, на них нерф за нерфом сыплется, это уже третий за неделю. Они и так стали выживать к концу раунда в числе 0-1 штуки.

else // we were fast and blood is in secured location now to preserve marker
B.data["changeling_marker"]["timelimit"] = FALSE

/obj/item/weapon/changeling_test/verb/switch_chamber()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мне казалось, наоборот хотят уйти всячески от вербов к уже не совсем молодежным экшнам.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно экшен, мне просто кажется излишним. Тут всего два равнозначных взаимодействия с тестом - сменить активную камеру и запустить тест. Любой может быть на клик или верб или экшен. И верб для второго взаимодействия просто "ближе" к телу.

var/sting_range = 1
var/changelingID = "Changeling"
var/changelingID = "Changeling" // flavor ID like Theta/Tau/etc.
var/unique_changeling_marker // unique ID like DNA but secret

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А есть смысл добавлять ещё одну переменную, если можно юзать changelingId?

@KIBORG04
KIBORG04 marked this pull request as draft December 7, 2021 19:19
@volas
volas marked this pull request as ready for review December 12, 2021 07:26
Comment on lines +186 to +208
Инструкция по применению теста на генокрада.<br>
<br>
Тест содержит две заполняемые камеры: Камера A и Камера B.<br>
Вы можете переключать вводный клапан между этими двумя камерами для дальнейшего заполнения шприцем.<br>
<br>
Процедура тестирования:<br>
<br>
1.Заполните шприцем одну из камер кровью гарантированно подтвержденного генокрада (см. примечание 1). Часть предоставленных корпорацией тестов уже содержат кровь генокрада в Камере A и готовы к использованию.<br>
2. Заполните шприцем вторую камеру кровью тестируемого человека (см. примечание 1).<br>
3. Запустите тест в работу, ожидайте результатов в течении 5 минут.<br>
<br>
Если тест показал позитивный результат (зелёная лампа), это значит, что оба образца крови оказались от различных генокрадов и спровоцировали реакцию.<br>
<br>
Примечания:<br>
<br>
1. Кровь генокрада вне живого тела сохраняет свойства не более нескольких минут. После забора крови для теста <b>важно поместить её в тестовую камеру в первую же минуту</b>, где она будут сохранятся продолжительное время. В противном случае, результаты могут быть не точны. Максимально задукоментированное время активности крови вне специальных условий - около 20 минут.<br>
1.1. В случае забора крови умершего генокрада, счет времени идет от момента его смерти.<br>
2. Реакция не воспроизводится между образцами крови от одного и того же генокрада. Предоставленные корпорацией готовые тесты содержат кровь гарантированно подтвержденного и утилизированного генокрада, что исключает вероятность их ложного срабатывания.<br>
3. Имейте в виду, что изъятие образцов из тестовой камеры невозможно.
<br>
В связи со сложностями воспроизведения готовых тестов, корпорация НаноТрейзен не может предоставить достаточное количество всем объектам.<br>
В случае подозрений на появление генокрадов на объекте, рекомендуется использование готовых тестов для подтверждения генокрада, и использование подтвержденого генокрада для воспроизведения новых готовых тестов на месте.<br>
"}// ... соблюдайте осторожность, генокрады очень хитры и проворны. Нужен редакт.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

выделю на видное место

Comment on lines +1817 to +1824
/datum/design/changeling_test
name = "Changeling test"
desc = "Allows you to identify hidden changelings"
id = "changtest"
build_type = PROTOLATHE
materials = list(MAT_METAL = 12500, MAT_GOLD = 2000, MAT_DIAMOND = 3750, MAT_URANIUM = 4000)
build_path = /obj/item/weapon/changeling_test
category = list("Support")

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Сейчас тест технологии 1 биотеч, успешный тест 5 биотеч (~1500 очков).

Дизайн положил в Advanced Biotech, там уже лежат импланты что противодействие в других режимах. Я рассматривал Top-tier Biotech, но он довольно далеко что бы в ТМе их могли потом заметить.

Материалы почти от балды, нужно будет корректировать по фидбеку.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а есть какие-то гайдлайны для выставления материалов не от балды? o.o

@volas volas added Test Merge Candidate ПР с этим лэйблом будет или уже находится с тест мерже and removed Test Merge Candidate ПР с этим лэйблом будет или уже находится с тест мерже labels Dec 12, 2021
@TauKitty

Copy link
Copy Markdown
Contributor

This pull request has been mentioned on Tau Ceti Station Forum. There might be relevant details there:

https://forum.taucetistation.org/t/test-na-genokrada/30277/1

@TauKitty

Copy link
Copy Markdown
Contributor

This pull request has been mentioned on Tau Ceti Station Forum. There might be relevant details there:

https://forum.taucetistation.org/t/fidbek-na-metu-na-genokradov/29993/1

Comment on lines +115 to +118
/obj/item/weapon/changeling_test/verb/switch_chamber()
set name = "Switch opening chamber"
set category = "Object"
set src in range(0)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

гост может юзать этот верб

@LudwigVonChesterfield

LudwigVonChesterfield commented Feb 15, 2022 •

Copy link
Copy Markdown
Contributor

мержреди ли? и если нет - что надо, чтобы да

@volas

volas commented Feb 16, 2022

Copy link
Copy Markdown
Member Author

Я не уверен, всё забываю зайти в праймтайм да посмотреть как сейчас с тестами играют. До нг никто не умел, под нг на снежной карте было не очень проверять.

@KIBORG04
KIBORG04 merged commit ae68e4b into TauCetiStation:master Feb 26, 2022
TauKitty added a commit to TauCetiStation/ClassicChangelog that referenced this pull request Feb 26, 2022
LudwigVonChesterfield added a commit that referenced this pull request Mar 14, 2022
* full skills TODO - left only framework (#1)

* skills part 1

* part 2

* moved skills to the mind

* police and firearms check

* tactical reloads

* fixed empty space in storage after tactical reload

* refactored skills to use defines instead of string

* added console interaction with skill checks

* walls,glass,particle ac and shieldgen skills usage

* sleeper, RND stuff skill checks

* more machinery skill checks

* fixed life assist

* virology skill checks

* virology skill checks #2

* refactored skills checks to use defines

* fixed construction naming

* reworked to use Topic instead ui_interact to remove bug

* surgery buff

* reverted midi

* alternative skills sets for alt jobs

* fixed subskills, pills feed time and syringe gun usage

* fumbling with medical scanner

* smes skill check, syringe gun fix and scrubber fix

* scrubber fix

* wrong var name

* skill menu v0.5

* added skills to officer and reordered skills datums

* added chaging of skills and basic antag skills

* command skill part 1

* fixed wrong ids

* minor refactoring

* added silicons

* fixed construction

* added engineering checks for hacking and bombs

* pills, bottles and chemistry skills

* medical and construction fixes

* wrong number fix

* added skill datums for roles and fixed mergeSkills proc

* minor fixes

* better spacings and abductors skill datums

* whitespace fixes before PR

* changed description

* rcd usage

* fixed path

* Excess of closing tags

* fixed some bugs

* refactoring of skills part 1

* skills refactor part 2

* refactoring part 3

* fixes

* refactoring in progress

* final fixes

* spacing fix

* reduced interaction delay

* tweak

* refactoring of wires and cob_highlight

* fixed typo

* bonus spelling

* minor fixes

* fumbling after checks

* chemistry uncertanity

* missing new line

* removed combat mechas move buff, renamed param of handle_fumbling

* mecha fumbling

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* do_skilled proc

* exosuit skill checks tweaks

* melee skill is now working

* spacing fix

* spacing

* renamed fumble_around to do_skill_checks

* command skill now adds more buttons to the access console

* changed planting of mining explosive, more engineering skill checks

* more engineering and construction checks

* machinery construction skill

* Update code/modules/projectiles/guns/projectile.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* refactored skill types in jobs

* removed skill checks from flash

* removed visible message for others

* removed unused variable

* refactored using of skill bonus

* pill ingestion tweak

* changelings now gaining skills from absorbed people

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>
Co-authored-by: Dushess <dushesson@gmail.com>

* framework part 1

* merge 2

* i forgor

* reverted injection

* fix of endings

* skillsets refactor

* refactored skillsets (again)

* more checks and refactor

* changed case of procs, available_skillset is now cached

* runtime fix

* spacings

* huge refactor

* split to files

* job fix

* removed ambiguous brackets

* renamed skillsets in role to skillset_type

* renamed getSkillsType to snake case

* remove_skills_modifier fix

* better proc naming

* changed naming to datum

* naming of max and min

* snake case

* lazy add and lazy remove

* Реворк Контрабанд Сканнеров (#8285)

* semi-decent contraband finder rework

* better graphics (but at what cost(my sanity))

* capitalization in names

* bicon timestamps allowing to refresh cache

* contraband scanner refactors and features

* putting back the screen sprites

* не обыск обыска

* no tests made to production

* review changes

* midier? I barely know her!

* fixes?

* dmi driver? I barely know her!

* checks

Co-authored-by: LudwigVonChesterfield <{ID}+{username}@users.noreply.github.com>

* refactor

* minor refactorings

* as anything

* Огрызок рунчата, который работает и на Тау (#8404)

* Броня для бандитов (#8671)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* merge

* Public SSStatistics (Space Station Statistics) (#8596)

* wrong merge

* newlind at the end of file

* [WiP] Test if you are changeling (#8359)

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>
Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* Тест не кидал фейл и кодер думал, что код чёткий (#8702)

* 1

* Update ticker.dm

* test

* Update run-test.sh

* Щай тест пройдет чекайте

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* new osobki (#8684)

* eeeee

* Update negativeish.dm

* by review

* теперь без краски, чел просто в лужу упал.

* fixes

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Фиксы культа (#8672)

* mb fix mb net

* make runes_by_ckey lazy

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* involuntary speech runtime (#8703)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* Фикс маленькой опечатки в статистике (#8705)

* ой

* сикей просачился..

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Throwing no putdown animation (#8690)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* no pain - no gain (#8708)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* fixes allergy runtimes (#8707)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* merge

* update active skillset fix

* дермалка снова защищает от флешбенгов (#8718)

* fix

* Update code/modules/clothing/under/accessories/armor.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Фикс нереанимации у генки и живых людей (#8720)

* Убрал обновление из: Atmos Control, Communications

* Исправил обновление вендомата

* Небольшой фикс

* Update meteors.dm (#8722)

* fixing dionas pumping cats (#8721)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* Твик сбора статистики ливов (#8711)

* feature

* cryofix

* Not need

* migration ref

* refactor

* Вернул крио-стату

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Небольшой рефактор расчёта состояния обджективов (#8712)

* emae

* optimization aaaaeeeee

* ok and

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Фиксит возможность агента прослушки заспавниться до раундстарта (#8696)

* Update spawners.dm

* Update spawners.dm

* Update code/datums/spawners_menu/spawners.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Парочка фиксов (#8701)

* simple camera movement fix

* fix grab

* fix click from nullspace

* fix to_chat

* fix telemetry

* leave qdeling objects alone

* Revert "fix click from nullspace"

This reverts commit 0c14f69.

* Revert "leave qdeling objects alone"

This reverts commit fbda1b5.

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Уменьшение хардделов (#8725)

* factions fix

* spell and internal organ fix

* radial fix from tg

* mind cleanup from tg, human cleanup

* bug fixes

* kill useless code

* kill lastattacker ref

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* unsim environment (#8614)

* air unsim start

* footsteps, tracks and cleanables first iter

* revert air unsim

* unify human add blood

* refactor footsteps a bit

* Entered -> mobs

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Бафф и ренейм раундстартовых ивентов (#8674)

* Добавление аспектов в игру

* эм ок

* buff /datum/event/feature/area and his subtypes

* roundstart to feature

lol

* buff roundstart ebents

* compile

* ok, ya?

* some fixes

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* fixing mute talking guys (#8713)

* whywtfwtf (#8714)

* airlocks alt click menu (#8735)

* you can pull pda now with ctrlclick (#8737)

* фикс цвета расы при осмотре куклы. (#8726)

* Дионоквиркофиксі, память (#8732)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* Add and remove accessories via Alt Click (#8736)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* Небольшие фиксы, связанные с режимами (#8739)

* fix abductor duplicate scoreaboard

* slave role

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Небольшая документация для полей статистики (#8743)

* docs

* fix

* and

* Update stat_dto.dm

* by review

* Update statistics.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Environment turfs (#8616)

* first part

* second part

* 3rd part

* maps

* forgot about this

* air usim

* forgot about flora

* return set_dir

* - "Tracks" in space, - wet and slip for env turfs

* turf/simulated/environment -> turf/environment

* remove air_unsim

* redundant

* remove T

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* чейнжлинги больше не чувствуют грусть (#8756)

* 1

* Update screen1.dmi

* Update changeling.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* add cold overlay and fix ZASDBG (#8770)

* bruh (#4)

* skills part 1

* part 2

* moved skills to the mind

* police and firearms check

* tactical reloads

* fixed empty space in storage after tactical reload

* refactored skills to use defines instead of string

* added console interaction with skill checks

* walls,glass,particle ac and shieldgen skills usage

* sleeper, RND stuff skill checks

* more machinery skill checks

* fixed life assist

* virology skill checks

* virology skill checks #2

* refactored skills checks to use defines

* fixed construction naming

* reworked to use Topic instead ui_interact to remove bug

* surgery buff

* reverted midi

* alternative skills sets for alt jobs

* fixed subskills, pills feed time and syringe gun usage

* fumbling with medical scanner

* smes skill check, syringe gun fix and scrubber fix

* scrubber fix

* wrong var name

* skill menu v0.5

* added skills to officer and reordered skills datums

* added chaging of skills and basic antag skills

* command skill part 1

* fixed wrong ids

* minor refactoring

* added silicons

* fixed construction

* added engineering checks for hacking and bombs

* pills, bottles and chemistry skills

* medical and construction fixes

* wrong number fix

* added skill datums for roles and fixed mergeSkills proc

* minor fixes

* better spacings and abductors skill datums

* whitespace fixes before PR

* changed description

* rcd usage

* fixed path

* Excess of closing tags

* fixed some bugs

* refactoring of skills part 1

* skills refactor part 2

* refactoring part 3

* fixes

* refactoring in progress

* final fixes

* spacing fix

* reduced interaction delay

* tweak

* refactoring of wires and cob_highlight

* fixed typo

* bonus spelling

* minor fixes

* fumbling after checks

* chemistry uncertanity

* missing new line

* removed combat mechas move buff, renamed param of handle_fumbling

* mecha fumbling

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* do_skilled proc

* exosuit skill checks tweaks

* melee skill is now working

* spacing fix

* spacing

* renamed fumble_around to do_skill_checks

* command skill now adds more buttons to the access console

* changed planting of mining explosive, more engineering skill checks

* more engineering and construction checks

* machinery construction skill

* Update code/modules/projectiles/guns/projectile.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* refactored skill types in jobs

* removed skill checks from flash

* removed visible message for others

* removed unused variable

* refactored using of skill bonus

* pill ingestion tweak

* changelings now gaining skills from absorbed people

* content (#2)

* skills part 1

* part 2

* moved skills to the mind

* police and firearms check

* tactical reloads

* fixed empty space in storage after tactical reload

* refactored skills to use defines instead of string

* added console interaction with skill checks

* walls,glass,particle ac and shieldgen skills usage

* sleeper, RND stuff skill checks

* more machinery skill checks

* fixed life assist

* virology skill checks

* virology skill checks #2

* refactored skills checks to use defines

* fixed construction naming

* reworked to use Topic instead ui_interact to remove bug

* surgery buff

* reverted midi

* alternative skills sets for alt jobs

* fixed subskills, pills feed time and syringe gun usage

* fumbling with medical scanner

* smes skill check, syringe gun fix and scrubber fix

* scrubber fix

* wrong var name

* skill menu v0.5

* added skills to officer and reordered skills datums

* added chaging of skills and basic antag skills

* command skill part 1

* fixed wrong ids

* minor refactoring

* added silicons

* fixed construction

* added engineering checks for hacking and bombs

* pills, bottles and chemistry skills

* medical and construction fixes

* wrong number fix

* added skill datums for roles and fixed mergeSkills proc

* minor fixes

* better spacings and abductors skill datums

* whitespace fixes before PR

* changed description

* rcd usage

* fixed path

* Excess of closing tags

* fixed some bugs

* refactoring of skills part 1

* skills refactor part 2

* refactoring part 3

* fixes

* refactoring in progress

* final fixes

* spacing fix

* reduced interaction delay

* tweak

* refactoring of wires and cob_highlight

* fixed typo

* bonus spelling

* minor fixes

* fumbling after checks

* chemistry uncertanity

* missing new line

* removed combat mechas move buff, renamed param of handle_fumbling

* mecha fumbling

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* do_skilled proc

* exosuit skill checks tweaks

* melee skill is now working

* spacing fix

* spacing

* renamed fumble_around to do_skill_checks

* command skill now adds more buttons to the access console

* changed planting of mining explosive, more engineering skill checks

* more engineering and construction checks

* machinery construction skill

* Update code/modules/projectiles/guns/projectile.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* refactored skill types in jobs

* removed skill checks from flash

* removed visible message for others

* removed unused variable

* refactored using of skill bonus

* pill ingestion tweak

* changelings now gaining skills from absorbed people

* fixes hazard vest click (#8656)

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>
Co-authored-by: Dushess <dushesson@gmail.com>

* surgery, engineering, machine interactions

* forms removal

* forms removal

* reverted item attack

* atmospheric checks

* atmospheric checks

* skillsets refactor

* skillsets refactor

* Merge conflict fix

* fix

* fix

* refactored skillsets (again)

* refactored skillsets (again)

* more checks and refactor

* more checks and refactor

* merge

* proc change

* refactoring

* renamed fumbling_time_multiplier to fumbling_time_additional_delay

* use define

* Update code/game/mecha/mech_fabricator.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/virus2/isolator.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/virus2/dishincubator.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/virus2/diseasesplicer.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* pill examine refactor

* unused renaming fix and projectile.dm early return

* fierarms fix

* removed unused defines

* skillset now initing with default skills modifiers

* fixes

* removed alert

* refactor part 1 WIP

* refactor part 2

* refactor part 4

* lazy list and maximize fix

* timing of c4 fix

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>
Co-authored-by: Dushess <dushesson@gmail.com>

* Revert "bruh (#4)" (#5)

This reverts commit 2c928cb.

* skill is now an object

* Update code/datums/skills.dm

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* Auto Equip Accessories Fix (#8767)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* Твик статистики смертей (#8750)

* Перевод пары интерфейсов на новые компоненты (#8738)

* stacks

* Update tgui/packages/tgui/interfaces/MafiaPanel.js

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update tgui.bundle.js

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* шкёндёнёвскёй кнёпкё ё (#8784)

* Новое правило для пер. депа (#8763)

* Update TRANSLATION.md

* Update TRANSLATION.md

* Update TRANSLATION.md

* Update .github/wiki/TRANSLATION.md

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* pfix (#8785)

* Облегчение хостайлов. (#8613)

* chunk-based faction check

* rename

* tabs

* better faction check

* readibility

* step 8 -> 10 (hostiles have 9 vision range)

* if tweak

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* dont crash on me pedalgen (#8780)

* Подмены подмены, нерф скорости (#8727)

* podman ghostizing give control to another player

also slowing them down

* signals

* Update code/game/machinery/podmen.dm

* ghostize to ghost

* I guess it shouldn't

* podnymph

* cool memes (#8762)

* skrell resprite (#8677)

* skrell resprite

* Update r_skrell.dmi

* Update r_skrell.dmi

* resprote

* Update preferences_savefile.dm

Co-authored-by: Sakuya-Izayoi <30875884+Sakuya-Izayoi@users.noreply.github.com>
Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* scanning turfs with light sources doesn't lead to runtimes (#8787)

* Фиксы особок (#8772)

* oh boy

* scream to be heard

* eye reading

* oopsie

* salfix

* description

* adds a button

* phonotactics

* life env handling changes (#8771)

* life env handling changes
+cold breath
+prevent autoheal after dmg for 5 seconds
~lower env dmg to basic carbons
~some fixes

* try_autoheal

* fix

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* take_certain_bodypart_damage runtime fix (#8788)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* no more deep conversations with abductors meme, also smoking? (#8605)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* better phonotactics (#8791)

* Better Language Button (#8792)

* better phonotactics

* better buttons

* Фиксы фиксов (#8789)

* Фиксы фиксов

* cyberbulling

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/datums/qualities/positiveish.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Смазка видима (#8773)

* Make banan-slip half-great again

Soap still for robust. Bananas for smallguys.

* Make space lube half-great again

Removed invinsible effect, but adding second to timeslip

* Go back, banana_peel

* beginner moment

Как говорится: "я что-то нажал и всё исчезло", починил

* Update code/game/turfs/simulated.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/game/objects/items/weapons/clown_items.dm

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* destroyed any buffs

* no more lying

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>
Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* Особки О Языках Предупреждают Что Ты Знаешь Новые Языки (#8794)

* Briefcase usr -> user (#8790)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* sets point sampling as the default scaling. as it should be. (#8759)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* Микрорефактор Интент Селекшена (#8793)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* Фикс условий выдачи особки (#8795)

* секретная магия альт_аппиранса и плейнов

* ???

* че те надо гнида

* мать жива?

* походу нет

* хз работает ли я не тестил

* Update code/datums/qualities/positiveish.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* removing awaiting review exemptions (#8799)

* tiny pedalgen refactor (#8800)

* фикс рантайма при выходе во время выбора особки (#8801)

* wow?

* pointer problems

* player input problems (#8802)

* beam list removal on qdel (#8803)

* no runtimes on noticeboard qdel (#8804)

* less runtimes (#8805)

* less dna console runtimes

* donk pockets don't cool down

* fix tgui alert makealien (#8806)

* weird error (#8809)

* renamed skill_sets to skillsets and added checks for null in role.dm

* renamed  remove_modifier to remove_available_skillset

* fixed wrong melee weapons calc

* fixed clown and mime skills, centers the max skill button

* cultist are now starting without maxed out skills

* reverted max skills new()

* micro fixes

* Update cryopod.dm (#8818)

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/skills/skillset.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/skills/skillset.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/datums/skills.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* resetting the quality on respawn (#8821)

* fixes runtime on convert with no mob (#8796)

* fixes runtime with revolver archaeo find (#8797)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* Fixing Qualities For Map Disabled Jobs (#8820)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* Fixes flashbang runtime (#8824)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* 1 (#8825)

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* added global lists of skills and skillsets

* fixed bug with update_available skills

* end of file

* Moreosobki (#8812)

* 1

* Update positiveish.dm

* 2

* 3

* Update quirkieish.dm

* Update quirkieish.dm

* Update code/datums/qualities/negativeish.dm

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* Update negativeish.dm

* Update code/game/objects/items/weapons/implants/implant.dm

* Update positiveish.dm

Co-authored-by: KIBORG04 <bossmira4@gmail.com>
Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Воксонёрфы (#8819)

* nerfing voxs

* one more funny thing

* revert funny thing

* removed initial

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>
Co-authored-by: Dushess <dushesson@gmail.com>
Co-authored-by: LudwigVonChesterfield <{ID}+{username}@users.noreply.github.com>
Co-authored-by: KIBORG04 <bossmira4@gmail.com>
Co-authored-by: simb11 <84613249+simb11@users.noreply.github.com>
Co-authored-by: Alexander V <volas@ya.ru>
Co-authored-by: AndroBetel <44546836+AndroBetel@users.noreply.github.com>
Co-authored-by: Darth Sidious <andrgysev02@mail.ru>
Co-authored-by: kalazus <30507262+kalazus@users.noreply.github.com>
Co-authored-by: Sakuya-Izayoi <30875884+Sakuya-Izayoi@users.noreply.github.com>
Co-authored-by: Deahaka <96499407+Deahaka@users.noreply.github.com>
KIBORG04 added a commit that referenced this pull request Jun 3, 2022
* fix

* fix

* refactored skillsets (again)

* refactored skillsets (again)

* refactored skillsets (again)

* more checks and refactor

* more checks and refactor

* more checks and refactor

* changed case of procs, available_skillset is now cached

* runtime fix

* spacings

* huge refactor

* split to files

* job fix

* removed ambiguous brackets

* renamed skillsets in role to skillset_type

* renamed getSkillsType to snake case

* remove_skills_modifier fix

* better proc naming

* changed naming to datum

* naming of max and min

* snake case

* lazy add and lazy remove

* merge

* refactor

* proc change

* minor refactorings

* as anything

* refactoring

* merge

* renamed fumbling_time_multiplier to fumbling_time_additional_delay

* use define

* Update code/game/mecha/mech_fabricator.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* wrong merge

* Update code/modules/virus2/isolator.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/virus2/dishincubator.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/virus2/diseasesplicer.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* pill examine refactor

* unused renaming fix and projectile.dm early return

* fierarms fix

* removed unused defines

* newlind at the end of file

* merge

* update active skillset fix

* skillset now initing with default skills modifiers

* fixes

* removed alert

* refactor part 1 WIP

* refactor part 2

* refactor part 4

* lazy list and maximize fix

* timing of c4 fix

* removed police checks and melee checks

* bruh (#4)

* skills part 1

* part 2

* moved skills to the mind

* police and firearms check

* tactical reloads

* fixed empty space in storage after tactical reload

* refactored skills to use defines instead of string

* added console interaction with skill checks

* walls,glass,particle ac and shieldgen skills usage

* sleeper, RND stuff skill checks

* more machinery skill checks

* fixed life assist

* virology skill checks

* virology skill checks #2

* refactored skills checks to use defines

* fixed construction naming

* reworked to use Topic instead ui_interact to remove bug

* surgery buff

* reverted midi

* alternative skills sets for alt jobs

* fixed subskills, pills feed time and syringe gun usage

* fumbling with medical scanner

* smes skill check, syringe gun fix and scrubber fix

* scrubber fix

* wrong var name

* skill menu v0.5

* added skills to officer and reordered skills datums

* added chaging of skills and basic antag skills

* command skill part 1

* fixed wrong ids

* minor refactoring

* added silicons

* fixed construction

* added engineering checks for hacking and bombs

* pills, bottles and chemistry skills

* medical and construction fixes

* wrong number fix

* added skill datums for roles and fixed mergeSkills proc

* minor fixes

* better spacings and abductors skill datums

* whitespace fixes before PR

* changed description

* rcd usage

* fixed path

* Excess of closing tags

* fixed some bugs

* refactoring of skills part 1

* skills refactor part 2

* refactoring part 3

* fixes

* refactoring in progress

* final fixes

* spacing fix

* reduced interaction delay

* tweak

* refactoring of wires and cob_highlight

* fixed typo

* bonus spelling

* minor fixes

* fumbling after checks

* chemistry uncertanity

* missing new line

* removed combat mechas move buff, renamed param of handle_fumbling

* mecha fumbling

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* do_skilled proc

* exosuit skill checks tweaks

* melee skill is now working

* spacing fix

* spacing

* renamed fumble_around to do_skill_checks

* command skill now adds more buttons to the access console

* changed planting of mining explosive, more engineering skill checks

* more engineering and construction checks

* machinery construction skill

* Update code/modules/projectiles/guns/projectile.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* refactored skill types in jobs

* removed skill checks from flash

* removed visible message for others

* removed unused variable

* refactored using of skill bonus

* pill ingestion tweak

* changelings now gaining skills from absorbed people

* content (#2)

* skills part 1

* part 2

* moved skills to the mind

* police and firearms check

* tactical reloads

* fixed empty space in storage after tactical reload

* refactored skills to use defines instead of string

* added console interaction with skill checks

* walls,glass,particle ac and shieldgen skills usage

* sleeper, RND stuff skill checks

* more machinery skill checks

* fixed life assist

* virology skill checks

* virology skill checks #2

* refactored skills checks to use defines

* fixed construction naming

* reworked to use Topic instead ui_interact to remove bug

* surgery buff

* reverted midi

* alternative skills sets for alt jobs

* fixed subskills, pills feed time and syringe gun usage

* fumbling with medical scanner

* smes skill check, syringe gun fix and scrubber fix

* scrubber fix

* wrong var name

* skill menu v0.5

* added skills to officer and reordered skills datums

* added chaging of skills and basic antag skills

* command skill part 1

* fixed wrong ids

* minor refactoring

* added silicons

* fixed construction

* added engineering checks for hacking and bombs

* pills, bottles and chemistry skills

* medical and construction fixes

* wrong number fix

* added skill datums for roles and fixed mergeSkills proc

* minor fixes

* better spacings and abductors skill datums

* whitespace fixes before PR

* changed description

* rcd usage

* fixed path

* Excess of closing tags

* fixed some bugs

* refactoring of skills part 1

* skills refactor part 2

* refactoring part 3

* fixes

* refactoring in progress

* final fixes

* spacing fix

* reduced interaction delay

* tweak

* refactoring of wires and cob_highlight

* fixed typo

* bonus spelling

* minor fixes

* fumbling after checks

* chemistry uncertanity

* missing new line

* removed combat mechas move buff, renamed param of handle_fumbling

* mecha fumbling

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* do_skilled proc

* exosuit skill checks tweaks

* melee skill is now working

* spacing fix

* spacing

* renamed fumble_around to do_skill_checks

* command skill now adds more buttons to the access console

* changed planting of mining explosive, more engineering skill checks

* more engineering and construction checks

* machinery construction skill

* Update code/modules/projectiles/guns/projectile.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* refactored skill types in jobs

* removed skill checks from flash

* removed visible message for others

* removed unused variable

* refactored using of skill bonus

* pill ingestion tweak

* changelings now gaining skills from absorbed people

* fixes hazard vest click (#8656)

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>
Co-authored-by: Dushess <dushesson@gmail.com>

* surgery, engineering, machine interactions

* forms removal

* forms removal

* reverted item attack

* atmospheric checks

* atmospheric checks

* skillsets refactor

* skillsets refactor

* Merge conflict fix

* fix

* fix

* refactored skillsets (again)

* refactored skillsets (again)

* more checks and refactor

* more checks and refactor

* merge

* proc change

* refactoring

* renamed fumbling_time_multiplier to fumbling_time_additional_delay

* use define

* Update code/game/mecha/mech_fabricator.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/virus2/isolator.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/virus2/dishincubator.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/virus2/diseasesplicer.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* pill examine refactor

* unused renaming fix and projectile.dm early return

* fierarms fix

* removed unused defines

* skillset now initing with default skills modifiers

* fixes

* removed alert

* refactor part 1 WIP

* refactor part 2

* refactor part 4

* lazy list and maximize fix

* timing of c4 fix

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>
Co-authored-by: Dushess <dushesson@gmail.com>

* Revert "bruh (#4)" (#5)

This reverts commit 2c928cbd81323ce1b31c966469a5f84b3e3fb533.

* skill is now an object

* Update code/datums/skills.dm

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* renamed skill_sets to skillsets and added checks for null in role.dm

* renamed  remove_modifier to remove_available_skillset

* fixed wrong melee weapons calc

* fixed clown and mime skills, centers the max skill button

* cultist are now starting without maxed out skills

* reverted max skills new()

* micro fixes

* added global lists of skills and skillsets

* added global lists of skills and skillsets

* fixed bug with update_available skills

* fixed bug

* forgor

* end of file

* removed initial

* removed initial

* Система умений для персонажей  (part 1 - framework) (#8668)

* full skills TODO - left only framework (#1)

* skills part 1

* part 2

* moved skills to the mind

* police and firearms check

* tactical reloads

* fixed empty space in storage after tactical reload

* refactored skills to use defines instead of string

* added console interaction with skill checks

* walls,glass,particle ac and shieldgen skills usage

* sleeper, RND stuff skill checks

* more machinery skill checks

* fixed life assist

* virology skill checks

* virology skill checks #2

* refactored skills checks to use defines

* fixed construction naming

* reworked to use Topic instead ui_interact to remove bug

* surgery buff

* reverted midi

* alternative skills sets for alt jobs

* fixed subskills, pills feed time and syringe gun usage

* fumbling with medical scanner

* smes skill check, syringe gun fix and scrubber fix

* scrubber fix

* wrong var name

* skill menu v0.5

* added skills to officer and reordered skills datums

* added chaging of skills and basic antag skills

* command skill part 1

* fixed wrong ids

* minor refactoring

* added silicons

* fixed construction

* added engineering checks for hacking and bombs

* pills, bottles and chemistry skills

* medical and construction fixes

* wrong number fix

* added skill datums for roles and fixed mergeSkills proc

* minor fixes

* better spacings and abductors skill datums

* whitespace fixes before PR

* changed description

* rcd usage

* fixed path

* Excess of closing tags

* fixed some bugs

* refactoring of skills part 1

* skills refactor part 2

* refactoring part 3

* fixes

* refactoring in progress

* final fixes

* spacing fix

* reduced interaction delay

* tweak

* refactoring of wires and cob_highlight

* fixed typo

* bonus spelling

* minor fixes

* fumbling after checks

* chemistry uncertanity

* missing new line

* removed combat mechas move buff, renamed param of handle_fumbling

* mecha fumbling

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* do_skilled proc

* exosuit skill checks tweaks

* melee skill is now working

* spacing fix

* spacing

* renamed fumble_around to do_skill_checks

* command skill now adds more buttons to the access console

* changed planting of mining explosive, more engineering skill checks

* more engineering and construction checks

* machinery construction skill

* Update code/modules/projectiles/guns/projectile.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* refactored skill types in jobs

* removed skill checks from flash

* removed visible message for others

* removed unused variable

* refactored using of skill bonus

* pill ingestion tweak

* changelings now gaining skills from absorbed people

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>
Co-authored-by: Dushess <dushesson@gmail.com>

* framework part 1

* merge 2

* i forgor

* reverted injection

* fix of endings

* skillsets refactor

* refactored skillsets (again)

* more checks and refactor

* changed case of procs, available_skillset is now cached

* runtime fix

* spacings

* huge refactor

* split to files

* job fix

* removed ambiguous brackets

* renamed skillsets in role to skillset_type

* renamed getSkillsType to snake case

* remove_skills_modifier fix

* better proc naming

* changed naming to datum

* naming of max and min

* snake case

* lazy add and lazy remove

* Реворк Контрабанд Сканнеров (#8285)

* semi-decent contraband finder rework

* better graphics (but at what cost(my sanity))

* capitalization in names

* bicon timestamps allowing to refresh cache

* contraband scanner refactors and features

* putting back the screen sprites

* не обыск обыска

* no tests made to production

* review changes

* midier? I barely know her!

* fixes?

* dmi driver? I barely know her!

* checks

Co-authored-by: LudwigVonChesterfield <{ID}+{username}@users.noreply.github.com>

* refactor

* minor refactorings

* as anything

* Огрызок рунчата, который работает и на Тау (#8404)

* Броня для бандитов (#8671)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* merge

* Public SSStatistics (Space Station Statistics) (#8596)

* wrong merge

* newlind at the end of file

* [WiP] Test if you are changeling (#8359)

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>
Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* Тест не кидал фейл и кодер думал, что код чёткий (#8702)

* 1

* Update ticker.dm

* test

* Update run-test.sh

* Щай тест пройдет чекайте

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* new osobki (#8684)

* eeeee

* Update negativeish.dm

* by review

* теперь без краски, чел просто в лужу упал.

* fixes

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Фиксы культа (#8672)

* mb fix mb net

* make runes_by_ckey lazy

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* involuntary speech runtime (#8703)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* Фикс маленькой опечатки в статистике (#8705)

* ой

* сикей просачился..

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Throwing no putdown animation (#8690)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* no pain - no gain (#8708)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* fixes allergy runtimes (#8707)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* merge

* update active skillset fix

* дермалка снова защищает от флешбенгов (#8718)

* fix

* Update code/modules/clothing/under/accessories/armor.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Фикс нереанимации у генки и живых людей (#8720)

* Убрал обновление из: Atmos Control, Communications

* Исправил обновление вендомата

* Небольшой фикс

* Update meteors.dm (#8722)

* fixing dionas pumping cats (#8721)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* Твик сбора статистики ливов (#8711)

* feature

* cryofix

* Not need

* migration ref

* refactor

* Вернул крио-стату

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Небольшой рефактор расчёта состояния обджективов (#8712)

* emae

* optimization aaaaeeeee

* ok and

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Фиксит возможность агента прослушки заспавниться до раундстарта (#8696)

* Update spawners.dm

* Update spawners.dm

* Update code/datums/spawners_menu/spawners.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Парочка фиксов (#8701)

* simple camera movement fix

* fix grab

* fix click from nullspace

* fix to_chat

* fix telemetry

* leave qdeling objects alone

* Revert "fix click from nullspace"

This reverts commit 0c14f693552222f40b591be3957a1a744758ee64.

* Revert "leave qdeling objects alone"

This reverts commit fbda1b51dafe7f83bf26a8358826f14bc3d57f47.

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Уменьшение хардделов (#8725)

* factions fix

* spell and internal organ fix

* radial fix from tg

* mind cleanup from tg, human cleanup

* bug fixes

* kill useless code

* kill lastattacker ref

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* unsim environment (#8614)

* air unsim start

* footsteps, tracks and cleanables first iter

* revert air unsim

* unify human add blood

* refactor footsteps a bit

* Entered -> mobs

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Бафф и ренейм раундстартовых ивентов (#8674)

* Добавление аспектов в игру

* эм ок

* buff /datum/event/feature/area and his subtypes

* roundstart to feature

lol

* buff roundstart ebents

* compile

* ok, ya?

* some fixes

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* fixing mute talking guys (#8713)

* whywtfwtf (#8714)

* airlocks alt click menu (#8735)

* you can pull pda now with ctrlclick (#8737)

* фикс цвета расы при осмотре куклы. (#8726)

* Дионоквиркофиксі, память (#8732)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* Add and remove accessories via Alt Click (#8736)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* Небольшие фиксы, связанные с режимами (#8739)

* fix abductor duplicate scoreaboard

* slave role

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Небольшая документация для полей статистики (#8743)

* docs

* fix

* and

* Update stat_dto.dm

* by review

* Update statistics.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Environment turfs (#8616)

* first part

* second part

* 3rd part

* maps

* forgot about this

* air usim

* forgot about flora

* return set_dir

* - "Tracks" in space, - wet and slip for env turfs

* turf/simulated/environment -> turf/environment

* remove air_unsim

* redundant

* remove T

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* чейнжлинги больше не чувствуют грусть (#8756)

* 1

* Update screen1.dmi

* Update changeling.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* add cold overlay and fix ZASDBG (#8770)

* bruh (#4)

* skills part 1

* part 2

* moved skills to the mind

* police and firearms check

* tactical reloads

* fixed empty space in storage after tactical reload

* refactored skills to use defines instead of string

* added console interaction with skill checks

* walls,glass,particle ac and shieldgen skills usage

* sleeper, RND stuff skill checks

* more machinery skill checks

* fixed life assist

* virology skill checks

* virology skill checks #2

* refactored skills checks to use defines

* fixed construction naming

* reworked to use Topic instead ui_interact to remove bug

* surgery buff

* reverted midi

* alternative skills sets for alt jobs

* fixed subskills, pills feed time and syringe gun usage

* fumbling with medical scanner

* smes skill check, syringe gun fix and scrubber fix

* scrubber fix

* wrong var name

* skill menu v0.5

* added skills to officer and reordered skills datums

* added chaging of skills and basic antag skills

* command skill part 1

* fixed wrong ids

* minor refactoring

* added silicons

* fixed construction

* added engineering checks for hacking and bombs

* pills, bottles and chemistry skills

* medical and construction fixes

* wrong number fix

* added skill datums for roles and fixed mergeSkills proc

* minor fixes

* better spacings and abductors skill datums

* whitespace fixes before PR

* changed description

* rcd usage

* fixed path

* Excess of closing tags

* fixed some bugs

* refactoring of skills part 1

* skills refactor part 2

* refactoring part 3

* fixes

* refactoring in progress

* final fixes

* spacing fix

* reduced interaction delay

* tweak

* refactoring of wires and cob_highlight

* fixed typo

* bonus spelling

* minor fixes

* fumbling after checks

* chemistry uncertanity

* missing new line

* removed combat mechas move buff, renamed param of handle_fumbling

* mecha fumbling

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* do_skilled proc

* exosuit skill checks tweaks

* melee skill is now working

* spacing fix

* spacing

* renamed fumble_around to do_skill_checks

* command skill now adds more buttons to the access console

* changed planting of mining explosive, more engineering skill checks

* more engineering and construction checks

* machinery construction skill

* Update code/modules/projectiles/guns/projectile.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* refactored skill types in jobs

* removed skill checks from flash

* removed visible message for others

* removed unused variable

* refactored using of skill bonus

* pill ingestion tweak

* changelings now gaining skills from absorbed people

* content (#2)

* skills part 1

* part 2

* moved skills to the mind

* police and firearms check

* tactical reloads

* fixed empty space in storage after tactical reload

* refactored skills to use defines instead of string

* added console interaction with skill checks

* walls,glass,particle ac and shieldgen skills usage

* sleeper, RND stuff skill checks

* more machinery skill checks

* fixed life assist

* virology skill checks

* virology skill checks #2

* refactored skills checks to use defines

* fixed construction naming

* reworked to use Topic instead ui_interact to remove bug

* surgery buff

* reverted midi

* alternative skills sets for alt jobs

* fixed subskills, pills feed time and syringe gun usage

* fumbling with medical scanner

* smes skill check, syringe gun fix and scrubber fix

* scrubber fix

* wrong var name

* skill menu v0.5

* added skills to officer and reordered skills datums

* added chaging of skills and basic antag skills

* command skill part 1

* fixed wrong ids

* minor refactoring

* added silicons

* fixed construction

* added engineering checks for hacking and bombs

* pills, bottles and chemistry skills

* medical and construction fixes

* wrong number fix

* added skill datums for roles and fixed mergeSkills proc

* minor fixes

* better spacings and abductors skill datums

* whitespace fixes before PR

* changed description

* rcd usage

* fixed path

* Excess of closing tags

* fixed some bugs

* refactoring of skills part 1

* skills refactor part 2

* refactoring part 3

* fixes

* refactoring in progress

* final fixes

* spacing fix

* reduced interaction delay

* tweak

* refactoring of wires and cob_highlight

* fixed typo

* bonus spelling

* minor fixes

* fumbling after checks

* chemistry uncertanity

* missing new line

* removed combat mechas move buff, renamed param of handle_fumbling

* mecha fumbling

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* do_skilled proc

* exosuit skill checks tweaks

* melee skill is now working

* spacing fix

* spacing

* renamed fumble_around to do_skill_checks

* command skill now adds more buttons to the access console

* changed planting of mining explosive, more engineering skill checks

* more engineering and construction checks

* machinery construction skill

* Update code/modules/projectiles/guns/projectile.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* refactored skill types in jobs

* removed skill checks from flash

* removed visible message for others

* removed unused variable

* refactored using of skill bonus

* pill ingestion tweak

* changelings now gaining skills from absorbed people

* fixes hazard vest click (#8656)

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>
Co-authored-by: Dushess <dushesson@gmail.com>

* surgery, engineering, machine interactions

* forms removal

* forms removal

* reverted item attack

* atmospheric checks

* atmospheric checks

* skillsets refactor

* skillsets refactor

* Merge conflict fix

* fix

* fix

* refactored skillsets (again)

* refactored skillsets (again)

* more checks and refactor

* more checks and refactor

* merge

* proc change

* refactoring

* renamed fumbling_time_multiplier to fumbling_time_additional_delay

* use define

* Update code/game/mecha/mech_fabricator.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/virus2/isolator.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/virus2/dishincubator.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/virus2/diseasesplicer.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* pill examine refactor

* unused renaming fix and projectile.dm early return

* fierarms fix

* removed unused defines

* skillset now initing with default skills modifiers

* fixes

* removed alert

* refactor part 1 WIP

* refactor part 2

* refactor part 4

* lazy list and maximize fix

* timing of c4 fix

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>
Co-authored-by: Dushess <dushesson@gmail.com>

* Revert "bruh (#4)" (#5)

This reverts commit 2c928cbd81323ce1b31c966469a5f84b3e3fb533.

* skill is now an object

* Update code/datums/skills.dm

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* Auto Equip Accessories Fix (#8767)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* Твик статистики смертей (#8750)

* Перевод пары интерфейсов на новые компоненты (#8738)

* stacks

* Update tgui/packages/tgui/interfaces/MafiaPanel.js

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update tgui.bundle.js

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* шкёндёнёвскёй кнёпкё ё (#8784)

* Новое правило для пер. депа (#8763)

* Update TRANSLATION.md

* Update TRANSLATION.md

* Update TRANSLATION.md

* Update .github/wiki/TRANSLATION.md

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* pfix (#8785)

* Облегчение хостайлов. (#8613)

* chunk-based faction check

* rename

* tabs

* better faction check

* readibility

* step 8 -> 10 (hostiles have 9 vision range)

* if tweak

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* dont crash on me pedalgen (#8780)

* Подмены подмены, нерф скорости (#8727)

* podman ghostizing give control to another player

also slowing them down

* signals

* Update code/game/machinery/podmen.dm

* ghostize to ghost

* I guess it shouldn't

* podnymph

* cool memes (#8762)

* skrell resprite (#8677)

* skrell resprite

* Update r_skrell.dmi

* Update r_skrell.dmi

* resprote

* Update preferences_savefile.dm

Co-authored-by: Sakuya-Izayoi <30875884+Sakuya-Izayoi@users.noreply.github.com>
Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* scanning turfs with light sources doesn't lead to runtimes (#8787)

* Фиксы особок (#8772)

* oh boy

* scream to be heard

* eye reading

* oopsie

* salfix

* description

* adds a button

* phonotactics

* life env handling changes (#8771)

* life env handling changes
+cold breath
+prevent autoheal after dmg for 5 seconds
~lower env dmg to basic carbons
~some fixes

* try_autoheal

* fix

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* take_certain_bodypart_damage runtime fix (#8788)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* no more deep conversations with abductors meme, also smoking? (#8605)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* better phonotactics (#8791)

* Better Language Button (#8792)

* better phonotactics

* better buttons

* Фиксы фиксов (#8789)

* Фиксы фиксов

* cyberbulling

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/datums/qualities/positiveish.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Смазка видима (#8773)

* Make banan-slip half-great again

Soap still for robust. Bananas for smallguys.

* Make space lube half-great again

Removed invinsible effect, but adding second to timeslip

* Go back, banana_peel

* beginner moment

Как говорится: "я что-то нажал и всё исчезло", починил

* Update code/game/turfs/simulated.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/game/objects/items/weapons/clown_items.dm

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* destroyed any buffs

* no more lying

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>
Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* Особки О Языках Предупреждают Что Ты Знаешь Новые Языки (#8794)

* Briefcase usr -> user (#8790)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* sets point sampling as the default scaling. as it should be. (#8759)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* Микрорефактор Интент Селекшена (#8793)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* Фикс условий выдачи особки (#8795)

* секретная магия альт_аппиранса и плейнов

* ???

* че те надо гнида

* мать жива?

* походу нет

* хз работает ли я не тестил

* Update code/datums/qualities/positiveish.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* removing awaiting review exemptions (#8799)

* tiny pedalgen refactor (#8800)

* фикс рантайма при выходе во время выбора особки (#8801)

* wow?

* pointer problems

* player input problems (#8802)

* beam list removal on qdel (#8803)

* no runtimes on noticeboard qdel (#8804)

* less runtimes (#8805)

* less dna console runtimes

* donk pockets don't cool down

* fix tgui alert makealien (#8806)

* weird error (#8809)

* renamed skill_sets to skillsets and added checks for null in role.dm

* renamed  remove_modifier to remove_available_skillset

* fixed wrong melee weapons calc

* fixed clown and mime skills, centers the max skill button

* cultist are now starting without maxed out skills

* reverted max skills new()

* micro fixes

* Update cryopod.dm (#8818)

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/skills/skillset.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/skills/skillset.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/datums/skills.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* resetting the quality on respawn (#8821)

* fixes runtime on convert with no mob (#8796)

* fixes runtime with revolver archaeo find (#8797)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* Fixing Qualities For Map Disabled Jobs (#8820)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* Fixes flashbang runtime (#8824)

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* 1 (#8825)

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* added global lists of skills and skillsets

* fixed bug with update_available skills

* end of file

* Moreosobki (#8812)

* 1

* Update positiveish.dm

* 2

* 3

* Update quirkieish.dm

* Update quirkieish.dm

* Update code/datums/qualities/negativeish.dm

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* Update negativeish.dm

* Update code/game/objects/items/weapons/implants/implant.dm

* Update positiveish.dm

Co-authored-by: KIBORG04 <bossmira4@gmail.com>
Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Воксонёрфы (#8819)

* nerfing voxs

* one more funny thing

* revert funny thing

* removed initial

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>
Co-authored-by: Dushess <dushesson@gmail.com>
Co-authored-by: LudwigVonChesterfield <{ID}+{username}@users.noreply.github.com>
Co-authored-by: KIBORG04 <bossmira4@gmail.com>
Co-authored-by: simb11 <84613249+simb11@users.noreply.github.com>
Co-authored-by: Alexander V <volas@ya.ru>
Co-authored-by: AndroBetel <44546836+AndroBetel@users.noreply.github.com>
Co-authored-by: Darth Sidious <andrgysev02@mail.ru>
Co-authored-by: kalazus <30507262+kalazus@users.noreply.github.com>
Co-authored-by: Sakuya-Izayoi <30875884+Sakuya-Izayoi@users.noreply.github.com>
Co-authored-by: Deahaka <96499407+Deahaka@users.noreply.github.com>

* Update code/game/objects/items/weapons/defibrillator.dm

* Update code/game/objects/items.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/game/objects/items/stacks/stack.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/projectiles/guns/projectile.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/virus2/items_devices.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/security levels/keycard authentication.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* renamed required skills in use tool to required_skills_override

* renamed skill_checks in item to required_skills

* corrected timing coment in injection

* better building code

* Update code/game/objects/items/stacks/stack.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* better healing timings

* Система умений для персонажей (part 2 - content: engineering, surgery, machinery) (#8669)

* fixed subskills, pills feed time and syringe gun usage

* fumbling with medical scanner

* smes skill check, syringe gun fix and scrubber fix

* scrubber fix

* wrong var name

* skill menu v0.5

* added skills to officer and reordered skills datums

* added chaging of skills and basic antag skills

* command skill part 1

* fixed wrong ids

* minor refactoring

* added silicons

* fixed construction

* added engineering checks for hacking and bombs

* pills, bottles and chemistry skills

* medical and construction fixes

* wrong number fix

* added skill datums for roles and fixed mergeSkills proc

* minor fixes

* better spacings and abductors skill datums

* whitespace fixes before PR

* changed description

* rcd usage

* fixed path

* Excess of closing tags

* fixed some bugs

* refactoring of skills part 1

* skills refactor part 2

* refactoring part 3

* fixes

* refactoring in progress

* final fixes

* spacing fix

* reduced interaction delay

* tweak

* refactoring of wires and cob_highlight

* fixed typo

* bonus spelling

* minor fixes

* fumbling after checks

* chemistry uncertanity

* missing new line

* removed combat mechas move buff, renamed param of handle_fumbling

* mecha fumbling

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* do_skilled proc

* exosuit skill checks tweaks

* melee skill is now working

* spacing fix

* spacing

* renamed fumble_around to do_skill_checks

* command skill now adds more buttons to the access console

* changed planting of mining explosive, more engineering skill checks

* more engineering and construction checks

* machinery construction skill

* Update code/modules/projectiles/guns/projectile.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* refactored skill types in jobs

* removed skill checks from flash

* removed visible message for others

* removed unused variable

* refactored using of skill bonus

* pill ingestion tweak

* changelings now gaining skills from absorbed people

* full skills TODO - left only framework (#1)

* skills part 1

* part 2

* moved skills to the mind

* police and firearms check

* tactical reloads

* fixed empty space in storage after tactical reload

* refactored skills to use defines instead of string

* added console interaction with skill checks

* walls,glass,particle ac and shieldgen skills usage

* sleeper, RND stuff skill checks

* more machinery skill checks

* fixed life assist

* virology skill checks

* virology skill checks #2

* refactored skills checks to use defines

* fixed construction naming

* reworked to use Topic instead ui_interact to remove bug

* surgery buff

* reverted midi

* alternative skills sets for alt jobs

* fixed subskills, pills feed time and syringe gun usage

* fumbling with medical scanner

* smes skill check, syringe gun fix and scrubber fix

* scrubber fix

* wrong var name

* skill menu v0.5

* added skills to officer and reordered skills datums

* added chaging of skills and basic antag skills

* command skill part 1

* fixed wrong ids

* minor refactoring

* added silicons

* fixed construction

* added engineering checks for hacking and bombs

* pills, bottles and chemistry skills

* medical and construction fixes

* wrong number fix

* added skill datums for roles and fixed mergeSkills proc

* minor fixes

* better spacings and abductors skill datums

* whitespace fixes before PR

* changed description

* rcd usage

* fixed path

* Excess of closing tags

* fixed some bugs

* refactoring of skills part 1

* skills refactor part 2

* refactoring part 3

* fixes

* refactoring in progress

* final fixes

* spacing fix

* reduced interaction delay

* tweak

* refactoring of wires and cob_highlight

* fixed typo

* bonus spelling

* minor fixes

* fumbling after checks

* chemistry uncertanity

* missing new line

* removed combat mechas move buff, renamed param of handle_fumbling

* mecha fumbling

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* do_skilled proc

* exosuit skill checks tweaks

* melee skill is now working

* spacing fix

* spacing

* renamed fumble_around to do_skill_checks

* command skill now adds more buttons to the access console

* changed planting of mining explosive, more engineering skill checks

* more engineering and construction checks

* machinery construction skill

* Update code/modules/projectiles/guns/projectile.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* refactored skill types in jobs

* removed skill checks from flash

* removed visible message for others

* removed unused variable

* refactored using of skill bonus

* pill ingestion tweak

* changelings now gaining skills from absorbed people

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>
Co-authored-by: Dushess <dushesson@gmail.com>

* framework part 1

* merge 2

* i forgor

* content (#2)

* skills part 1

* part 2

* moved skills to the mind

* police and firearms check

* tactical reloads

* fixed empty space in storage after tactical reload

* refactored skills to use defines instead of string

* added console interaction with skill checks

* walls,glass,particle ac and shieldgen skills usage

* sleeper, RND stuff skill checks

* more machinery skill checks

* fixed life assist

* virology skill checks

* virology skill checks #2

* refactored skills checks to use defines

* fixed construction naming

* reworked to use Topic instead ui_interact to remove bug

* surgery buff

* reverted midi

* alternative skills sets for alt jobs

* fixed subskills, pills feed time and syringe gun usage

* fumbling with medical scanner

* smes skill check, syringe gun fix and scrubber fix

* scrubber fix

* wrong var name

* skill menu v0.5

* added skills to officer and reordered skills datums

* added chaging of skills and basic antag skills

* command skill part 1

* fixed wrong ids

* minor refactoring

* added silicons

* fixed construction

* added engineering checks for hacking and bombs

* pills, bottles and chemistry skills

* medical and construction fixes

* wrong number fix

* added skill datums for roles and fixed mergeSkills proc

* minor fixes

* better spacings and abductors skill datums

* whitespace fixes before PR

* changed description

* rcd usage

* fixed path

* Excess of closing tags

* fixed some bugs

* refactoring of skills part 1

* skills refactor part 2

* refactoring part 3

* fixes

* refactoring in progress

* final fixes

* spacing fix

* reduced interaction delay

* tweak

* refactoring of wires and cob_highlight

* fixed typo

* bonus spelling

* minor fixes

* fumbling after checks

* chemistry uncertanity

* missing new line

* removed combat mechas move buff, renamed param of handle_fumbling

* mecha fumbling

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* do_skilled proc

* exosuit skill checks tweaks

* melee skill is now working

* spacing fix

* spacing

* renamed fumble_around to do_skill_checks

* command skill now adds more buttons to the access console

* changed planting of mining explosive, more engineering skill checks

* more engineering and construction checks

* machinery construction skill

* Update code/modules/projectiles/guns/projectile.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* refactored skill types in jobs

* removed skill checks from flash

* removed visible message for others

* removed unused variable

* refactored using of skill bonus

* pill ingestion tweak

* changelings now gaining skills from absorbed people

* fixes hazard vest click (#8656)

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>
Co-authored-by: Dushess <dushesson@gmail.com>

* surgery, engineering, machine interactions

* forms removal

* forms removal

* reverted injection

* reverted item attack

* atmospheric checks

* atmospheric checks

* fix of endings

* skillsets refactor

* skillsets refactor

* skillsets refactor

* Merge conflict fix

* fix

* fix

* refactored skillsets (again)

* refactored skillsets (again)

* refactored skillsets (again)

* more checks and refactor

* more checks and refactor

* more checks and refactor

* changed case of procs, available_skillset is now cached

* runtime fix

* spacings

* huge refactor

* split to files

* job fix

* removed ambiguous brackets

* renamed skillsets in role to skillset_type

* renamed getSkillsType to snake case

* remove_skills_modifier fix

* better proc naming

* changed naming to datum

* naming of max and min

* snake case

* lazy add and lazy remove

* merge

* refactor

* proc change

* minor refactorings

* as anything

* refactoring

* merge

* renamed fumbling_time_multiplier to fumbling_time_additional_delay

* use define

* Update code/game/mecha/mech_fabricator.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* wrong merge

* Update code/modules/virus2/isolator.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/virus2/dishincubator.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/virus2/diseasesplicer.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* pill examine refactor

* unused renaming fix and projectile.dm early return

* fierarms fix

* removed unused defines

* newlind at the end of file

* merge

* update active skillset fix

* skillset now initing with default skills modifiers

* fixes

* removed alert

* refactor part 1 WIP

* refactor part 2

* refactor part 4

* lazy list and maximize fix

* timing of c4 fix

* removed police checks and melee checks

* bruh (#4)

* skills part 1

* part 2

* moved skills to the mind

* police and firearms check

* tactical reloads

* fixed empty space in storage after tactical reload

* refactored skills to use defines instead of string

* added console interaction with skill checks

* walls,glass,particle ac and shieldgen skills usage

* sleeper, RND stuff skill checks

* more machinery skill checks

* fixed life assist

* virology skill checks

* virology skill checks #2

* refactored skills checks to use defines

* fixed construction naming

* reworked to use Topic instead ui_interact to remove bug

* surgery buff

* reverted midi

* alternative skills sets for alt jobs

* fixed subskills, pills feed time and syringe gun usage

* fumbling with medical scanner

* smes skill check, syringe gun fix and scrubber fix

* scrubber fix

* wrong var name

* skill menu v0.5

* added skills to officer and reordered skills datums

* added chaging of skills and basic antag skills

* command skill part 1

* fixed wrong ids

* minor refactoring

* added silicons

* fixed construction

* added engineering checks for hacking and bombs

* pills, bottles and chemistry skills

* medical and construction fixes

* wrong number fix

* added skill datums for roles and fixed mergeSkills proc

* minor fixes

* better spacings and abductors skill datums

* whitespace fixes before PR

* changed description

* rcd usage

* fixed path

* Excess of closing tags

* fixed some bugs

* refactoring of skills part 1

* skills refactor part 2

* refactoring part 3

* fixes

* refactoring in progress

* final fixes

* spacing fix

* reduced interaction delay

* tweak

* refactoring of wires and cob_highlight

* fixed typo

* bonus spelling

* minor fixes

* fumbling after checks

* chemistry uncertanity

* missing new line

* removed combat mechas move buff, renamed param of handle_fumbling

* mecha fumbling

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* do_skilled proc

* exosuit skill checks tweaks

* melee skill is now working

* spacing fix

* spacing

* renamed fumble_around to do_skill_checks

* command skill now adds more buttons to the access console

* changed planting of mining explosive, more engineering skill checks

* more engineering and construction checks

* machinery construction skill

* Update code/modules/projectiles/guns/projectile.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* refactored skill types in jobs

* removed skill checks from flash

* removed visible message for others

* removed unused variable

* refactored using of skill bonus

* pill ingestion tweak

* changelings now gaining skills from absorbed people

* content (#2)

* skills part 1

* part 2

* moved skills to the mind

* police and firearms check

* tactical reloads

* fixed empty space in storage after tactical reload

* refactored skills to use defines instead of string

* added console interaction with skill checks

* walls,glass,particle ac and shieldgen skills usage

* sleeper, RND stuff skill checks

* more machinery skill checks

* fixed life assist

* virology skill checks

* virology skill checks #2

* refactored skills checks to use defines

* fixed construction naming

* reworked to use Topic instead ui_interact to remove bug

* surgery buff

* reverted midi

* alternative skills sets for alt jobs

* fixed subskills, pills feed time and syringe gun usage

* fumbling with medical scanner

* smes skill check, syringe gun fix and scrubber fix

* scrubber fix

* wrong var name

* skill menu v0.5

* added skills to officer and reordered skills datums

* added chaging of skills and basic antag skills

* command skill part 1

* fixed wrong ids

* minor refactoring

* added silicons

* fixed construction

* added engineering checks for hacking and bombs

* pills, bottles and chemistry skills

* medical and construction fixes

* wrong number fix

* added skill datums for roles and fixed mergeSkills proc

* minor fixes

* better spacings and abductors skill datums

* whitespace fixes before PR

* changed description

* rcd usage

* fixed path

* Excess of closing tags

* fixed some bugs

* refactoring of skills part 1

* skills refactor part 2

* refactoring part 3

* fixes

* refactoring in progress

* final fixes

* spacing fix

* reduced interaction delay

* tweak

* refactoring of wires and cob_highlight

* fixed typo

* bonus spelling

* minor fixes

* fumbling after checks

* chemistry uncertanity

* missing new line

* removed combat mechas move buff, renamed param of handle_fumbling

* mecha fumbling

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* do_skilled proc

* exosuit skill checks tweaks

* melee skill is now working

* spacing fix

* spacing

* renamed fumble_around to do_skill_checks

* command skill now adds more buttons to the access console

* changed planting of mining explosive, more engineering skill checks

* more engineering and construction checks

* machinery construction skill

* Update code/modules/projectiles/guns/projectile.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* refactored skill types in jobs

* removed skill checks from flash

* removed visible message for others

* removed unused variable

* refactored using of skill bonus

* pill ingestion tweak

* changelings now gaining skills from absorbed people

* fixes hazard vest click (#8656)

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>
Co-authored-by: Dushess <dushesson@gmail.com>

* surgery, engineering, machine interactions

* forms removal

* forms removal

* reverted item attack

* atmospheric checks

* atmospheric checks

* skillsets refactor

* skillsets refactor

* Merge conflict fix

* fix

* fix

* refactored skillsets (again)

* refactored skillsets (again)

* more checks and refactor

* more checks and refactor

* merge

* proc change

* refactoring

* renamed fumbling_time_multiplier to fumbling_time_additional_delay

* use define

* Update code/game/mecha/mech_fabricator.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/virus2/isolator.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/virus2/dishincubator.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/virus2/diseasesplicer.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* pill examine refactor

* unused renaming fix and projectile.dm early return

* fierarms fix

* removed unused defines

* skillset now initing with default skills modifiers

* fixes

* removed alert

* refactor part 1 WIP

* refactor part 2

* refactor part 4

* lazy list and maximize fix

* timing of c4 fix

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>
Co-authored-by: Dushess <dushesson@gmail.com>

* Revert "bruh (#4)" (#5)

This reverts commit 2c928cbd81323ce1b31c966469a5f84b3e3fb533.

* skill is now an object

* Update code/datums/skills.dm

Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* renamed skill_sets to skillsets and added checks for null in role.dm

* renamed  remove_modifier to remove_available_skillset

* fixed wrong melee weapons calc

* fixed clown and mime skills, centers the max skill button

* cultist are now starting without maxed out skills

* reverted max skills new()

* micro fixes

* added global lists of skills and skillsets

* fixed bug

* forgor

* removed initial

* Update code/game/objects/items/weapons/defibrillator.dm

* Update code/game/objects/items.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/game/objects/items/stacks/stack.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/projectiles/guns/projectile.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/virus2/items_devices.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/security levels/keycard authentication.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* renamed required skills in use tool to required_skills_override

* renamed skill_checks in item to required_skills

* corrected timing coment in injection

* better building code

* Update code/game/objects/items/stacks/stack.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* better healing timings

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>
Co-authored-by: Dushess <dushesson@gmail.com>
Co-authored-by: KIBORG04 <bossmira4@gmail.com>

* Revert "Merge branch 'skills' of https://github.com/TauCetiStation/TauCetiClassic"

This reverts commit 9712af157b1bed38a73cbd96f797c91c196ab0de, reversing
changes made to 633cab48b434dc955c19fbec43bf0878c9d9f86c.

* xD

* police is back in town

* fixed list in mecha

* fixed tactical reload

* Revert "Merge branch 'master' of https://github.com/TauCetiStation/TauCetiClassic into skills-final"

This reverts commit f2358187abe8623768e5901016c14f79fab5060c, reversing
changes made to ff5f949d346a4e995250ce4099fd6f804fb3fca2.

* retrigger checks

* merge conflicts is no more

* final

* i forgor

* no no

* fixed reloading for colt

* fixes

* Police (#8906)

* chemistry uncertanity

* missing new line

* removed combat mechas move buff, renamed param of handle_fumbling

* mecha fumbling

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* do_skilled proc

* exosuit skill checks tweaks

* melee skill is now working

* spacing fix

* spacing

* renamed fumble_around to do_skill_checks

* command skill now adds more buttons to the access console

* changed planting of mining explosive, more engineering skill checks

* more engineering and construction checks

* machinery construction skill

* Update code/modules/projectiles/guns/projectile.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* refactored skill types in jobs

* removed skill checks from flash

* removed visible message for others

* removed unused variable

* refactored using of skill bonus

* pill ingestion tweak

* changelings now gaining skills from absorbed people

* full skills TODO - left only framework (#1)

* skills part 1

* part 2

* moved skills to the mind

* police and firearms check

* tactical reloads

* fixed empty space in storage after tactical reload

* refactored skills to use defines instead of string

* added console interaction with skill checks

* walls,glass,particle ac and shieldgen skills usage

* sleeper, RND stuff skill checks

* more machinery skill checks

* fixed life assist

* virology skill checks

* virology skill checks #2

* refactored skills checks to use defines

* fixed construction naming

* reworked to use Topic instead ui_interact to remove bug

* surgery buff

* reverted midi

* alternative skills sets for alt jobs

* fixed subskills, pills feed time and syringe gun usage

* fumbling with medical scanner

* smes skill check, syringe gun fix and scrubber fix

* scrubber fix

* wrong var name

* skill menu v0.5

* added skills to officer and reordered skills datums

* added chaging of skills and basic antag skills

* command skill part 1

* fixed wrong ids

* minor refactoring

* added silicons

* fixed construction

* added engineering checks for hacking and bombs

* pills, bottles and chemistry skills

* medical and construction fixes

* wrong number fix

* added skill datums for roles and fixed mergeSkills proc

* minor fixes

* better spacings and abductors skill datums

* whitespace fixes before PR

* changed description

* rcd usage

* fixed path

* Excess of closing tags

* fixed some bugs

* refactoring of skills part 1

* skills refactor part 2

* refactoring part 3

* fixes

* refactoring in progress

* final fixes

* spacing fix

* reduced interaction delay

* tweak

* refactoring of wires and cob_highlight

* fixed typo

* bonus spelling

* minor fixes

* fumbling after checks

* chemistry uncertanity

* missing new line

* removed combat mechas move buff, renamed param of handle_fumbling

* mecha fumbling

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* Update code/modules/mob/living/carbon/human/human.dm

Co-authored-by: LudwigVonChesterfield <17705613+LudwigVonChesterfield@users.noreply.github.com>

* do_skilled proc

* exosuit skill checks tweaks

* melee skill is now working

* spacing fix

* spacing

* renamed fumble_around to do_skill_checks

* command skill now adds more buttons to the access console

* changed planting of mining explosive, more engineering skill checks

* more engineering and construction checks

* machinery constr…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Новая фича Fix Test Merge Candidate ПР с этим лэйблом будет или уже находится с тест мерже

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Proposal] Тестер генокрадов

7 participants