fix script/score.tlu: compare realpath instead of basename #26
Conversation
|
LGTM Only one thing: could you please update following comment as well? (maybe something like -- 3. then lexicographically by filename |
|
Amended. |
|
Line 237 in b3b2872 will be never reached unless full paths conflict. So the line should be moved up or removed. |
I think this will very unlikely to happen, but still not zero persent, so I'll just leave this; not harmful at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
For example
texdoc -Il thesisreturns lists in arbitrary orders:There are many packages whose names contain "thesis", and some files of them have the same score (e.g., 1.5 to
hagenberg-thesis/examples/hgblabreportde/main.pdf,hagenberg-thesis/examples/hgblabreporten/main.pdfand other 8).The problem is that
sort_doclistcompares basenames when scores are same, leading to arbitrary order of files whose basenames are same.The text was updated successfully, but these errors were encountered: