New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Veedrac's optimization for both fasta and -redux #20

Merged
merged 1 commit into from Sep 29, 2015

Conversation

Projects
None yet
2 participants
@llogiq
Contributor

llogiq commented Sep 24, 2015

This uses Veedrac's optimization for both fasta and fasta-redux benchmarks. Both versions are equal to those submitted to rust, modulo the num_cpus dependency.

The speedups are huge.

@llogiq

This comment has been minimized.

Show comment
Hide comment
@llogiq

llogiq Sep 24, 2015

Contributor

I'll let you know when the Rust PR was merged.

Contributor

llogiq commented Sep 24, 2015

I'll let you know when the Rust PR was merged.

@TeXitoi

This comment has been minimized.

Show comment
Hide comment
@TeXitoi

TeXitoi Sep 24, 2015

Owner

Thanks.

Owner

TeXitoi commented Sep 24, 2015

Thanks.

@llogiq llogiq referenced this pull request Sep 25, 2015

Closed

New fasta #15

@llogiq

This comment has been minimized.

Show comment
Hide comment
@llogiq

llogiq Sep 29, 2015

Contributor

The Rust PR was approved by brson. It's only a matter of time before it's in; with the next rollup.

Contributor

llogiq commented Sep 29, 2015

The Rust PR was approved by brson. It's only a matter of time before it's in; with the next rollup.

@TeXitoi

This comment has been minimized.

Show comment
Hide comment
@TeXitoi

TeXitoi Sep 29, 2015

Owner

Fasta need my name in last position if I submit it. Or is it the current version ?

Ok to merge.

Owner

TeXitoi commented Sep 29, 2015

Fasta need my name in last position if I submit it. Or is it the current version ?

Ok to merge.

@llogiq

This comment has been minimized.

Show comment
Hide comment
@llogiq

llogiq Sep 29, 2015

Contributor

Veedrac already submitted fasta. The fasta_redux should have your name in last position.

Contributor

llogiq commented Sep 29, 2015

Veedrac already submitted fasta. The fasta_redux should have your name in last position.

TeXitoi added a commit that referenced this pull request Sep 29, 2015

Merge pull request #20 from llogiq/veedrac-fasta
Veedrac's optimization for both fasta and -redux

@TeXitoi TeXitoi merged commit 082eae6 into TeXitoi:master Sep 29, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@llogiq llogiq deleted the llogiq:veedrac-fasta branch Sep 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment