Softdeleting threads permadeletes posts

[TiagoLisboa]

Hello,
When I execute a softedelete on a thread it's posts are removed from the database.

My laravel version is: "laravel/framework": "5.5.*",
My forum pack is: "riari/laravel-forum": "~4.0", "riari/laravel-forum-frontend": "~1.0"

[TiagoLisboa]

So, i digged around for awhile and finded out that the problem is basically here:

Because of some milleseconds the comparision goes false and the posts are hard deleted.

[Riari]

Ah, I wonder if this is unique to a newer version of Carbon - when I first wrote that condition, milliseconds weren't counted.

It's not a very reliable way of checking for hard deletion, but I couldn't easily find any better alternatives at the time. As a fix in the meantime, I could change the timestamps to format them minus the milliseconds - that should work except for the rare edge case where the time ticks over to the next second mid-deletion.

[TiagoLisboa]

Hey, just saw that when a hard delete is made the thread in the deleted function is null, causing an Error.
Instead of checking the date, you should check if it is null.