New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen in the app to show and download APKs from github releases. #1520

Closed
krtkush opened this Issue Jul 2, 2018 · 32 comments

Comments

Projects
None yet
6 participants
@krtkush
Contributor

krtkush commented Jul 2, 2018

Feature request/ idea

Currently, F-Droid takes too long to update its repo with the latest version of the app. Also, there must be users who don't have/ want F-Droid installed but still want to track the latest version of NewPipe.

For these users and to counter the slowness of F-Droid APK updates, I suggest that we have an inbuilt system in the app which shows and notifies the availability of the latest APKs. We can use the Releases API to get the latest info from github itself.

I'm willing to take up this task if the general idea is approved.

@theScrabi

This comment has been minimized.

Show comment
Hide comment
@theScrabi

theScrabi Jul 2, 2018

Member

Yum I'm at your side here :)

Member

theScrabi commented Jul 2, 2018

Yum I'm at your side here :)

@krtkush

This comment has been minimized.

Show comment
Hide comment
@krtkush

krtkush Jul 3, 2018

Contributor

Great! I'll start working on it, then.

Contributor

krtkush commented Jul 3, 2018

Great! I'll start working on it, then.

@TobiGr

This comment has been minimized.

Show comment
Hide comment
@TobiGr

TobiGr Jul 3, 2018

Member

I am not sure which information you want to get, but you can use the api we created for the website to get the current version: TeamNewPipe/web-api
You can fetch the data from https://newpipe.schabi.org/api/data.json

Member

TobiGr commented Jul 3, 2018

I am not sure which information you want to get, but you can use the api we created for the website to get the current version: TeamNewPipe/web-api
You can fetch the data from https://newpipe.schabi.org/api/data.json

@krtkush

This comment has been minimized.

Show comment
Hide comment
@krtkush

krtkush Jul 3, 2018

Contributor

@TobiGr The API you mentioned does not provide link to download the release APK.

My idea is to provide a functionality to notify the user about a new APK availability and then let the user download it from within the NewPipe app. I, personally, would like this way of updating the app because I find that F-Froid is not quick enough to make the latest APK available for download.

https://api.github.com/repos/TeamNewPipe/NewPipe/releases gives the assets_url for every release; which further provides browser_download_url. This url can be used to download the APK of that release.

Contributor

krtkush commented Jul 3, 2018

@TobiGr The API you mentioned does not provide link to download the release APK.

My idea is to provide a functionality to notify the user about a new APK availability and then let the user download it from within the NewPipe app. I, personally, would like this way of updating the app because I find that F-Froid is not quick enough to make the latest APK available for download.

https://api.github.com/repos/TeamNewPipe/NewPipe/releases gives the assets_url for every release; which further provides browser_download_url. This url can be used to download the APK of that release.

@TobiGr

This comment has been minimized.

Show comment
Hide comment
@TobiGr

TobiGr Jul 3, 2018

Member

It's no problem to include it into the web-api. We'd only need to make a difference between F-Droid and GitHub releases. @TheAssassin What do you think about this?

Member

TobiGr commented Jul 3, 2018

It's no problem to include it into the web-api. We'd only need to make a difference between F-Droid and GitHub releases. @TheAssassin What do you think about this?

@krtkush

This comment has been minimized.

Show comment
Hide comment
@krtkush

krtkush Jul 3, 2018

Contributor

It's no problem to include it into the web-api.

That sounds good.

Contributor

krtkush commented Jul 3, 2018

It's no problem to include it into the web-api.

That sounds good.

@TheAssassin

This comment has been minimized.

Show comment
Hide comment
@TheAssassin

TheAssassin Jul 3, 2018

Member

@TobiGr this should be doable, although I'm a bit worried about the GitHub rate limit. I think we should use some cheap web scraping to get the information we need.

Member

TheAssassin commented Jul 3, 2018

@TobiGr this should be doable, although I'm a bit worried about the GitHub rate limit. I think we should use some cheap web scraping to get the information we need.

@TobiGr

This comment has been minimized.

Show comment
Hide comment
@TobiGr

TobiGr Jul 3, 2018

Member

The rate limit is at 60 requests per hour for non authorized applications. As long as we keep the cache this won't be a problem.

Member

TobiGr commented Jul 3, 2018

The rate limit is at 60 requests per hour for non authorized applications. As long as we keep the cache this won't be a problem.

@TheAssassin

This comment has been minimized.

Show comment
Hide comment
@TheAssassin

TheAssassin Jul 3, 2018

Member

This is not the only application I run that uses the GitHub API, @TobiGr...

Member

TheAssassin commented Jul 3, 2018

This is not the only application I run that uses the GitHub API, @TobiGr...

TobiGr added a commit to TobiGr/web-api that referenced this issue Jul 4, 2018

@theScrabi

This comment has been minimized.

Show comment
Hide comment
@theScrabi

theScrabi Jul 4, 2018

Member

This is not the only application I run that uses the GitHub API, @TobiGr...

... NewPipe is a scraper ... so maybe, just maybe we could scrape that value as well 🙈

Member

theScrabi commented Jul 4, 2018

This is not the only application I run that uses the GitHub API, @TobiGr...

... NewPipe is a scraper ... so maybe, just maybe we could scrape that value as well 🙈

@TobiGr

This comment has been minimized.

Show comment
Hide comment
@TobiGr

TobiGr Jul 4, 2018

Member

@theScrabi. Jup. I just opened a PR which does the scrapping.

Member

TobiGr commented Jul 4, 2018

@theScrabi. Jup. I just opened a PR which does the scrapping.

@TheAssassin

This comment has been minimized.

Show comment
Hide comment
@TheAssassin

TheAssassin Jul 4, 2018

Member

It's "scraping", not "scrapping"...

Member

TheAssassin commented Jul 4, 2018

It's "scraping", not "scrapping"...

@TobiGr

This comment has been minimized.

Show comment
Hide comment
@TobiGr

TobiGr Jul 4, 2018

Member

@krtkush I've updated the API and the changes should be online soon. Tell me when you need additional information which could be provided by the API.

Member

TobiGr commented Jul 4, 2018

@krtkush I've updated the API and the changes should be online soon. Tell me when you need additional information which could be provided by the API.

@TheAssassin

This comment has been minimized.

Show comment
Hide comment
@TheAssassin

TheAssassin Jul 4, 2018

Member

Deployment just finished in this

Member

TheAssassin commented Jul 4, 2018

Deployment just finished in this

@TheAssassin

This comment has been minimized.

Show comment
Hide comment
@TheAssassin

TheAssassin Jul 4, 2018

Member

@krtkush closing for now, feel free to reopen if you need more assistance.

Member

TheAssassin commented Jul 4, 2018

@krtkush closing for now, feel free to reopen if you need more assistance.

@pranavg189

This comment has been minimized.

Show comment
Hide comment
@pranavg189

pranavg189 Jul 18, 2018

@krtkush Are you working on this ?

pranavg189 commented Jul 18, 2018

@krtkush Are you working on this ?

@krtkush

This comment has been minimized.

Show comment
Hide comment
@krtkush

krtkush Jul 18, 2018

Contributor

Yes. Should have a working prototype by end of next weekend.

Contributor

krtkush commented Jul 18, 2018

Yes. Should have a working prototype by end of next weekend.

@pranavg189

This comment has been minimized.

Show comment
Hide comment
@pranavg189

pranavg189 Jul 18, 2018

Cool. Great to know that.

pranavg189 commented Jul 18, 2018

Cool. Great to know that.

@krtkush

This comment has been minimized.

Show comment
Hide comment
@krtkush

krtkush Aug 11, 2018

Contributor

@TheAssassin In the data api will it possible to get the version_code under the github too? Like we already get under F-droid?

Comparing version code makes more sense than comparing version names.

Contributor

krtkush commented Aug 11, 2018

@TheAssassin In the data api will it possible to get the version_code under the github too? Like we already get under F-droid?

Comparing version code makes more sense than comparing version names.

@krtkush

This comment has been minimized.

Show comment
Hide comment
@krtkush

krtkush Aug 11, 2018

Contributor

@TheAssassin The API seems to be down.

Getting <html><title>500: OK</title><body>500: OK</body></html> as output.

Contributor

krtkush commented Aug 11, 2018

@TheAssassin The API seems to be down.

Getting <html><title>500: OK</title><body>500: OK</body></html> as output.

@TheAssassin

This comment has been minimized.

Show comment
Hide comment
@TheAssassin
Member

TheAssassin commented Aug 11, 2018

@krtkush

This comment has been minimized.

Show comment
Hide comment
@krtkush

krtkush Aug 11, 2018

Contributor

Yep! It's up now.

Contributor

krtkush commented Aug 11, 2018

Yep! It's up now.

@TobiGr

This comment has been minimized.

Show comment
Hide comment
@TobiGr

TobiGr Aug 11, 2018

Member

In the data api will it possible to get the version_code under the github too? Like we already get under F-droid?

Yep. That's possible. I can take a look on this next Friday (just in case you don't want to do it, @TheAssassin)

Member

TobiGr commented Aug 11, 2018

In the data api will it possible to get the version_code under the github too? Like we already get under F-droid?

Yep. That's possible. I can take a look on this next Friday (just in case you don't want to do it, @TheAssassin)

@TobiGr

This comment has been minimized.

Show comment
Hide comment
@TobiGr

TobiGr Aug 14, 2018

Member

@krtkush I just merged my changes to display the version code. We just need to wait until the new version will be deployed.

Member

TobiGr commented Aug 14, 2018

@krtkush I just merged my changes to display the version code. We just need to wait until the new version will be deployed.

@krtkush

This comment has been minimized.

Show comment
Hide comment
@krtkush

krtkush Aug 14, 2018

Contributor

@TobiGr Thank you! How soon will that be?

Contributor

krtkush commented Aug 14, 2018

@TobiGr Thank you! How soon will that be?

@dege1000

This comment has been minimized.

Show comment
Hide comment
@dege1000

dege1000 Aug 14, 2018

F-droid works with repositories much like linux, can't you make a one that you can update with more frequency

dege1000 commented Aug 14, 2018

F-droid works with repositories much like linux, can't you make a one that you can update with more frequency

@krtkush

This comment has been minimized.

Show comment
Hide comment
@krtkush

krtkush Aug 15, 2018

Contributor

@TobiGr All the values are -1 under the github object.

Contributor

krtkush commented Aug 15, 2018

@TobiGr All the values are -1 under the github object.

@TobiGr

This comment has been minimized.

Show comment
Hide comment
@TobiGr

TobiGr Aug 15, 2018

Member

That's strange. It worked for me locally.

Member

TobiGr commented Aug 15, 2018

That's strange. It worked for me locally.

@TobiGr

This comment has been minimized.

Show comment
Hide comment
@TobiGr

TobiGr Aug 15, 2018

Member

GitHub just renamed some CSS classes 🙄

Member

TobiGr commented Aug 15, 2018

GitHub just renamed some CSS classes 🙄

@TheAssassin

This comment has been minimized.

Show comment
Hide comment
@TheAssassin

TheAssassin Aug 15, 2018

Member

@TobiGr patch has been deployed as well.

Member

TheAssassin commented Aug 15, 2018

@TobiGr patch has been deployed as well.

@TobiGr

This comment has been minimized.

Show comment
Hide comment
@TobiGr
Member

TobiGr commented Aug 15, 2018

@TheAssassin Thanks

@krtkush

This comment has been minimized.

Show comment
Hide comment
@krtkush

krtkush Aug 16, 2018

Contributor

Thanks, guys.

Contributor

krtkush commented Aug 16, 2018

Thanks, guys.

This was referenced Aug 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment