New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #640 - Screen timeout in case of popup mode. #1463

Merged
merged 4 commits into from Jun 26, 2018

Conversation

Projects
None yet
2 participants
@krtkush
Contributor

krtkush commented Jun 8, 2018

Currently, the screen times out and switches off when a video is playing in pop-up mode.
With this fix the screen will not time out in that mode. On pausing the video, the time out will work again.

@krtkush

This comment has been minimized.

Contributor

krtkush commented Jun 8, 2018

I'll need some guidance as to why the checks are failing.

Problem seems to be -

Could not resolve all files for configuration ':app:debugCompileClasspath'.
Could not find common.jar (android.arch.core:common:1.1.0).
@theScrabi

This comment has been minimized.

Member

theScrabi commented Jun 14, 2018

Yea its Travis, ... it can't get some mvn repos... we have the same issue over at ownCloud atm.

Just need to restart the test.

@@ -0,0 +1,8 @@
/*___Generated_by_IDEA___*/

This comment has been minimized.

@theScrabi

theScrabi Jun 25, 2018

Member

Remove this file

@@ -0,0 +1,7 @@
/*___Generated_by_IDEA___*/

This comment has been minimized.

@theScrabi

theScrabi Jun 25, 2018

Member

Remove this file

@@ -0,0 +1,7 @@
/*___Generated_by_IDEA___*/

This comment has been minimized.

@theScrabi

theScrabi Jun 25, 2018

Member

Remove this file

@@ -0,0 +1,8 @@
/*___Generated_by_IDEA___*/

This comment has been minimized.

@theScrabi

theScrabi Jun 25, 2018

Member

Remove this file

@@ -0,0 +1,7 @@
/*___Generated_by_IDEA___*/

This comment has been minimized.

@theScrabi

theScrabi Jun 25, 2018

Member

Remove this file

@@ -0,0 +1,7 @@
/*___Generated_by_IDEA___*/

This comment has been minimized.

@theScrabi

theScrabi Jun 25, 2018

Member

Remove this file

@krtkush

This comment has been minimized.

Contributor

krtkush commented Jun 25, 2018

@theScrabi Made changes as requested.

@theScrabi theScrabi merged commit 8e96b67 into TeamNewPipe:dev Jun 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@theScrabi

This comment has been minimized.

Member

theScrabi commented Jun 26, 2018

muchas gracias :)

@krtkush

This comment has been minimized.

Contributor

krtkush commented Jun 29, 2018

@theScrabi Since the branch has been merged, can we consider bug #640 resolved?

@theScrabi

This comment has been minimized.

Member

theScrabi commented Jun 29, 2018

done

@krtkush

This comment has been minimized.

Contributor

krtkush commented Jun 29, 2018

Thank you :)

@krtkush krtkush deleted the krtkush:640-screen-off branch Jul 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment