Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #640 - Screen timeout in case of popup mode. #1463

Merged
merged 4 commits into from Jun 26, 2018
Merged

Fixed #640 - Screen timeout in case of popup mode. #1463

merged 4 commits into from Jun 26, 2018

Conversation

krtkush
Copy link
Contributor

@krtkush krtkush commented Jun 8, 2018

Currently, the screen times out and switches off when a video is playing in pop-up mode.
With this fix the screen will not time out in that mode. On pausing the video, the time out will work again.

@krtkush
Copy link
Contributor Author

krtkush commented Jun 8, 2018

I'll need some guidance as to why the checks are failing.

Problem seems to be -

Could not resolve all files for configuration ':app:debugCompileClasspath'.
Could not find common.jar (android.arch.core:common:1.1.0).

@theScrabi
Copy link
Member

theScrabi commented Jun 14, 2018

Yea its Travis, ... it can't get some mvn repos... we have the same issue over at ownCloud atm.

Just need to restart the test.

@@ -0,0 +1,8 @@
/*___Generated_by_IDEA___*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file

@@ -0,0 +1,7 @@
/*___Generated_by_IDEA___*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file

@@ -0,0 +1,7 @@
/*___Generated_by_IDEA___*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file

@@ -0,0 +1,8 @@
/*___Generated_by_IDEA___*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file

@@ -0,0 +1,7 @@
/*___Generated_by_IDEA___*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file

@@ -0,0 +1,7 @@
/*___Generated_by_IDEA___*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file

@krtkush
Copy link
Contributor Author

krtkush commented Jun 25, 2018

@theScrabi Made changes as requested.

@theScrabi theScrabi merged commit 8e96b67 into TeamNewPipe:dev Jun 26, 2018
@theScrabi
Copy link
Member

theScrabi commented Jun 26, 2018

muchas gracias :)

@krtkush
Copy link
Contributor Author

krtkush commented Jun 29, 2018

@theScrabi Since the branch has been merged, can we consider bug #640 resolved?

@theScrabi
Copy link
Member

done

@krtkush
Copy link
Contributor Author

krtkush commented Jun 29, 2018

Thank you :)

@krtkush krtkush deleted the 640-screen-off branch July 27, 2018 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants