Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for android 4.1 - 4.3 #1884

Merged
merged 3 commits into from Nov 25, 2018

Conversation

Projects
None yet
8 participants
@theScrabi
Copy link
Member

commented Nov 13, 2018

This PR will:

  • Deprecate Android 4.1, 4.2, 4.3 since these are pourly supported and not tested anymore
  • Remove deprecated "Old Player"
  • Move "autoplay next" preference element into the player "Behaviour" section.
@Brimont

This comment has been minimized.

Copy link

commented Nov 14, 2018

I have phone with android 4.2.1 i can use newpipe on future? This is my only phone!

@theScrabi

This comment has been minimized.

Copy link
Member Author

commented Nov 15, 2018

@Brimont I highly recommend to get a new phone at this point, or install a custom ROM. 4.2 is heavily outdated, and going on the net with it is risky.

@SC1040-TS2

This comment has been minimized.

Copy link

commented Nov 16, 2018

I was away for a number of days, so seeing this PR is a bit of news to me. It would appear that after some thought, the original intent of my issue was valued above more conservative means of deprecation.

I presume that with all things considered, the move away from older forms of Dalvik was especially given value, as well as streamlining development. I suspect that NewPipe will eventually drop support for the runtime environment entirely in two or so version releases, depending on what the actual development timeline looks like.

Other than that, I send my regards for the time being.

@ghost

This comment has been minimized.

Copy link

commented Nov 24, 2018

@Brimont Time to buy a new phone

@theScrabi theScrabi merged commit 22e3cdd into dev Nov 25, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - app/build.gradle (theScrabi) No new issues
Details
security/snyk - build.gradle (theScrabi) No manifest changes detected

@theScrabi theScrabi deleted the remove_4.x branch Jan 27, 2019

@bidaian

This comment has been minimized.

Copy link

commented Feb 12, 2019

@theScrabi, I own a tablet and a phone with 4.2 and I love NewPipe. Getting a new ROM or a new phone is not really an option right now. Would forking NewPipe work for a while at least? I could revert the commits for this issue and follow you.

@gkeegan

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2019

Forking and reverting commits would not work, as some recent commits were made to fix the way YouTube gave videos. If you reverted those commits, you would not be able to play or download videos.

There is some discussion about making a fork that would keep compatibility with older versions of Android, but as far as I know, as of this moment, there is no working build.

@ghost

This comment has been minimized.

Copy link

commented Feb 13, 2019

@bidaian If you can't buy a new phone and tablet, you should consider flashing these devices with newer versions of Android if you can. If you can't, there's no other solution for you than to buy new devices. 4.3 and below is being deprecated by a lot of software other than Newpipe and you should really not be using anything older.

@gkeegan

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2019

I would not necessarily say no other option, as there are still alternatives such as using SkyTube (which as far as I know still has support for 4.2) for your YouTube needs.

TobiGr pushed a commit that referenced this pull request Feb 17, 2019

TobiGr
@orinjus

This comment has been minimized.

Copy link

commented Feb 18, 2019

I would just like to add that I don't use my old devices for anything sensitive, and I can't buy a new device just for youtube. Previous NewPipe (0.14.1) worked (unstable but adequate) on android 4.0.4 though not "supported".

I appreciate this project deeply, partially because I could use it on older devices. I don't know how difficult/complex it is to write for older APIs, and I totally understand this is a volunteer project, so... yeah, you do what you need to do. For my part though, this will limit my options a lot.

@d-g

This comment has been minimized.

Copy link

commented Feb 18, 2019

@gkeegan

This comment has been minimized.

Copy link
Contributor

commented Feb 18, 2019

I don't understand what you mean. Please elaborate. SkyTube (not the extra version) is FOSS.

Edit: For some reason your comment only rendered a small portion of it. I see your point now.

@d-g

This comment has been minimized.

Copy link

commented Feb 18, 2019

@gkeegan

This comment has been minimized.

Copy link
Contributor

commented Feb 18, 2019

I believe its something with my app. Looks fine in a browser.

@starks

This comment has been minimized.

Copy link

commented Apr 3, 2019

There are older devices out there (sticks, headunits, etc) that run pre-4.4 Android and cannot be easily upgraded. They need a solution.

@d-g

This comment has been minimized.

Copy link

commented Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.