New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new Localization and Downloader implementations from extractor #2713
Use new Localization and Downloader implementations from extractor #2713
Conversation
bc4750c
to
540d63f
Compare
@@ -109,19 +115,34 @@ public void onCreatePreferences(Bundle savedInstanceState, String rootKey) { | |||
return true; | |||
}); | |||
|
|||
Preference setPreferredLanguage = findPreference(getString(R.string.content_language_key)); | |||
/*Preference setPreferredLanguage = findPreference(getString(R.string.content_language_key)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a comment that this is not needed due to the changes below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
540d63f
to
4c02214
Compare
@TobiGr are you sure? This is how the file looks like as of the last commit. It seems that currently only the language names are done that way. |
My bad, I mixed content language and country during my review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mauriciocolli Can you rebase and update the extractor version? It's good to go.
Before, the direct value was given to the user, now it uses the parsed date so we can match the device's language. To get the relative time from the parsed dates, we use the PrettyTime library. Also introduces a debug option to check the service's original value.
4c02214
to
b125ff7
Compare
@TobiGr Done. |
Depends on TeamNewPipe/NewPipeExtractor#158.