Add option to delete files when clearing finished downloads #2717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiGr
added
downloader
TobiGr
reviewed
Dec 10, 2019
app/src/main/java/us/shandian/giga/ui/adapter/MissionAdapter.java
Outdated
Show resolved
Hide resolved
TobiGr
reviewed
Jan 8, 2020
app/src/main/java/us/shandian/giga/ui/adapter/MissionAdapter.java
Outdated
Show resolved
Hide resolved
app/src/main/res/values/strings.xml
Outdated
| @@ -587,5 +587,6 @@ | |||
| <string name="downloads_storage_use_saf_title">Use SAF</string> | |||
| <string name="downloads_storage_use_saf_summary">The Storage Access Framework allows downloads to an external SD card.\nNote: some devices are not compatible</string> | |||
| <string name="choose_instance_prompt">Choose an instance</string> | |||
|
|
|||
| <string name="delete_downloaded_files">Delete downloaded files</string> | |||
There was a problem hiding this comment.
Please move these strings to up the other download related strings (line 573).
app/src/main/java/us/shandian/giga/ui/adapter/MissionAdapter.java
Outdated
Show resolved
Hide resolved
TobiGr
previously approved these changes
Jan 13, 2020
TobiGr
approved these changes
Jan 13, 2020
|
Thanks again! |
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #2267 by adding a checkbox in alert dialog that allows user to decide whether to delete downloaded files when clearing finished downloads.