Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YouTube] Adjust throttling function extraction to changes #1191

Merged
merged 8 commits into from
Jul 11, 2024

Conversation

XiangRongLin
Copy link
Collaborator

@XiangRongLin XiangRongLin commented Jul 10, 2024

Using the info from #1190

it should resolve that issue and TeamNewPipe/NewPipe#11255

The YoutubeThrottlingParameterDeobfuscationTest are working again with this. The failing ones are bandcamp

newpipe-debug.zip

@XiangRongLin XiangRongLin self-assigned this Jul 10, 2024
@XiangRongLin
Copy link
Collaborator Author

And boy did I not look at this in forever or even develop anything on my own PC. Getting everything running again was a challenge 😅

@XiangRongLin
Copy link
Collaborator Author

Seeing this here about A/B testing I'm wondering if we still need to support the old format.

@FireMasterK
Copy link
Member

Seeing this here about A/B testing I'm wondering if we still need to support the old format.

Was your changes based on yt-dlp/yt-dlp#10390? I think they have tests that work even for previous versions of the player code.

@XiangRongLin
Copy link
Collaborator Author

Seeing this here about A/B testing I'm wondering if we still need to support the old format.

Was your changes based on yt-dlp/yt-dlp#10390? I think they have tests that work even for previous versions of the player code.

No, it was solely based on #1190

@Theta-Dev
Copy link
Contributor

I don't think should throw out the old extraction function since that may break things for users still getting the old script (or in case they choose to revert these changes).

We already use a list of regexes to get the signature decryption function, we should do that for the nsig too.

@Stypox
Copy link
Member

Stypox commented Jul 11, 2024

I can confirm it works. Thank you a lot!

We already use a list of regexes to get the signature decryption function, we should do that for the nsig too.

Yeah, I'll work on this rn.

@Stypox
Copy link
Member

Stypox commented Jul 11, 2024

Done, and tested on this APK which works: app-debug.zip

@XiangRongLin or @Theta-Dev please look at the code, and if it looks good to you we can proceed with merging and releasing a hotfix.

Copy link
Collaborator Author

@XiangRongLin XiangRongLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall

@theScrabi theScrabi merged commit 592f159 into TeamNewPipe:dev Jul 11, 2024
3 of 4 checks passed
Stypox added a commit that referenced this pull request Jul 11, 2024
* [Youtube] Adjust throttling function extraction to changes

---------

Co-authored-by: Stypox <stypox@pm.me>
@XiangRongLin XiangRongLin deleted the throttling_fix branch July 11, 2024 09:46
@AudricV AudricV changed the title [Youtube] Adjust throttling function extraction to changes [YouTube] Adjust throttling function extraction to changes Jul 11, 2024
whistlingwoods added a commit to whistlingwoods/NewPipeExtractor that referenced this pull request Jul 11, 2024
@Dhusha6

This comment was marked as off-topic.

@NewMacPro

This comment was marked as off-topic.

@TeamNewPipe TeamNewPipe locked as off-topic and limited conversation to collaborators Jul 15, 2024
@AudricV AudricV removed their request for review December 9, 2024 18:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants