New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XGUI does not show CAMI Privileges that was registered after XGUI initialize #64

Closed
roboderpy opened this Issue Jul 20, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@roboderpy

roboderpy commented Jul 20, 2016

EDIT: It does not show registered CAMI Privileges that was registered after XGUI is initialized

Steps to reproduce

Register CAMI Privilege after XGUI is initialized

Expected behavior

  1. You are able to restrict access per group
  2. Access appears in XGUI group configuration menu

Actual behavior

Only first

Error(s) in server console, if any

None

Error(s) in player's console, if any

None

Version

] ulx version
ULib v2.61d
ULX v3.71d

Screenshots

2016-07-20_15-03_garry s mod
2016-07-20_15-47_garry s mod
https://github.com/roboderpy/dpp/blob/master/lua/dpp/sh_access.lua#L29

Suggestion about current menu

In the hover hint please display full Privilege name instead of just "A privilege from CAMI"
2016-07-20_15-53_garry s mod

@roboderpy roboderpy changed the title from XGUI does not show registered CAMI Privileges to XGUI does not show CAMI Privileges that was registered after XGUI initialize Jul 20, 2016

@Nayruden

This comment has been minimized.

Show comment
Hide comment
@Nayruden

Nayruden Jul 20, 2016

Member

@SticklyMan, do we need to make some kind of hook to notify XGUI when privileges change?

Member

Nayruden commented Jul 20, 2016

@SticklyMan, do we need to make some kind of hook to notify XGUI when privileges change?

@SticklyMan

This comment has been minimized.

Show comment
Hide comment
@SticklyMan

SticklyMan Jul 21, 2016

Contributor

@Nayruden The issue is likely here, which only happens on ulx.HOOK_ULXDONELOADING:
https://github.com/TeamUlysses/ulx/blob/master/lua/ulx/xgui/server/sv_groups.lua#L301-L309

Does UCLChanged get called when a privilege is changed? Otherwise, yeah, XGUI will need some kind of notification to repopulate and send out the updated accesses.

Contributor

SticklyMan commented Jul 21, 2016

@Nayruden The issue is likely here, which only happens on ulx.HOOK_ULXDONELOADING:
https://github.com/TeamUlysses/ulx/blob/master/lua/ulx/xgui/server/sv_groups.lua#L301-L309

Does UCLChanged get called when a privilege is changed? Otherwise, yeah, XGUI will need some kind of notification to repopulate and send out the updated accesses.

@Nayruden Nayruden self-assigned this Jul 21, 2016

@Nayruden

This comment has been minimized.

Show comment
Hide comment
@Nayruden

Nayruden Jul 21, 2016

Member

Got it; taking on the task of creating a hook for new privileges. @SticklyMan, you can implement it on your side (XGUI) before me; just tell me the hook name you choose.

Member

Nayruden commented Jul 21, 2016

Got it; taking on the task of creating a hook for new privileges. @SticklyMan, you can implement it on your side (XGUI) before me; just tell me the hook name you choose.

@SticklyMan SticklyMan added the bug label Feb 5, 2018

@SticklyMan SticklyMan self-assigned this Feb 5, 2018

@SticklyMan

This comment has been minimized.

Show comment
Hide comment
@SticklyMan

SticklyMan Feb 11, 2018

Contributor

This should be resolved as of 3d393f5, along with ULib commits:
TeamUlysses/ulib@eda6abd
TeamUlysses/ulib@4926b5b

Please test and let me know if it's still not working as intended.

Contributor

SticklyMan commented Feb 11, 2018

This should be resolved as of 3d393f5, along with ULib commits:
TeamUlysses/ulib@eda6abd
TeamUlysses/ulib@4926b5b

Please test and let me know if it's still not working as intended.

@SticklyMan SticklyMan closed this Feb 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment