New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that formatting works #9

Merged
merged 2 commits into from Oct 12, 2017

Conversation

Projects
None yet
2 participants
@Carpetsmoker
Member

Carpetsmoker commented Oct 12, 2017

We're currently losing error information because it doesn't. One example
(of many) is: https://sentry.io/teamwork/desk/issues/350338423/

which is printed as:

return errors.Errorf("cannot find Customer: %v", err)

And err is *httperr.withStatus.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 12, 2017

Codecov Report

Merging #9 into master will increase coverage by 12.59%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #9       +/-   ##
========================================
+ Coverage     7.4%   20%   +12.59%     
========================================
  Files           3     3               
  Lines          81    85        +4     
========================================
+ Hits            6    17       +11     
+ Misses         75    67        -8     
- Partials        0     1        +1
Impacted Files Coverage Δ
httperr.go 15.68% <100%> (+7.17%) ⬆️
public.go 26.92% <100%> (+26.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1c3768...9ed42c0. Read the comment docs.

codecov bot commented Oct 12, 2017

Codecov Report

Merging #9 into master will increase coverage by 12.59%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #9       +/-   ##
========================================
+ Coverage     7.4%   20%   +12.59%     
========================================
  Files           3     3               
  Lines          81    85        +4     
========================================
+ Hits            6    17       +11     
+ Misses         75    67        -8     
- Partials        0     1        +1
Impacted Files Coverage Δ
httperr.go 15.68% <100%> (+7.17%) ⬆️
public.go 26.92% <100%> (+26.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1c3768...9ed42c0. Read the comment docs.

@ready4god2513

I assume there isn't an interface that needs to be met?

@Carpetsmoker

This comment has been minimized.

Show comment
Hide comment
@Carpetsmoker

Carpetsmoker Oct 12, 2017

Member

I assume there isn't an interface that needs to be met?

Not sure what you mean with that, but the Format() function is the fmt.Formatter interface: https://golang.org/pkg/fmt/#Formatter

Member

Carpetsmoker commented Oct 12, 2017

I assume there isn't an interface that needs to be met?

Not sure what you mean with that, but the Format() function is the fmt.Formatter interface: https://golang.org/pkg/fmt/#Formatter

Carpetsmoker added some commits Oct 12, 2017

Ensure that formatting works
We're currently losing error information because it doesn't. One example
(of many) is: https://sentry.io/teamwork/desk/issues/350338423/

which is printed as:

	return errors.Errorf("cannot find Customer: %v", err)

And `err` is `*httperr.withStatus`.
@ready4god2513

This comment has been minimized.

Show comment
Hide comment
@ready4god2513

ready4god2513 Oct 12, 2017

Contributor

Yes, I wasn't sure if there was a larger interface that included all three methods, though.

Contributor

ready4god2513 commented Oct 12, 2017

Yes, I wasn't sure if there was a larger interface that included all three methods, though.

@Carpetsmoker Carpetsmoker merged commit 99297ee into master Oct 12, 2017

4 checks passed

codecov/patch 100% of diff hit (target 7.4%)
Details
codecov/project 20% (+12.59%) compared to d1c3768
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Carpetsmoker Carpetsmoker deleted the format branch Oct 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment