Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct path to executable #4

Merged
merged 1 commit into from Mar 9, 2019

Conversation

Projects
None yet
3 participants
@Carpetsmoker
Copy link
Contributor

Carpetsmoker commented Mar 7, 2019

It worked correctly when using the full path (i.e. "~/go/bin/foo") but
not when using a shell PATH lookup (i.e. "foo"). In that case,
os.Args[0] is "foo" and filepath.Abs("foo") is just the cwd + /foo,
which isn't correct.

Luckily, Go has a handy helper function which works on most (though not
all) platforms.

Also remove unused interface.

Use correct path to executable
It worked correctly when using the full path (i.e. "~/go/bin/foo") but
not when using a shell PATH lookup (i.e. "foo"). In that case,
os.Args[0] is "foo" and filepath.Abs("foo") is just the cwd + /foo,
which isn't correct.

Luckily, Go has a handy helper function which works on most (though not
all) platforms.

Also remove unused interface.
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #4 into master will decrease coverage by 3.16%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage   32.43%   29.26%   -3.17%     
==========================================
  Files           1        1              
  Lines          37       41       +4     
==========================================
  Hits           12       12              
- Misses         22       26       +4     
  Partials        3        3
Impacted Files Coverage Δ
reload.go 29.26% <14.28%> (-3.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9285b66...1f56e24. Read the comment docs.

@ripexz

ripexz approved these changes Mar 7, 2019

@JaTochNietDan JaTochNietDan merged commit ced1f76 into Teamwork:master Mar 9, 2019

1 of 3 checks passed

codecov/patch 14.28% of diff hit (target 32.43%)
Details
codecov/project 29.26% (-3.17%) compared to 9285b66
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.