New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use string for sub-validation keys #20

Merged
merged 1 commit into from Jan 9, 2019

Conversation

Projects
None yet
1 participant
@Carpetsmoker
Copy link
Member

Carpetsmoker commented Jan 9, 2019

int works well, but just for arrays. Not for map[sting]...-type of
relations.

String is more flexible, and works for both.

Use string for sub-validation keys
int works well, but just for arrays. Not for map[sting]...-type of
relations.

String is more flexible, and works for both.
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 9, 2019

Codecov Report

Merging #20 into master will not change coverage.
The diff coverage is 100%.

Impacted Files Coverage Δ
validate.go 96.11% <100%> (ø) ⬆️

@Carpetsmoker Carpetsmoker merged commit 5cc392b into master Jan 9, 2019

4 checks passed

codecov/patch 100% of diff hit (target 95.32%)
Details
codecov/project 95.32% (+0%) compared to f14a58c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Carpetsmoker Carpetsmoker deleted the substr branch Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment