Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upBring lwan source code into TFB repository #1372
Comments
hamiltont
added this to the Round 11 milestone
Mar 5, 2015
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
No objections. I'll do this as soon as Round 10 is out. |
LadyMozzarella
added
the
implementation review
label
Mar 24, 2015
LadyMozzarella
added
Enhance: Framework
and removed
implementation review
labels
Mar 31, 2015
msmith-techempower
modified the milestones:
Round 12,
Round 11
Jan 29, 2016
msmith-techempower
removed this from the
Round 12 milestone
Mar 18, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Bump. Where do we stand on this? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
@lpereira any update on this? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
nbrady-techempower
closed this
Apr 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
hamiltont commentedMar 5, 2015
Instead of just pulling in a commit from the lwan repository, the TFB team would prefer to have the relevant source code stored inside our repository, especially as it's a fairly small amount. The install.sh should download the lwan framework, and then compile+link the small bit of code in our repository against that.
AFAIK every other framework uses this approach currently, if that's incorrect please comment
Ping @lpereira @bhauer @msmith-techempower