Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the amount of memory the framework container can use #4493

Closed
michaelhixson opened this issue Mar 1, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@michaelhixson
Copy link
Member

commented Mar 1, 2019

Limit the amount of memory that any framework's docker container can consume. Ideally, the framework will be able to use almost all available memory, but the toolset will ensure that just enough memory remains on the system for it to be functional. A framework with a memory leak should be unable to crash the toolset.

We don't want to hard-code system-specific memory limits anywhere. This feature should set a dynamic limit for the container based on the resources available on the host. For example, the limit might be available_memory * 0.95 or available_memory - 500mb.

I don't have an opinion on what exactly should happen when the framework reaches the limit as long as the toolset doesn't crash or exit (when in benchmark mode).

Currently, php/codeigniter is an example of a framework that appears to consume all available memory and then possibly crashes the toolset. Citrine manages to plow through this (though SSH session become unresponsive), but Azure cannot recover. Therefore, you could test this feature against the current version of our php/codeigniter implementation. The current commit is 813d3ab

This feature could impact performance of some frameworks so if we implement it, we should call this out in the blog post for the next round.

@michaelhixson

This comment has been minimized.

Copy link
Member Author

commented Mar 7, 2019

I guess this is fixed: #4494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.