Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Enable accelerated networking in Azure #4636
See discussion in #4281 (comment) for context.
Apparently, if you create new VMs in Azure with our instance type and recommended OS now, accelerated networking is enabled by default. Also, Microsoft wanted us to use accelerated networking in the past, but we couldn't because of the OS we used at the time. For both of those reasons, it makes sense to enable accelerated networking in TFB's Azure environment moving forward.
In the past few rounds we used an Azure environment that was provisioned "manually" through the Azure portal UI. When we created that environment, TFB still required Ubuntu 14.04, and accelerated networking was not supported there. We may have later upgraded the OS in place but not re-provisioned the instances, so we never enabled accelerated networking.
We retired that Azure environment and are creating a new one with Terraform. This is still a work in progress. Enabling accelerated networking there should be a one-line change.
The Terraform setting to enable:
The area of our Terraform script to change:
We expect this change to noticeably affect performance so we should call this change out in a blog post.