Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable accelerated networking in Azure #4636

Closed
michaelhixson opened this issue Apr 9, 2019 · 1 comment
Closed

Enable accelerated networking in Azure #4636

michaelhixson opened this issue Apr 9, 2019 · 1 comment
Labels

Comments

@michaelhixson
Copy link
Member

@michaelhixson michaelhixson commented Apr 9, 2019

See discussion in #4281 (comment) for context.

Apparently, if you create new VMs in Azure with our instance type and recommended OS now, accelerated networking is enabled by default. Also, Microsoft wanted us to use accelerated networking in the past, but we couldn't because of the OS we used at the time. For both of those reasons, it makes sense to enable accelerated networking in TFB's Azure environment moving forward.

In the past few rounds we used an Azure environment that was provisioned "manually" through the Azure portal UI. When we created that environment, TFB still required Ubuntu 14.04, and accelerated networking was not supported there. We may have later upgraded the OS in place but not re-provisioned the instances, so we never enabled accelerated networking.

We retired that Azure environment and are creating a new one with Terraform. This is still a work in progress. Enabling accelerated networking there should be a one-line change.

The Terraform setting to enable:
https://www.terraform.io/docs/providers/azurerm/r/network_interface.html#enable_accelerated_networking

The area of our Terraform script to change:
https://github.com/jsongte/tfb-azure-terraform/blob/f88cec19a3a8c2f6a4f1858b67af5ccb3b0e5864/terraform/tfb-app.tf#L27-L40

We expect this change to noticeably affect performance so we should call this change out in a blog post.

@michaelhixson
Copy link
Member Author

@michaelhixson michaelhixson commented Aug 1, 2019

This is done. We applied this change in our Terraform scripts before capturing Round 18, and then we called it out in the Round 18 blog post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant