-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wizzardo updates don't read randomNumber #4769
Comments
Agreed; I've opened #4770 -- thanks @sebastienros |
I have looked at 3 implementations so far and none read this field. So now I am questioning my understanding of the requirement. Do we only need to do a |
@sebastienros Yes, they should. Feel free to open new issues or list them here. I'll be honest; I think it's something we forget to check when merging update implementations. |
ok, thanks for confirming, the doubt had grown ... |
As per https://github.com/TechEmpower/FrameworkBenchmarks/wiki/Project-Information-Framework-Tests-Overview#database-updates on point .vi
At least the randomNumber field must be read from the database result set.
From my understanding of the current implementation it seems this value is never read:
https://github.com/TechEmpower/FrameworkBenchmarks/blob/master/frameworks/Java/wizzardo-http/src/main/java/com/wizzardo/techempower/DBController.java#L94
It shouldn't impact the overall performance but I think it's necessary for compliance.
The text was updated successfully, but these errors were encountered: