Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUr/Web upgrade #1248
Conversation
achlipala
added some commits
Dec 5, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Checked this out and it seems to work fine. LGTM! |
msmith-techempower
merged commit 2515abd
into
TechEmpower:master
Dec 22, 2014
1 check passed
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
achlipala
Dec 22, 2014
Contributor
Thanks! The script I pushed still uses sudo, but I noticed that framework code had generally been changed to avoid sudo. Maybe some amount of merge with the latest approach is called for? (I wrote this changeset before seeing the new convention.)
|
Thanks! The script I pushed still uses sudo, but I noticed that framework code had generally been changed to avoid sudo. Maybe some amount of merge with the latest approach is called for? (I wrote this changeset before seeing the new convention.) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
achlipala
Dec 22, 2014
Contributor
Oh, never mind; I was looking at my patch instead of the actual version that's been applied, with the changes to avoid sudo.
|
Oh, never mind; I was looking at my patch instead of the actual version that's been applied, with the changes to avoid sudo. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
msmith-techempower
Dec 22, 2014
Member
Yeah, it couldn't be automatically merged, so after I resolved the merge conflict I touched it up to use a localized installation method.
|
Yeah, it couldn't be automatically merged, so after I resolved the merge conflict I touched it up to use a localized installation method. |
achlipala commentedDec 6, 2014
No description provided.