Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upULib - This patch adds PostGres test alongside with minor fix #1292
Conversation
stefanocasazza
added some commits
Dec 24, 2014
hamiltont
reviewed
Dec 24, 2014
View changes
frameworks/C++/ULib/install.sh
hamiltont
reviewed
Dec 24, 2014
| @@ -56,18 +57,37 @@ fw_untar ULib-${ULIB_VERSION}.tar.gz | ||
| cd ULib-$ULIB_VERSION | ||
| # Check for the compiler support (We want at least g++ 4.8) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
hamiltont
Dec 24, 2014
Contributor
I think most compilation-based c++ projects perform this kind of check in their ./configure script - I'd guess there are some predefined functions you could use instead of rolling your own checks
hamiltont
Dec 24, 2014
Contributor
I think most compilation-based c++ projects perform this kind of check in their ./configure script - I'd guess there are some predefined functions you could use instead of rolling your own checks
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
stefanocasazza
Dec 27, 2014
Contributor
Hi,
my need is to use a version of g++ equal to or greater than 4.8, I do not know other ways to satisfy it, but I'm open to suggestions...
stefanocasazza
Dec 27, 2014
Contributor
Hi,
my need is to use a version of g++ equal to or greater than 4.8, I do not know other ways to satisfy it, but I'm open to suggestions...
hamiltont
reviewed
Dec 24, 2014
| @@ -0,0 +1,11 @@ | ||
| #!/bin/bash | ||
| export UMEMPOOL="545,0,0,37,8465,0,-17,-22,34" |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
hamiltont
Dec 24, 2014
Contributor
Question - can you tell me what this variable does? I've seen a few frameworks using it, but I can't seem to figure out what it's for
hamiltont
Dec 24, 2014
Contributor
Question - can you tell me what this variable does? I've seen a few frameworks using it, but I can't seem to figure out what it's for
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
stefanocasazza
Dec 27, 2014
Contributor
Hi,
the variable indicates how much memory to preallocate to the global memory pool in its various segments of stack, for details see
stefanocasazza
Dec 27, 2014
Contributor
Hi,
the variable indicates how much memory to preallocate to the global memory pool in its various segments of stack, for details see
hamiltont
reviewed
Dec 24, 2014
View changes
frameworks/C++/ULib/setup_postgres.sh
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
hamiltont
Dec 24, 2014
Contributor
Looks great to me! Before we merge, I need you to
- modify your install.sh to remove this line:
sudo apt-get install -y libmysqlclient-dev libsqlite3-dev postgresql-server-dev-9.3 libpq-dev(this content goes into prerequisites.sh) - rebase this, removing the DO NOT MERGE commit (once you're ready to merge, obviously)
|
Looks great to me! Before we merge, I need you to
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
hamiltont
Dec 25, 2014
Contributor
Oh, one more. Could you ensure your benchmark_config has at least one test named "default", like this. That let's someone do a toolset/run-tests.py --test ulib and it will run the test named default
|
Oh, one more. Could you ensure your benchmark_config has at least one test named "default", like this. That let's someone do a |
stefanocasazza
added some commits
Dec 27, 2014
stefanocasazza commentedDec 24, 2014
This patch adds PostGres test database alongside with minor fix...
All tests are passing as per my Travis-CI build log