New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Comsat webactors framework #1719

Merged
merged 1 commit into from Dec 14, 2015

Conversation

Projects
None yet
3 participants
@circlespainter
Contributor

circlespainter commented Aug 7, 2015

@circlespainter

This comment has been minimized.

Show comment
Hide comment
@circlespainter

circlespainter Sep 20, 2015

Contributor

It actually runs fine in my Vagrant env (tried with the latest ubuntu/trusty64 box but also previously) but it fails on CI; it looks like the java8 dependency can't be setup for some reason:

'ERROR: /toolset/setup/linux/languages/java8.sh: Command '\''sudo update-alternatives --set java $J7_HOME/jre/bin/java'\'' exited with status 2 (dependency=java8) (cwd=$FWROOT/installs)'
Setup comsat-webactors-servlet-tomcat: ERROR: /toolset/setup/linux/languages/java8.sh: Command 'sudo update-alternatives --set java $J7_HOME/jre/bin/java' exited with status 2 (dependency=java8) (cwd=$FWROOT/installs)

Do you see anything in the framework's build source that could cause this (apart from the dependency to java8 - which is there only because it's more performant, although the framework support java7 too)?

Contributor

circlespainter commented Sep 20, 2015

It actually runs fine in my Vagrant env (tried with the latest ubuntu/trusty64 box but also previously) but it fails on CI; it looks like the java8 dependency can't be setup for some reason:

'ERROR: /toolset/setup/linux/languages/java8.sh: Command '\''sudo update-alternatives --set java $J7_HOME/jre/bin/java'\'' exited with status 2 (dependency=java8) (cwd=$FWROOT/installs)'
Setup comsat-webactors-servlet-tomcat: ERROR: /toolset/setup/linux/languages/java8.sh: Command 'sudo update-alternatives --set java $J7_HOME/jre/bin/java' exited with status 2 (dependency=java8) (cwd=$FWROOT/installs)

Do you see anything in the framework's build source that could cause this (apart from the dependency to java8 - which is there only because it's more performant, although the framework support java7 too)?

@blee-techempower

This comment has been minimized.

Show comment
Hide comment
@blee-techempower

blee-techempower Oct 21, 2015

Contributor

Localtest failed. ( http://sprunge.us/IOWX )
Please resolve the issue.

Contributor

blee-techempower commented Oct 21, 2015

Localtest failed. ( http://sprunge.us/IOWX )
Please resolve the issue.

@circlespainter

This comment has been minimized.

Show comment
Hide comment
@circlespainter

circlespainter Oct 25, 2015

Contributor

I have merged upstream's master and re-run successfully the following tests in the vagrant-development environment:

cd FrameworkBenchmarks
toolset/run-tests.py --mode verify --test comsat-webactors
toolset/run-tests.py --mode verify --test comsat-webactors-netty
toolset/run-tests.py --mode verify --test comsat-webactors-servlet-undertow
toolset/run-tests.py --mode verify --test comsat-webactors-servlet-jetty
toolset/run-tests.py --mode verify --test comsat-webactors-servlet-tomcat
Contributor

circlespainter commented Oct 25, 2015

I have merged upstream's master and re-run successfully the following tests in the vagrant-development environment:

cd FrameworkBenchmarks
toolset/run-tests.py --mode verify --test comsat-webactors
toolset/run-tests.py --mode verify --test comsat-webactors-netty
toolset/run-tests.py --mode verify --test comsat-webactors-servlet-undertow
toolset/run-tests.py --mode verify --test comsat-webactors-servlet-jetty
toolset/run-tests.py --mode verify --test comsat-webactors-servlet-tomcat
@circlespainter

This comment has been minimized.

Show comment
Hide comment
@circlespainter

circlespainter Nov 26, 2015

Contributor

@blee-techempower Re-merged the most recent master and it still runs OK in vagrant-development but I still have a failure on CI (where, according to the message at the end of their build, other frameworks run fine because they haven't changed). The error says Usernames (e.g. --client-user, --runner-user, and --database-user) are required! and I could see that the run-ci.py script is indeed aborting if they're not defined (through benchmark.cfg or env variables if I understand correctly).

I tried to run them just as Travis would on my physical Mint box: I copied over and with the benchmark.cfg file in place (project root dir, I also replaced usernames with my own) they seem to succeed without problems. Not really sure if I should commit&push though, or with which settings exactly.

What am i missing in order to have Travis CI run OK too? Thanks.

Contributor

circlespainter commented Nov 26, 2015

@blee-techempower Re-merged the most recent master and it still runs OK in vagrant-development but I still have a failure on CI (where, according to the message at the end of their build, other frameworks run fine because they haven't changed). The error says Usernames (e.g. --client-user, --runner-user, and --database-user) are required! and I could see that the run-ci.py script is indeed aborting if they're not defined (through benchmark.cfg or env variables if I understand correctly).

I tried to run them just as Travis would on my physical Mint box: I copied over and with the benchmark.cfg file in place (project root dir, I also replaced usernames with my own) they seem to succeed without problems. Not really sure if I should commit&push though, or with which settings exactly.

What am i missing in order to have Travis CI run OK too? Thanks.

@msmith-techempower

This comment has been minimized.

Show comment
Hide comment
@msmith-techempower

msmith-techempower Dec 10, 2015

Member

@circlespainter We have recently fixed a lot of issues on Travis; please rebase from our latest master and push to have Travis-CI retest.

Member

msmith-techempower commented Dec 10, 2015

@circlespainter We have recently fixed a lot of issues on Travis; please rebase from our latest master and push to have Travis-CI retest.

@circlespainter

This comment has been minimized.

Show comment
Hide comment
@circlespainter

circlespainter Dec 14, 2015

Contributor

Rebased and squashed, now it builds ok. Thanks

Contributor

circlespainter commented Dec 14, 2015

Rebased and squashed, now it builds ok. Thanks

@msmith-techempower

This comment has been minimized.

Show comment
Hide comment
@msmith-techempower

msmith-techempower Dec 14, 2015

Member

Awesome! Both Travis-CI tests passed; LGTM!

Member

msmith-techempower commented Dec 14, 2015

Awesome! Both Travis-CI tests passed; LGTM!

msmith-techempower added a commit that referenced this pull request Dec 14, 2015

@msmith-techempower msmith-techempower merged commit 4feff48 into TechEmpower:master Dec 14, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment