/FrameworkBenchmarks

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup vibe.d test project #1771

Merged
merged 9 commits into from Dec 14, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
4 participants
@s-ludwig @whitebyte @msmith-techempower @dejlek
@s-ludwig
Contributor

s-ludwig commented Nov 24, 2015

The existing test failed to pass any of the tests. In addition to making that work, this PR also uses more idiomatic D code and implements the remaining tests (updates/fortunes).
@whitebyte

This comment has been minimized.

Show comment
Hide comment
@whitebyte

whitebyte Nov 24, 2015

I also think compiler vesion (https://github.com/TechEmpower/FrameworkBenchmarks/blob/master/toolset/setup/linux/languages/dlang.sh#L11) should be updated as well, or replaced with GDC/LDC,

whitebyte commented Nov 24, 2015

I also think compiler vesion (https://github.com/TechEmpower/FrameworkBenchmarks/blob/master/toolset/setup/linux/languages/dlang.sh#L11) should be updated as well, or replaced with GDC/LDC,
@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Nov 24, 2015

Contributor 
Usernames (e.g. --client-user, --runner-user, and --database-user) are required!

Any idea about that error? I don't think I have changed anything related to that and I'm a bit lost where to start looking for a fix

I also think compiler vesion (...) should be updated as well, or replaced with GDC/LDC,

True, I'd leave that to a separate PR, though. Another thing is that a MySQL, PostgreSQL and/or Redis version would be nice to have.
Contributor

s-ludwig commented Nov 24, 2015 

Usernames (e.g. --client-user, --runner-user, and --database-user) are required!

Any idea about that error? I don't think I have changed anything related to that and I'm a bit lost where to start looking for a fix

I also think compiler vesion (...) should be updated as well, or replaced with GDC/LDC,

True, I'd leave that to a separate PR, though. Another thing is that a MySQL, PostgreSQL and/or Redis version would be nice to have.
@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Nov 24, 2015

Contributor 
Usernames (e.g. --client-user, --runner-user, and --database-user) are required!

Any idea about that error? I don't think I have changed anything related to that and I'm a bit lost where to start looking for a fix

BTW, the test is successful for me locally (testing in a vagrant environment).
Contributor

s-ludwig commented Nov 24, 2015 

Usernames (e.g. --client-user, --runner-user, and --database-user) are required!

Any idea about that error? I don't think I have changed anything related to that and I'm a bit lost where to start looking for a fix

BTW, the test is successful for me locally (testing in a vagrant environment).
@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Nov 26, 2015

Contributor

This includes/supercedes #1723.
Contributor

s-ludwig commented Nov 26, 2015

This includes/supercedes #1723.
Show outdated Hide outdated frameworks/D/vibed/benchmark_config.json

@msmith-techempower msmith-techempower added the PR: Please Update label Dec 10, 2015

@msmith-techempower

This comment has been minimized.

Show comment
Hide comment
@msmith-techempower

msmith-techempower Dec 10, 2015

Member

@s-ludwig Please rebase from our latest master for Travis-CI to test.
Member

msmith-techempower commented Dec 10, 2015

@s-ludwig Please rebase from our latest master for Travis-CI to test.

s-ludwig added some commits Nov 24, 2015

@s-ludwig
Rewrite vibe.d benchmark test. 
- Fix all errors
- Implement all tests (updates/fortunes)
- Use the web framework instead of just low-level HTTP router functionality
- Use JSON/BSON serialization instead of manual creation of DOM objects
- Remove database creation code
- Prepares for adding additional tests using other databases
421d7e5
@s-ludwig
Add source_code for the "vibed" test.
53ccefb
@s-ludwig
Read $DBHOST directly within the test application. 
Also no need to force a rebuild.
d7076c2
@s-ludwig
Fix manifest constants.
53ef3cf
@s-ludwig
Build release version for benchmarking.
f55f65e
@s-ludwig
Use performance mode and a single TCP bind address. 
Uses multiple cores and GC-less request processing for better performance.
371f722
@s-ludwig
Avoid router match graph generation affecting benchmark result.
9408dcb
@s-ludwig
Fix accidental sharing of ConnectionPool across threads.
491df55
@s-ludwig
Upgrade D and DUB to the latest versions.
e6a078a
@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Dec 12, 2015

Contributor

Fixed and rebased. Now got failures in unrelated tests.
Contributor

s-ludwig commented Dec 12, 2015

Fixed and rebased. Now got failures in unrelated tests.
@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Dec 12, 2015

Contributor

Fixed and rebased (just got unrelated test failures now).
Contributor

s-ludwig commented Dec 12, 2015

Fixed and rebased (just got unrelated test failures now).
@msmith-techempower

This comment has been minimized.

Show comment
Hide comment
@msmith-techempower

msmith-techempower Dec 14, 2015

Member

Travis-CI confirms that vibed is passing; LGTM!
Member

msmith-techempower commented Dec 14, 2015

Travis-CI confirms that vibed is passing; LGTM!

msmith-techempower added a commit that referenced this pull request Dec 14, 2015

@msmith-techempower
Merge pull request #1771 from s-ludwig/fixup-vibed-test 
Fixup vibe.d test project
ba52473

@msmith-techempower msmith-techempower merged commit ba52473 into TechEmpower:master Dec 14, 2015
1 check was pending

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@msmith-techempower msmith-techempower referenced this pull request Dec 14, 2015

Closed

Update vibe.d setup.sh to build in release mode #1778

@dejlek

This comment has been minimized.

Show comment
Hide comment
@dejlek

dejlek Dec 29, 2015

Well, it may pass the Travis CI there, but vibed fails at every benchmark except the plain one it seems...

dejlek commented Dec 29, 2015

Well, it may pass the Travis CI there, but vibed fails at every benchmark except the plain one it seems...
@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Dec 30, 2015

Contributor 
                                                                                  The current benchmark round just doesn't yet contain the fixed results.                                                                                                                                                                                                                                                                                                                                         Gesendet von meinem BlackBerry 10-Smartphone.                                                                                                                                                                                                                Von: Dejan LekicGesendet: Dienstag, 29. Dezember 2015 17:33An: TechEmpower/FrameworkBenchmarksAntwort an: TechEmpower/FrameworkBenchmarksCc: Sönke LudwigBetreff: Re: [FrameworkBenchmarks] Fixup vibe.d test project (#1771)Well, it may pass the Travis CI there, but vibed fails at every benchmark except the plain one it seems...

—Reply to this email directly or view it on GitHub.
Contributor

s-ludwig commented Dec 30, 2015 

                                                                                  The current benchmark round just doesn't yet contain the fixed results.                                                                                                                                                                                                                                                                                                                                         Gesendet von meinem BlackBerry 10-Smartphone.                                                                                                                                                                                                                Von: Dejan LekicGesendet: Dienstag, 29. Dezember 2015 17:33An: TechEmpower/FrameworkBenchmarksAntwort an: TechEmpower/FrameworkBenchmarksCc: Sönke LudwigBetreff: Re: [FrameworkBenchmarks] Fixup vibe.d test project (#1771)Well, it may pass the Travis CI there, but vibed fails at every benchmark except the plain one it seems...

—Reply to this email directly or view it on GitHub.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment