Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upRevert phalcon to use php5 #2144
Conversation
knewmanTE
added some commits
Jul 6, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
knewmanTE
Jul 7, 2016
Contributor
PHP tests are all passing in Travis. The errors are coming from other frameworks that are known to be currently breaking.
|
PHP tests are all passing in Travis. The errors are coming from other frameworks that are known to be currently breaking. |
knewmanTE
added
Enhance: Framework
Round-14
labels
Jul 7, 2016
nbrady-techempower
merged commit 85f736c
into
TechEmpower:round-14
Jul 7, 2016
1 check failed
continuous-integration/travis-ci/pr
The Travis CI build could not complete due to an error
Details
knewmanTE
deleted the
knewmanTE:revert-phalcon-to-use-php5
branch
Sep 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
knewmanTE commentedJul 6, 2016
I originally thought Phalcon was running on PHP 7, but as it turns out, it was installing PHP 7 in
php7.shand then switching to PHP 5 in the separatephalcon.shfile.I also noticed and fixed a couple minor discrepancies between the PHP 7 and PHP 5 install scripts. We weren't disabling yaf or phalcon, and the redis download was commented out (possibly because, the last time someone was working on
php7.sh, there wasn't a redis version that was compatible with PHP 7).