update elixir version (to fix benchmark) #2216
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thousandsofthem
changed the title
|
|
||
| ELIXIR_HOME=$IROOT/elixir | ||
| VERSION="1.1.0-1" | ||
| VERSION="1.2.6-1" |
Author
|
possible, just not sure it'll work flawlessly with the old code. should i update to 1.3? |
|
I think we should if possible, I started working on upgrading Phoenix as well over the w-e, will try to wrap up tonight |
Contributor
|
@thousandsofthem @stevedomin I did a bit of this work already #2214 |
Author
|
Mine is quick patch to avoid missing yet another round (so sad) |
Member
|
I'm going to close this in favor of #2214. Thank you @thousandsofthem It looks like we are going to get that into round-13. |
Author
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest preview run for Phoenix is failing due to outdated elixir version.
This pull request updates elixir version to prevent issue with compiling phoenix
http://tfb-logs.techempower.com/round-13/preview-1/latest/logs/phoenix/