/FrameworkBenchmarks

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup metadata #2320

Merged
merged 19 commits into from Oct 27, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@msmith-techempower @ashawnbandy-te-tfb @martin-g @zhong-j-yu
@msmith-techempower
Member

msmith-techempower commented Oct 27, 2016

METADATA IS LIFE; METADATA IS LOVE!

msmith-techempower and others added some commits Mar 24, 2016

@msmith-techempower
Attempting to clean up PHP metadata
017032b
@msmith-techempower
Fixed an issue with HHVM
176e321
@msmith-techempower
Cleaned up a lot of stuff
ef8ba5d
@msmith-techempower
Merge branch 'master' into cleanup-metadata 
Conflicts:
	frameworks/C/h2o/benchmark_config.json
	frameworks/Go/echo/benchmark_config.json
	frameworks/Go/fasthttp-mysql/benchmark_config.json
	frameworks/Go/fasthttp-postgresql/benchmark_config.json
	frameworks/Go/go-std-mongodb/benchmark_config.json
	frameworks/Go/go-std-postgresql/benchmark_config.json
	frameworks/Go/go-std/benchmark_config.json
	frameworks/Go/revel-jet/benchmark_config.json
	frameworks/Go/revel-qbs/benchmark_config.json
	frameworks/Go/revel/benchmark_config.json
	frameworks/Java/comsat-webactors/benchmark_config.json
	frameworks/Java/jlhttp/benchmark_config.json
	frameworks/PHP/cakephp/benchmark_config.json
	frameworks/PHP/clancats/benchmark_config.json
	frameworks/PHP/codeigniter/benchmark_config.json
	frameworks/PHP/cygnite/benchmark_config.json
	frameworks/PHP/fat-free/benchmark_config.json
	frameworks/PHP/fuel/benchmark_config.json
	frameworks/PHP/hhvm/benchmark_config.json
	frameworks/PHP/kohana/benchmark_config.json
	frameworks/PHP/laravel/benchmark_config.json
	frameworks/PHP/limonade/benchmark_config.json
	frameworks/PHP/lithium/benchmark_config.json
	frameworks/PHP/lumen/benchmark_config.json
	frameworks/PHP/micromvc/benchmark_config.json
	frameworks/PHP/phalcon-micro/benchmark_config.json
	frameworks/PHP/phalcon/benchmark_config.json
	frameworks/PHP/php/benchmark_config.json
	frameworks/PHP/phpixie/benchmark_config.json
	frameworks/PHP/phreeze/benchmark_config.json
	frameworks/PHP/pimf/benchmark_config.json
	frameworks/PHP/silex-orm/benchmark_config.json
	frameworks/PHP/silex/benchmark_config.json
	frameworks/PHP/slim/benchmark_config.json
	frameworks/PHP/symfony2-stripped/benchmark_config.json
	frameworks/PHP/symfony2/benchmark_config.json
	frameworks/PHP/yaf/benchmark_config.json
	frameworks/PHP/yii2/benchmark_config.json
	frameworks/PHP/zend/benchmark_config.json
	frameworks/PHP/zend1/benchmark_config.json
2a97b72
@msmith-techempower
WIP
1cfff59
@ashawnbandy-te-tfb
In cases where there is no distinction in 'flavor' within a language … 
…use 'None' as the value for flavor.
dbb6803
@msmith-techempower
Merge pull request #2293 from ashawnbandy-te-tfb/cleanup-metadata-201… 
…60915-asb-1

Flavors to none
afff386
@ashawnbandy-te-tfb
Merge branch 'upstream-cleanup-metadata' into cleanup-metadata-201609… 
…15-asb-1
c6241fb
@ashawnbandy-te-tfb
metadata cleanup: remove plaintext, json and fortune from db permutat… 
…ions in fasthttp.
d581f1d
@ashawnbandy-te-tfb
metadata cleanup: Reviewed and cleaned-up platforms, following from h… 
…ttps://docs.google.com/spreadsheets/d/1S2JA2BeggUAN6_AzzCZPvF5C-sIJObzqbmLul15pYAU/edit?usp=sharing
1025002
@ashawnbandy-te-tfb
cleanup metadata: falcon and turbogears
cc498a3
@ashawnbandy-te-tfb
metadata cleanup: merged with upstream master
3ada750
@ashawnbandy-te-tfb
metadata cleanup: reduce ulib json permutations
5a44173
@ashawnbandy-te-tfb
metadata cleanup: remove fasthttp non-prefork for mysql.
9e2c5b9
@ashawnbandy-te-tfb
metadata cleanup: remove undertow edge
9d3454a
@msmith-techempower
Merge branch 'master' into cleanup-metadata 
Conflicts:
	frameworks/Java/rapidoid/benchmark_config.json
	frameworks/Java/sabina/benchmark_config.json
	frameworks/Python/web2py/benchmark_config.json
67864f7
@msmith-techempower
Merge branch 'cleanup-metadata' of github-msmith:TechEmpower/Framewor… 
…kBenchmarks into cleanup-metadata

Conflicts:
	frameworks/Java/sabina/benchmark_config.json
7806280
@ashawnbandy-te-tfb
Resolved conflicts with upstream cleanup-metadata.
88e374b
@msmith-techempower
Merge pull request #2317 from ashawnbandy-te-tfb/cleanup-metadata-201… 
…61013-asb-2

Cleanup metadata 20161013 asb 2
3e7e0dc
@ashawnbandy-te-tfb

This comment has been minimized.

Show comment
Hide comment
@ashawnbandy-te-tfb

ashawnbandy-te-tfb Oct 27, 2016

Contributor

METADATA GO!
Contributor

ashawnbandy-te-tfb commented Oct 27, 2016

METADATA GO!

@ashawnbandy-te-tfb ashawnbandy-te-tfb merged commit 83570b4 into master Oct 27, 2016
1 check was pending

1 check was pending

continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@ashawnbandy-te-tfb ashawnbandy-te-tfb deleted the cleanup-metadata branch Oct 27, 2016

@martin-g

This comment has been minimized.

Show comment
Hide comment
@martin-g

martin-g Oct 27, 2016

Contributor

This PR also removed some non-config files for undertow-edge.
Was this intentional?

On Oct 27, 2016 1:25 PM, "Mike Smith" notifications@github.com wrote:

METADATA IS LIFE; METADATA IS LOVE!

You can view, comment on, or merge this pull request online at:

#2320
Commit Summary

  • Attempting to clean up PHP metadata
  • Fixed an issue with HHVM
  • Cleaned up a lot of stuff
  • Merge branch 'master' into cleanup-metadata
  • WIP
  • In cases where there is no distinction in 'flavor' within a language
    use 'None' as the value for flavor.
  • Merge pull request #2293 from ashawnbandy-te-tfb/cleanup-
    metadata-20160915-asb-1
  • Merge branch 'upstream-cleanup-metadata' into
    cleanup-metadata-20160915-asb-1
  • metadata cleanup: remove plaintext, json and fortune from db
    permutations in fasthttp.
  • metadata cleanup: Reviewed and cleaned-up platforms, following from
    https://docs.google.com/spreadsheets/d/1S2JA2BeggUAN6_
    AzzCZPvF5C-sIJObzqbmLul15pYAU/edit?usp=sharing
    https://docs.google.com/spreadsheets/d/1S2JA2BeggUAN6_AzzCZPvF5C-sIJObzqbmLul15pYAU/edit?usp=sharing
  • cleanup metadata: falcon and turbogears
  • metadata cleanup: merged with upstream master
  • metadata cleanup: reduce ulib json permutations
  • metadata cleanup: remove fasthttp non-prefork for mysql.
  • metadata cleanup: remove undertow edge
  • Merge branch 'master' into cleanup-metadata
  • Merge branch 'cleanup-metadata' of github-msmith:TechEmpower/FrameworkBenchmarks
    into cleanup-metadata
  • Resolved conflicts with upstream cleanup-metadata.
  • Merge pull request #2317 from ashawnbandy-te-tfb/cleanup-
    metadata-20161013-asb-2

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#2320, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAOKQmRcYQNipCPEJKr_PKnDReVTI7xcks5q4NBTgaJpZM4Kijj6
.
Contributor

martin-g commented Oct 27, 2016

This PR also removed some non-config files for undertow-edge.
Was this intentional?

On Oct 27, 2016 1:25 PM, "Mike Smith" notifications@github.com wrote:

METADATA IS LIFE; METADATA IS LOVE!

You can view, comment on, or merge this pull request online at:

#2320
Commit Summary

  • Attempting to clean up PHP metadata
  • Fixed an issue with HHVM
  • Cleaned up a lot of stuff
  • Merge branch 'master' into cleanup-metadata
  • WIP
  • In cases where there is no distinction in 'flavor' within a language
    use 'None' as the value for flavor.
  • Merge pull request #2293 from ashawnbandy-te-tfb/cleanup-
    metadata-20160915-asb-1
  • Merge branch 'upstream-cleanup-metadata' into
    cleanup-metadata-20160915-asb-1
  • metadata cleanup: remove plaintext, json and fortune from db
    permutations in fasthttp.
  • metadata cleanup: Reviewed and cleaned-up platforms, following from
    https://docs.google.com/spreadsheets/d/1S2JA2BeggUAN6_
    AzzCZPvF5C-sIJObzqbmLul15pYAU/edit?usp=sharing
    https://docs.google.com/spreadsheets/d/1S2JA2BeggUAN6_AzzCZPvF5C-sIJObzqbmLul15pYAU/edit?usp=sharing
  • cleanup metadata: falcon and turbogears
  • metadata cleanup: merged with upstream master
  • metadata cleanup: reduce ulib json permutations
  • metadata cleanup: remove fasthttp non-prefork for mysql.
  • metadata cleanup: remove undertow edge
  • Merge branch 'master' into cleanup-metadata
  • Merge branch 'cleanup-metadata' of github-msmith:TechEmpower/FrameworkBenchmarks
    into cleanup-metadata
  • Resolved conflicts with upstream cleanup-metadata.
  • Merge pull request #2317 from ashawnbandy-te-tfb/cleanup-
    metadata-20161013-asb-2

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#2320, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAOKQmRcYQNipCPEJKr_PKnDReVTI7xcks5q4NBTgaJpZM4Kijj6
.
@msmith-techempower

This comment has been minimized.

Show comment
Hide comment
@msmith-techempower

msmith-techempower Oct 27, 2016

Member

Yes, it was our understanding that undertow-edge was an old undertow build that could be removed.
Member

msmith-techempower commented Oct 27, 2016

Yes, it was our understanding that undertow-edge was an old undertow build that could be removed.
@zhong-j-yu

This comment has been minimized.

Show comment
Hide comment
@zhong-j-yu

zhong-j-yu Nov 4, 2016

@msmith-techempower - in commit Cleaned up a lot of stuff, you changed bayou framework from "Realistic" to "Stripped". Can you give a source of the reason for the change? Thanks.

zhong-j-yu commented Nov 4, 2016

@msmith-techempower - in commit Cleaned up a lot of stuff, you changed bayou framework from "Realistic" to "Stripped". Can you give a source of the reason for the change? Thanks.

@stefanocasazza stefanocasazza referenced this pull request Nov 7, 2016

Merged

R13 fixes: ULib's benchmark meta-data json test #2337

@msmith-techempower

This comment has been minimized.

Show comment
Hide comment
@msmith-techempower

msmith-techempower Nov 7, 2016

Member

I believe bayou was changed to stripped because the code does not appear to exemplify a realistic approach to writing a webapp. Specifically, there does not appear to be routing outside of a naked switch statement and all of the business logic for the test implementations are done inline.

I realize that this is a hazy explanation of the realistic vs. stripped classification, but it's basically an eye-ball for our contributors and it appeared to be stripped in this case.
Member

msmith-techempower commented Nov 7, 2016

I believe bayou was changed to stripped because the code does not appear to exemplify a realistic approach to writing a webapp. Specifically, there does not appear to be routing outside of a naked switch statement and all of the business logic for the test implementations are done inline.

I realize that this is a hazy explanation of the realistic vs. stripped classification, but it's basically an eye-ball for our contributors and it appeared to be stripped in this case.
@zhong-j-yu

This comment has been minimized.

Show comment
Hide comment
@zhong-j-yu

zhong-j-yu Nov 7, 2016

Thank you for the reply. I'm quite surprised by the reasoning, because several frameworks that I'm familiar of are doing the same thing and they are not categorized as 'stripped'

https://github.com/TechEmpower/FrameworkBenchmarks/blob/master/frameworks/Java/netty/src/main/java/hello/HelloServerHandler.java

https://github.com/TechEmpower/FrameworkBenchmarks/blob/master/frameworks/Java/vertx/src/main/java/vertx/WebServer.java

https://github.com/TechEmpower/FrameworkBenchmarks/blob/master/frameworks/JavaScript/nodejs/routing.js

(note that in the case of nodejs, it's a hashmap created in app code, which is no different from switch)

I'm sure there are more frameworks doing the similar thing. My understanding is that this is a tests of HTTP frameworks, i.e. frameworks providing abstractions over HTTP semantics. Some frameworks provide just that, while leaving higher functions, like request routing, view rendering, to others. And some applications need exactly a bare-minimum HTTP engine and prefer to handle the rest by themselves.

In any case, if the categorization of 'stripped' is done by arbitrary contributors, without giving a notification to the framework, let alone a simple explanation, it is likely to be abused. I wonder why my framework is singled out and not many other similar ones.

zhong-j-yu commented Nov 7, 2016

Thank you for the reply. I'm quite surprised by the reasoning, because several frameworks that I'm familiar of are doing the same thing and they are not categorized as 'stripped'

https://github.com/TechEmpower/FrameworkBenchmarks/blob/master/frameworks/Java/netty/src/main/java/hello/HelloServerHandler.java

https://github.com/TechEmpower/FrameworkBenchmarks/blob/master/frameworks/Java/vertx/src/main/java/vertx/WebServer.java

https://github.com/TechEmpower/FrameworkBenchmarks/blob/master/frameworks/JavaScript/nodejs/routing.js

(note that in the case of nodejs, it's a hashmap created in app code, which is no different from switch)

I'm sure there are more frameworks doing the similar thing. My understanding is that this is a tests of HTTP frameworks, i.e. frameworks providing abstractions over HTTP semantics. Some frameworks provide just that, while leaving higher functions, like request routing, view rendering, to others. And some applications need exactly a bare-minimum HTTP engine and prefer to handle the rest by themselves.

In any case, if the categorization of 'stripped' is done by arbitrary contributors, without giving a notification to the framework, let alone a simple explanation, it is likely to be abused. I wonder why my framework is singled out and not many other similar ones.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment