Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upApply fixes for Resing test as stated in #2421 #2422
Conversation
jaguililla
and others
added some commits
Dec 16, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
nbrady-techempower
Dec 27, 2016
Member
Hi @jaguililla! I closed my PR in favor of yours here since it does the same thing, however this only fixes the default test. The resin test is still failing.
|
Hi @jaguililla! I closed my PR in favor of yours here since it does the same thing, however this only fixes the default test. The resin test is still failing. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
LadyMozzarella
Dec 27, 2016
Member
Merging this to fix the default test. Note that the resin implementation is still failing and will need some attention.
|
Merging this to fix the default test. Note that the resin implementation is still failing and will need some attention. |
LadyMozzarella
merged commit 104a391
into
TechEmpower:master
Dec 27, 2016
1 check failed
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jaguililla
Dec 27, 2016
Contributor
I made everything just as Tapestry (only one test, add write permission to project files, deploy the war with 'hexagon.war' instead 'ROOT.war') and it did not work.
The Resin logs looks good also.
I also downloaded the WAR from the Vagrant development machine and run it in a local Resin and it worked.
Could it be because it is in the Kotlin folder instead the Java folder?
I need some help here, I'm not able to see the problem.
|
I made everything just as Tapestry (only one test, add write permission to project files, deploy the war with 'hexagon.war' instead 'ROOT.war') and it did not work. The Resin logs looks good also. I also downloaded the WAR from the Vagrant development machine and run it in a local Resin and it worked. Could it be because it is in the I need some help here, I'm not able to see the problem. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
nbrady-techempower
Dec 27, 2016
Member
@jaguililla Could you open an issue for the problems you're having? For starters, are you trying to hit port 9090? The benchmark_config for the resin test is 8080. If you don't come up with anything, we can carry on in an issue.
|
@jaguililla Could you open an issue for the problems you're having? For starters, are you trying to hit port 9090? The benchmark_config for the resin test is 8080. If you don't come up with anything, we can carry on in an issue. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
I filed the #2434 issue. Thank you for your support! |
jaguililla commentedDec 27, 2016
No description provided.