New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kemal to 0.21.0 #2959

Merged
merged 1 commit into from Sep 12, 2017

Conversation

Projects
None yet
4 participants
@sdogruyol
Contributor

sdogruyol commented Sep 6, 2017

This PR updates Kemal to 0.21.0 and changes the repo to new organization

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Sep 6, 2017

Thanks @sdogruyol for contributing to The Framework Benchmarks! @Jesterovskiy, @RX14 and @cjnething, code you've worked on has been modified. If you have the chance, please review. If you wish to unsubscribe from these notices, please open a Pull Request with the commit message [ci skip] and your github name added to the userBlacklist array in the .mention-bot file.

mention-bot commented Sep 6, 2017

Thanks @sdogruyol for contributing to The Framework Benchmarks! @Jesterovskiy, @RX14 and @cjnething, code you've worked on has been modified. If you have the chance, please review. If you wish to unsubscribe from these notices, please open a Pull Request with the commit message [ci skip] and your github name added to the userBlacklist array in the .mention-bot file.

@faustinoaq

This comment has been minimized.

Show comment
Hide comment
@faustinoaq

faustinoaq Sep 6, 2017

Contributor

I think we need to update crystal too. Currently TFB is using crystal 0.22.0

https://github.com/TechEmpower/FrameworkBenchmarks/blob/master/toolset/setup/linux/languages/crystal.sh#L7

Also, if we update crystal to 0.23.1 then we need to add --no-debug flag to avoid crystal-lang/crystal#4719

Contributor

faustinoaq commented Sep 6, 2017

I think we need to update crystal too. Currently TFB is using crystal 0.22.0

https://github.com/TechEmpower/FrameworkBenchmarks/blob/master/toolset/setup/linux/languages/crystal.sh#L7

Also, if we update crystal to 0.23.1 then we need to add --no-debug flag to avoid crystal-lang/crystal#4719

@nbrady-techempower

This comment has been minimized.

Show comment
Hide comment
@nbrady-techempower

nbrady-techempower Sep 10, 2017

Member

@sdogruyol looks like this change needs to be made to the committed shard.lock as well right?

Setup kemal: Outdated shard.lock (kemal requirements changed). Please run shards update instead.

Member

nbrady-techempower commented Sep 10, 2017

@sdogruyol looks like this change needs to be made to the committed shard.lock as well right?

Setup kemal: Outdated shard.lock (kemal requirements changed). Please run shards update instead.

@faustinoaq

This comment has been minimized.

Show comment
Hide comment
@faustinoaq

faustinoaq Sep 10, 2017

Contributor

@nbrady-techempower yeah, you are right, thanks your comment!

Contributor

faustinoaq commented Sep 10, 2017

@nbrady-techempower yeah, you are right, thanks your comment!

@faustinoaq

This comment has been minimized.

Show comment
Hide comment
@faustinoaq

faustinoaq Sep 11, 2017

Contributor

@sdogruyol you need to update shard.lock too, just delete the current shard lock and generate a new one. Also @drujensen made a PR to update crystal, so, all should work fine.

Contributor

faustinoaq commented Sep 11, 2017

@sdogruyol you need to update shard.lock too, just delete the current shard lock and generate a new one. Also @drujensen made a PR to update crystal, so, all should work fine.

@faustinoaq

This comment has been minimized.

Show comment
Hide comment
@faustinoaq

faustinoaq Sep 12, 2017

Contributor

All crystal test are passing now 😄 , Why did Go/aah fail? Is it related to Crystal ?

Contributor

faustinoaq commented Sep 12, 2017

All crystal test are passing now 😄 , Why did Go/aah fail? Is it related to Crystal ?

@nbrady-techempower

This comment has been minimized.

Show comment
Hide comment
@nbrady-techempower

nbrady-techempower Sep 12, 2017

Member

@faustinoaq No, just a bug with the dynamic matrix that decides what tests need to be run based on the edits provided. I'll get this in for you guys.

Member

nbrady-techempower commented Sep 12, 2017

@faustinoaq No, just a bug with the dynamic matrix that decides what tests need to be run based on the edits provided. I'll get this in for you guys.

@nbrady-techempower nbrady-techempower merged commit 8de96b5 into TechEmpower:master Sep 12, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment