Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate Kemal to 0.21.0 #2959
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
mention-bot
Sep 6, 2017
Thanks @sdogruyol for contributing to The Framework Benchmarks! @Jesterovskiy, @RX14 and @cjnething, code you've worked on has been modified. If you have the chance, please review. If you wish to unsubscribe from these notices, please open a Pull Request with the commit message [ci skip] and your github name added to the userBlacklist array in the .mention-bot file.
mention-bot
commented
Sep 6, 2017
|
Thanks @sdogruyol for contributing to The Framework Benchmarks! @Jesterovskiy, @RX14 and @cjnething, code you've worked on has been modified. If you have the chance, please review. If you wish to unsubscribe from these notices, please open a Pull Request with the commit message |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
faustinoaq
Sep 6, 2017
Contributor
I think we need to update crystal too. Currently TFB is using crystal 0.22.0
Also, if we update crystal to 0.23.1 then we need to add --no-debug flag to avoid crystal-lang/crystal#4719
|
I think we need to update crystal too. Currently TFB is using crystal 0.22.0 Also, if we update crystal to 0.23.1 then we need to add |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
nbrady-techempower
Sep 10, 2017
Member
@sdogruyol looks like this change needs to be made to the committed shard.lock as well right?
Setup kemal: Outdated shard.lock (kemal requirements changed). Please run shards update instead.
|
@sdogruyol looks like this change needs to be made to the committed
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@nbrady-techempower yeah, you are right, thanks your comment! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
faustinoaq
Sep 11, 2017
Contributor
@sdogruyol you need to update shard.lock too, just delete the current shard lock and generate a new one. Also @drujensen made a PR to update crystal, so, all should work fine.
|
@sdogruyol you need to update |
faustinoaq
referenced this pull request
Sep 11, 2017
Merged
update crystal to latest version 0.23.1 #2965
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
faustinoaq
Sep 12, 2017
Contributor
All crystal test are passing now
|
All crystal test are passing now |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
nbrady-techempower
Sep 12, 2017
Member
@faustinoaq No, just a bug with the dynamic matrix that decides what tests need to be run based on the edits provided. I'll get this in for you guys.
|
@faustinoaq No, just a bug with the dynamic matrix that decides what tests need to be run based on the edits provided. I'll get this in for you guys. |
sdogruyol commentedSep 6, 2017
This PR updates Kemal to 0.21.0 and changes the repo to new organization