Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up[ci fw-only Java/servlet] Use Jdbc3ConnectionPool from PostgreJDBC #3365
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
nbrady-techempower
Mar 12, 2018
Member
@zloster same with this one if you don't mind targeting the docker branch. I just don't want to miss it as we're probably going to do some cherry-picking from master.
|
@zloster same with this one if you don't mind targeting the docker branch. I just don't want to miss it as we're probably going to do some cherry-picking from master. |
nbrady-techempower
added
the
PR: Please Update
label
Mar 12, 2018
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
zloster
Mar 12, 2018
Contributor
@nbrady-techempower Java/servlet is not updated in the Docker branch with the changes from #3324. Also it is not migrated to the Docker infrastructure yet.
|
@nbrady-techempower Java/servlet is not updated in the Docker branch with the changes from #3324. Also it is not migrated to the Docker infrastructure yet. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
nbrady-techempower
Mar 12, 2018
Member
@zloster You are right! I took a peek at the travis file and thought they were all set.
|
@zloster You are right! I took a peek at the travis file and thought they were all set. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
zloster
Mar 12, 2018
Contributor
@nbrady-techempower Is the "PR: Please Update" label still applicable here?
|
@nbrady-techempower Is the "PR: Please Update" label still applicable here? |
nbrady-techempower
removed
the
PR: Please Update
label
Mar 12, 2018
michaelhixson
referenced this pull request
Mar 21, 2018
Merged
Use Jdbc3ConnectionPool from PostgreJDBC (for docker branch) #3439
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
This is done in #3439 now, thanks! |
zloster commentedMar 6, 2018
According to the Resin documentation the
Driver classshould be a last resort.