Don't consider a server up after 5xx #3709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this change, we consider a server ready for verification if it responds to a curl command with any HTTP response, even if that response indicates a failure like 502 Bad Gateway. (This particular response can happen with frameworks that use nginx, when nginx has started but the back end server isn't ready yet.) With this change, we wait for a successful response. I added the fw-only tags because these two frameworks are currently failing on master due to this issue. They should pass now with this change.
Contributor
Author
|
I misspelled the tag for travis, but maybe that's for the best. |
michaelhixson
changed the title
Contributor
Author
|
I don't think any of the failures in that travis build are related to this, so I will go ahead with the merge. hhvm and yii2-hhvm are now succeeding where they were failing before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, we consider a server ready for verification if it
responds to a curl command with any HTTP response, even if that response
indicates a failure like 502 Bad Gateway. (This particular response can
happen with frameworks that use nginx, when nginx has started but the
back end server isn't ready yet.) With this change, we wait for a
successful response.
I added the fw-only tags because these two frameworks are currently
failing on master due to this issue. They should pass now with this
change.