From fd388e38d68ab252a2cb1313f324e98d1fbf78a2 Mon Sep 17 00:00:00 2001 From: Michael Hixson Date: Tue, 8 May 2018 12:24:26 -0700 Subject: [PATCH] [cw fw-only PHP/hhvm PHP/yii2-hhvm] Don't consider a server up after 5xx Without this change, we consider a server ready for verification if it responds to a curl command with any HTTP response, even if that response indicates a failure like 502 Bad Gateway. (This particular response can happen with frameworks that use nginx, when nginx has started but the back end server isn't ready yet.) With this change, we wait for a successful response. I added the fw-only tags because these two frameworks are currently failing on master due to this issue. They should pass now with this change. --- toolset/utils/docker_helper.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/toolset/utils/docker_helper.py b/toolset/utils/docker_helper.py index 597b3d7e61e..c14204a5889 100644 --- a/toolset/utils/docker_helper.py +++ b/toolset/utils/docker_helper.py @@ -336,7 +336,7 @@ def test_client_connection(self, url): try: self.client.containers.run( 'techempower/tfb.wrk', - 'curl --max-time 5 %s' % url, + 'curl --fail --max-time 5 %s' % url, remove=True, log_config={'type': None}, network=self.benchmarker.config.network,