From bc306548b047a6ccb97e81cbbbb202086c8266b2 Mon Sep 17 00:00:00 2001
From: "maxim.gorbatyuk" <maxim.gorbatyuk@outlook.com>
Date: Sun, 27 Apr 2025 08:20:18 +0500
Subject: [PATCH 1/4] Adjusted form

---
 .../add-salary/add-salary.component.html      |  12 +-
 .../components/add-salary/edit-salary-form.ts | 106 ++++++++++++++++++
 2 files changed, 117 insertions(+), 1 deletion(-)

diff --git a/src/app/modules/salaries/components/add-salary/add-salary.component.html b/src/app/modules/salaries/components/add-salary/add-salary.component.html
index 9c9d9b44..73a49095 100644
--- a/src/app/modules/salaries/components/add-salary/add-salary.component.html
+++ b/src/app/modules/salaries/components/add-salary/add-salary.component.html
@@ -2,7 +2,7 @@
 
 <div class="my-5 container">
   <div class="card">
-    <div class="card-body form-container">
+    <div class="card-body p-lg-5 p-3">
       <div class="mb-5 mt-1">
         <div class="mb-1 text-muted small fst-italic">
           Для того, чтобы просматривать график зарплат, вам нужно сначала внести
@@ -289,6 +289,16 @@
             ></app-field-error>
           </div>
 
+          <div class="mb-3" *ngIf="addSalaryForm.getInvalidFields().length > 0">
+            <div class="alert alert-warning">
+              <div class="mb-2"><strong>Внимание!</strong> Следующие поля не заполнены:</div>
+              <div class="mb-2" *ngFor="let field of addSalaryForm.getInvalidFields(); let i = index">
+                <div>{{ i + 1 }}. Страница {{ field.page }}</div>
+                <div class="ms-3" *ngFor="let control of field.fields; let j = index">{{i + 1}}.{{ j + 1 }}. {{ control }}</div>
+              </div>
+            </div>
+          </div>
+
           <div class="row mt-5">
             <div class="col-6">
               <button
diff --git a/src/app/modules/salaries/components/add-salary/edit-salary-form.ts b/src/app/modules/salaries/components/add-salary/edit-salary-form.ts
index 99d096df..df394436 100644
--- a/src/app/modules/salaries/components/add-salary/edit-salary-form.ts
+++ b/src/app/modules/salaries/components/add-salary/edit-salary-form.ts
@@ -11,9 +11,22 @@ import {
 } from "@services/user-salaries.service";
 import { FormatAsMoneyPipe } from "@shared/directives/format-as-money.pipe";
 
+interface InvalidFieldsGroupedByPage {
+  page: number;
+  fields: string[];
+}
+
+interface InvalidField {
+  page: number;
+  controlName: string;
+  field: string;
+}
+
 export class EditSalaryForm extends FormGroup {
   static readonly digitsPattern = "^[0-9]*$";
 
+  private _invalidFields: InvalidField[] = [];
+
   constructor(
     salarytoBeEditedOrNull: UserSalary | null,
     hasIndustries: boolean = false,
@@ -144,6 +157,19 @@ export class EditSalaryForm extends FormGroup {
       };
     }
 
+    this._invalidFields = [];
+    const controls = this.controls;
+    for (const name in controls) {
+      const control = this.controls[name];
+      if (control.invalid) {
+        this._invalidFields.push({
+          page: this.getPageForField(name),
+          controlName: name,
+          field: this.getControlNameLable(name),
+        });
+      }
+    }
+
     this.markAllAsTouched();
     return null;
   }
@@ -193,4 +219,84 @@ export class EditSalaryForm extends FormGroup {
     this.markAllAsTouched();
     return null;
   }
+
+  getInvalidFields(): InvalidFieldsGroupedByPage[] {
+    if (this._invalidFields.length === 0) {
+      return [];
+    }
+
+    const groupedByPage: InvalidFieldsGroupedByPage[] = [
+      {
+        page: 1,
+        fields: [],
+      },
+      {
+        page: 2,
+        fields: [],
+      },
+      {
+        page: 3,
+        fields: [],
+      },
+    ];
+
+    for (const invalidField of this._invalidFields) {
+      const page = invalidField.page;
+      groupedByPage[page - 1].fields.push(invalidField.field);
+    }
+
+    return groupedByPage;
+  }
+
+  private getControlNameLable(name: string): string {
+    switch (name) {
+      case "value":
+        return "Зарплата, NET";
+      case "quarter":
+        return "Квартал";
+      case "company":
+        return "Казахстанская / Удаленная компания";
+      case "profession":
+        return "Ваша специализация";
+      case "grade":
+        return "Ваш грейд";
+      case "workIndustryId":
+        return "Сфера деятельности компании";
+      case "city":
+        return "Город, в котором вы живете";
+      case "yearOfStartingWork":
+        return "Год старта вашей карьеры";
+      case "gender":
+          return "Пол";
+      case "age":
+        return "Сколько вам полных лет?";
+
+      default:
+        return "";
+    }
+  }
+
+  private getPageForField(name: string): number {
+    switch (name) {
+      case "value":
+        case "quarter":
+          case "company":
+            case "profession":
+        return 1;
+
+      case "grade":
+        case "workIndustryId":
+          case "city":
+            
+        return 2;
+
+      case "yearOfStartingWork":
+        case "gender":
+          case "age":
+        return 3;
+
+      default:
+        return 0;
+    }
+  }
 }

From 1a3ac3d50edd7a5640e8849781eebb26f7035402 Mon Sep 17 00:00:00 2001
From: "maxim.gorbatyuk" <maxim.gorbatyuk@outlook.com>
Date: Sun, 27 Apr 2025 08:30:50 +0500
Subject: [PATCH 2/4] pretty

---
 .../add-salary/add-salary.component.html      | 19 ++++++++++++++++---
 .../components/add-salary/edit-salary-form.ts | 17 ++++++++---------
 2 files changed, 24 insertions(+), 12 deletions(-)

diff --git a/src/app/modules/salaries/components/add-salary/add-salary.component.html b/src/app/modules/salaries/components/add-salary/add-salary.component.html
index 73a49095..1783a811 100644
--- a/src/app/modules/salaries/components/add-salary/add-salary.component.html
+++ b/src/app/modules/salaries/components/add-salary/add-salary.component.html
@@ -291,10 +291,23 @@
 
           <div class="mb-3" *ngIf="addSalaryForm.getInvalidFields().length > 0">
             <div class="alert alert-warning">
-              <div class="mb-2"><strong>Внимание!</strong> Следующие поля не заполнены:</div>
-              <div class="mb-2" *ngFor="let field of addSalaryForm.getInvalidFields(); let i = index">
+              <div class="mb-2">
+                <strong>Внимание!</strong> Следующие поля не заполнены:
+              </div>
+              <div
+                class="mb-2"
+                *ngFor="
+                  let field of addSalaryForm.getInvalidFields();
+                  let i = index
+                "
+              >
                 <div>{{ i + 1 }}. Страница {{ field.page }}</div>
-                <div class="ms-3" *ngFor="let control of field.fields; let j = index">{{i + 1}}.{{ j + 1 }}. {{ control }}</div>
+                <div
+                  class="ms-3"
+                  *ngFor="let control of field.fields; let j = index"
+                >
+                  {{ i + 1 }}.{{ j + 1 }}. {{ control }}
+                </div>
               </div>
             </div>
           </div>
diff --git a/src/app/modules/salaries/components/add-salary/edit-salary-form.ts b/src/app/modules/salaries/components/add-salary/edit-salary-form.ts
index df394436..8ff19755 100644
--- a/src/app/modules/salaries/components/add-salary/edit-salary-form.ts
+++ b/src/app/modules/salaries/components/add-salary/edit-salary-form.ts
@@ -267,7 +267,7 @@ export class EditSalaryForm extends FormGroup {
       case "yearOfStartingWork":
         return "Год старта вашей карьеры";
       case "gender":
-          return "Пол";
+        return "Пол";
       case "age":
         return "Сколько вам полных лет?";
 
@@ -279,20 +279,19 @@ export class EditSalaryForm extends FormGroup {
   private getPageForField(name: string): number {
     switch (name) {
       case "value":
-        case "quarter":
-          case "company":
-            case "profession":
+      case "quarter":
+      case "company":
+      case "profession":
         return 1;
 
       case "grade":
-        case "workIndustryId":
-          case "city":
-            
+      case "workIndustryId":
+      case "city":
         return 2;
 
       case "yearOfStartingWork":
-        case "gender":
-          case "age":
+      case "gender":
+      case "age":
         return 3;
 
       default:

From 35edaeb5a0af39fd5792e5eaec17f84791469ca2 Mon Sep 17 00:00:00 2001
From: "maxim.gorbatyuk" <maxim.gorbatyuk@outlook.com>
Date: Sun, 27 Apr 2025 08:47:59 +0500
Subject: [PATCH 3/4] Fixed test run

---
 package.json | 2 +-
 src/test.ts  | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/package.json b/package.json
index b4f87ed3..442db192 100644
--- a/package.json
+++ b/package.json
@@ -10,7 +10,7 @@
     "serve-staging": "ng serve --configuration=staging -o",
     "watch": "ng build --watch --configuration development",
     "test": "ng test --browsers ChromiumNoSandbox",
-    "test-headless-ci-only": "ng test --browsers ChromiumNoSandbox",
+    "test-headless-ci-only": "ng test --no-watch --browsers ChromiumNoSandbox",
     "lint": "ng lint",
     "pretty": "pretty-quick",
     "pretty-all": "prettier --write \"src/**/*.ts\" \"src/**/*.html\" \"src/**/*.scss\" \"src/**/*.json\" \"e2e/**/*.ts\" \"tools/**/*.ts\" \"*.json\"",
diff --git a/src/test.ts b/src/test.ts
index 07b42836..9fc6dc31 100644
--- a/src/test.ts
+++ b/src/test.ts
@@ -36,5 +36,6 @@ window.onbeforeunload = jasmine.createSpy();
 
 // Then we find all the tests.
 const context = require.context("./", true, /\.spec\.ts$/);
+
 // And load the modules.
 context.keys().map(context);

From 60d6503c1d54b95b4d0f9d9c524db93d0052af67 Mon Sep 17 00:00:00 2001
From: "maxim.gorbatyuk" <maxim.gorbatyuk@outlook.com>
Date: Sun, 27 Apr 2025 08:50:26 +0500
Subject: [PATCH 4/4] Fixed pipeline

---
 .github/workflows/test.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 5e5eabc7..47556e9e 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -8,9 +8,9 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Cache NPM dependencies
-        uses: actions/cache@v2
+        uses: actions/cache@v4
         with:
           path: ~/.npm
           key: ${{ runner.OS }}-npm-cache-${{ hashFiles('**/package-lock.json') }}