Skip to content

Conversation

@daniel-manta-hee
Copy link
Contributor

@daniel-manta-hee daniel-manta-hee commented Apr 28, 2022

This change was requested in comment https://hee-dls.atlassian.net/browse/DLSV2-520?focusedCommentId=10091 on the below Jira issue.

Also removing redundant code relative to Confirmed column on table SupervisorDelegates.

JIRA link

https://hee-dls.atlassian.net/browse/DLSV2-520

Description

Removed statuses column (Confirmed/Unconfirmed) and action links: Confirm/Reject from ManageSupervisors view.

Screenshots

image

Developer checks

Send invite

  • Go to Supervise/My staff list/Add a member of staff
  • Enter an email
  • Submit
  • Checked that invitation email is sent

Breakpoints:

  • DigitalLearningSolutions.Data\Services\FrameworkNotificationService.cs line 201
  • DigitalLearningSolutions.Data\Services\EmailService.cs line 52 (skip Authenticate and SendSingleEmailFromClient)
  • From builder.TextBody copy url link.

Either logout or use below breakpoint and skip if (User.Identity.IsAuthenticated):

  • C:\Repos\DLSV2\DigitalLearningSolutions.Web\Controllers\Register\RegisterController.cs line 68

Complete registration

  • Visit the link: replace server by your local host and visit the link
  • Enter personal information (remember email)
  • Enter Learner information
  • Create password (remember password)
  • Submit
  • Delegate registration complete

image

Check that you can log in as the delegate

  • Go to My Account
  • Log out
  • Log in

Check that you have access to launch course

image

Copy link
Contributor

@kevwhitt-hee kevwhitt-hee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also remove the redundant send reminder link - see code comment.

Copy link
Contributor

@kevwhitt-hee kevwhitt-hee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@kevwhitt-hee kevwhitt-hee merged commit c61b836 into master May 11, 2022
@kevwhitt-hee kevwhitt-hee deleted the Develop/Features/DLSV2-520-RemoveConfirmSupervisorDelegate branch May 11, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants